From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Wed, 02 Nov 2022 08:50:51 +0000 Message-ID: <87mt99spsk.fsf@gmail.com> References: <87sfj8umwb.fsf@posteo.net> <213f3549-de4e-25a7-5e27-d13893e557bc@yandex.ru> <87zgdfwkle.fsf@gmail.com> <8e31a89d-e35e-6dd0-a8e3-f0b9684c8bfa@yandex.ru> <87v8o3wgq1.fsf@gmail.com> <87ilk2x1si.fsf@gmail.com> <871qqq7l9p.fsf@posteo.net> <87eduqwekz.fsf@gmail.com> <87wn8invbx.fsf@posteo.net> <877d0iw8iq.fsf@gmail.com> <837d0hhlke.fsf@gnu.org> <46ff0065-5645-ef1e-2621-242fb6a73f98@yandex.ru> <87v8o0uxn5.fsf@gmail.com> <787a4362-7ff5-7dbb-9118-16e4bee5f328@yandex.ru> <87edunvhf2.fsf@gmail.com> <6d4d9e72-1bae-4d64-b7c1-c2b9c11e396f@yandex.ru> <6c9811d7-ad05-2d2d-0c34-9b4c1fa09305@yandex.ru> <87a659u7vo.fsf@gmail.com> <8735b1bvnz.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40766"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , manuel.uberti@inventati.org, 58839@debbugs.gnu.org, Dmitry Gutov To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 09:50:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oq9SK-000AMD-M0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 09:50:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oq9Rr-0004Zy-8H; Wed, 02 Nov 2022 04:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq9Rj-0004Y7-L1 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 04:50:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oq9Ri-0006et-NM for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 04:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oq9Ri-00034s-CW for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 04:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.166737898711806 (code B ref 58839); Wed, 02 Nov 2022 08:50:02 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 2 Nov 2022 08:49:47 +0000 Original-Received: from localhost ([127.0.0.1]:44903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq9RS-00034L-Qz for submit@debbugs.gnu.org; Wed, 02 Nov 2022 04:49:47 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:36541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq9RR-000349-Sp for 58839@debbugs.gnu.org; Wed, 02 Nov 2022 04:49:46 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id j15so23453633wrq.3 for <58839@debbugs.gnu.org>; Wed, 02 Nov 2022 01:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=UqO6Eoe2NqDqH4iJ3U7JsD0VWa0ZGpu0DdddY4sDWzU=; b=CZK0cHgoBV49hOJJXV9w7GkprbdCWuhWCe93b8OH8YO2g4vZtPZacW73fuy4SiQAGU KrmiT4ujgtlMYS3XQGfXEO6CMqO7qAMSRDUCIRqd9D98kLTiRDDoem6Mf2KdBA7YCttD dkYA+EvnJ+2VyTOteLHmTaOtXmB5fXyHA7JiyKjHHszVxh6uNbep9nTRB+SriLzl7K2d W1HA80oTwO3xjmbBRk5GQALoeaJE8YeJk0D/VI/BoV9W/0e97yIFeTWS73bRMTcQfzyI CKOZdyXH0A0ECG8a5MNawh/NhQAD7yepRYJk5kEqXPMSIohHp9sWO4+JvmHuVyfFIl6x xl9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UqO6Eoe2NqDqH4iJ3U7JsD0VWa0ZGpu0DdddY4sDWzU=; b=mc03ljS5WcREXMHWgPsn+fLpi+dNqzYlyEGXVEj/G52AanPkPZTNAJiiyJ0TRJbEHf na8wyhRthvAZytXSFHE+5FFw68HpWorCxDM2p8tpOCKD9ConPzX74RohHjEp6/qwMLbN DCKIr3SIoIOVhB7fqOMqV2g2ht3qK/P8XZcRwu9ryraY68RUEPUro6NHn7a69B7UIC1D /K4AyZ9faxnrPMXLze953BtTPWbncjEmrfZOENIvxje3ijEOEUSFLklzJN8FakBvbaET ipXXMtsvf9Dv6d+TwPQN2ZabXcWcRAPSQ6EYHGpbr4HR+dJjblbV9mYTlNFX98fbpi1t pYxQ== X-Gm-Message-State: ACrzQf0pZhcSlFE6x9VrrGhWSuHXsaKihsOpD4V6JxIC+/aRq5ThleFd RvY/lrjSctlXjjUHZjUeGpc= X-Google-Smtp-Source: AMsMyM7L+n65U9ydEV/2SynYN9TFIGPjpABUeeA3mC536MYqgDYZtHTWLz60z7nQje7s4/a0Aeib8Q== X-Received: by 2002:adf:ff90:0:b0:236:cb5d:4824 with SMTP id j16-20020adfff90000000b00236cb5d4824mr9642927wrr.718.1667378980204; Wed, 02 Nov 2022 01:49:40 -0700 (PDT) Original-Received: from krug (87-196-81-36.net.novis.pt. [87.196.81.36]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1490437wmb.36.2022.11.02.01.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 01:49:39 -0700 (PDT) In-Reply-To: <8735b1bvnz.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 02 Nov 2022 08:36:00 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246852 Archived-At: Philip Kaludercic writes: >> Not sure. This started has a report of hidden buffer being incorrectly >> killed by project.el. > > The issue that was reported was that Eglot/jsonrpc raised an error that > broke `project-kill-buffer'. This could have also all been solved by > wrapping a `with-demoted-errors' around `kill-buffer'. No. It couldn't. The error is there to show you among other things that the LSP connection isn't being shut down correctly, which is not something to paper over. And even if you did paper over the error, you would break eglot-autoshutdown. I've explained that at least 3 times already in the beginning of this discussion. >> Three people here have suggested an opt-in approach for the true >> positives. Now your strategy seems to be "OK: let all these false >> positives remain nonsensically associated with a project in >> project-buffers but let's have global databases of exceptions for >> specific operations, using a (largely redundant) mini-language for >> buffer-matching". > > For the record, I am still not convinced 100% either way. I just said that becasue you at one point did suggested the opt-in approach I have to admit that I am more and more inclined to make the list a opt-in thing, where we explicitly mark those major modes that are tied to a project. But of course it's OK to change one's mind back and forth.