all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry
@ 2022-11-20 21:52 Philip Kaludercic
  2022-11-21  8:27 ` Visuwesh
  0 siblings, 1 reply; 7+ messages in thread
From: Philip Kaludercic @ 2022-11-20 21:52 UTC (permalink / raw)
  To: 59422

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Tags: patch


It appears this was not documented via --help when added.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-11-19 built on quetzal
Repository revision: db3ff76dc7d3184e51cb7ed17c78ef76babb9032
Repository branch: master
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-pgtk --with-imagemagick'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-emacs.c-usage_message-Add-missing-init-directory.patch --]
[-- Type: text/patch, Size: 833 bytes --]

From 12a15353110cd6d4d57fb13ba2af9195078e6ac3 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Sun, 20 Nov 2022 22:51:14 +0100
Subject: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory
 entry

---
 src/emacs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/emacs.c b/src/emacs.c
index 85102acd28..bbcd0be74c 100644
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -291,6 +291,7 @@ #define MAIN_PROGRAM
 --no-site-lisp, -nsl        do not add site-lisp directories to load-path\n\
 --no-splash                 do not display a splash screen on startup\n\
 --no-window-system, -nw     do not communicate with X, ignoring $DISPLAY\n\
+--init-directory=DIR        use DIR to use when looking for the Emacs init files.\n\
 ",
     "\
 --quick, -Q                 equivalent to:\n\
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry
  2022-11-20 21:52 bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry Philip Kaludercic
@ 2022-11-21  8:27 ` Visuwesh
  2022-11-21 18:33   ` Philip Kaludercic
  0 siblings, 1 reply; 7+ messages in thread
From: Visuwesh @ 2022-11-21  8:27 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: 59422

[ஞாயிறு நவம்பர் 20, 2022] Philip Kaludercic wrote:

> Tags: patch
>
>
> It appears this was not documented via --help when added.
>
> [...]
>
> diff --git a/src/emacs.c b/src/emacs.c
> index 85102acd28..bbcd0be74c 100644
> --- a/src/emacs.c
> +++ b/src/emacs.c
> @@ -291,6 +291,7 @@ #define MAIN_PROGRAM
>  --no-site-lisp, -nsl        do not add site-lisp directories to load-path\n\
>  --no-splash                 do not display a splash screen on startup\n\
>  --no-window-system, -nw     do not communicate with X, ignoring $DISPLAY\n\
> +--init-directory=DIR        use DIR to use when looking for the Emacs init files.\n\
                               ^^^^^^^^^^^^^^
                               there appears to be a typo here.
>  ",
>      "\
>  --quick, -Q                 equivalent to:\n\





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry
  2022-11-21  8:27 ` Visuwesh
@ 2022-11-21 18:33   ` Philip Kaludercic
  2022-11-24 18:27     ` Stefan Kangas
  0 siblings, 1 reply; 7+ messages in thread
From: Philip Kaludercic @ 2022-11-21 18:33 UTC (permalink / raw)
  To: Visuwesh; +Cc: 59422

Visuwesh <visuweshm@gmail.com> writes:

> [ஞாயிறு நவம்பர் 20, 2022] Philip Kaludercic wrote:
>
>> Tags: patch
>>
>>
>> It appears this was not documented via --help when added.
>>
>> [...]
>>
>> diff --git a/src/emacs.c b/src/emacs.c
>> index 85102acd28..bbcd0be74c 100644
>> --- a/src/emacs.c
>> +++ b/src/emacs.c
>> @@ -291,6 +291,7 @@ #define MAIN_PROGRAM
>>  --no-site-lisp, -nsl        do not add site-lisp directories to load-path\n\
>>  --no-splash                 do not display a splash screen on startup\n\
>>  --no-window-system, -nw     do not communicate with X, ignoring $DISPLAY\n\
>> +--init-directory=DIR        use DIR to use when looking for the Emacs init files.\n\
>                                ^^^^^^^^^^^^^^
>                                there appears to be a typo here.

You are absolutely right, will change locally.

>>  ",
>>      "\
>>  --quick, -Q                 equivalent to:\n\





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry
  2022-11-21 18:33   ` Philip Kaludercic
@ 2022-11-24 18:27     ` Stefan Kangas
  2022-11-24 18:40       ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2022-11-24 18:27 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: 59422, Visuwesh

Philip Kaludercic <philipk@posteo.net> writes:

>>> diff --git a/src/emacs.c b/src/emacs.c
>>> index 85102acd28..bbcd0be74c 100644
>>> --- a/src/emacs.c
>>> +++ b/src/emacs.c
>>> @@ -291,6 +291,7 @@ #define MAIN_PROGRAM
>>>  --no-site-lisp, -nsl        do not add site-lisp directories to load-path\n\
>>>  --no-splash                 do not display a splash screen on startup\n\
>>>  --no-window-system, -nw     do not communicate with X, ignoring $DISPLAY\n\
>>> +--init-directory=DIR        use DIR to use when looking for the Emacs init files.\n\
>>                                ^^^^^^^^^^^^^^
>>                                there appears to be a typo here.
>
> You are absolutely right, will change locally.

Could you please also double check that the text in the doc/man/emacs.1
is up-to-date and makes sense too?

Other than that, LGTM with the above fix.  Thanks.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry
  2022-11-24 18:27     ` Stefan Kangas
@ 2022-11-24 18:40       ` Eli Zaretskii
  2022-11-24 18:51         ` Philip Kaludercic
  0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2022-11-24 18:40 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: philipk, 59422, visuweshm

> Cc: 59422@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 24 Nov 2022 10:27:13 -0800
> 
> Could you please also double check that the text in the doc/man/emacs.1
> is up-to-date and makes sense too?

I already did: it is and it does.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry
  2022-11-24 18:40       ` Eli Zaretskii
@ 2022-11-24 18:51         ` Philip Kaludercic
  2022-11-24 23:38           ` Stefan Kangas
  0 siblings, 1 reply; 7+ messages in thread
From: Philip Kaludercic @ 2022-11-24 18:51 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: visuweshm, Stefan Kangas, 59422

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 59422@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Thu, 24 Nov 2022 10:27:13 -0800
>> 
>> Could you please also double check that the text in the doc/man/emacs.1
>> is up-to-date and makes sense too?
>
> I already did: it is and it does.

I've pushed the change.  And the flag was added in bug#55839.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry
  2022-11-24 18:51         ` Philip Kaludercic
@ 2022-11-24 23:38           ` Stefan Kangas
  0 siblings, 0 replies; 7+ messages in thread
From: Stefan Kangas @ 2022-11-24 23:38 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: Eli Zaretskii, 59422-done, visuweshm

Philip Kaludercic <philipk@posteo.net> writes:

> I've pushed the change.  And the flag was added in bug#55839.

Thanks, so I'm closing this bug.





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-11-24 23:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-20 21:52 bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry Philip Kaludercic
2022-11-21  8:27 ` Visuwesh
2022-11-21 18:33   ` Philip Kaludercic
2022-11-24 18:27     ` Stefan Kangas
2022-11-24 18:40       ` Eli Zaretskii
2022-11-24 18:51         ` Philip Kaludercic
2022-11-24 23:38           ` Stefan Kangas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.