From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Wed, 23 Nov 2022 09:03:19 -0500 Message-ID: <87mt8hhif8.fsf@dfreeman.email> References: <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> <875yfm8lzf.fsf@gmail.com> <83wn82osoo.fsf@gnu.org> <871qq8xfzr.fsf@gmx.de> <87mt8uwo2q.fsf@dfreeman.email> <87zgcs6nvb.fsf@gmx.de> <87r0y3luad.fsf@dfreeman.email> <87iljf72ua.fsf@gmx.de> <87a64qykcf.fsf@gmx.de> <8735ab12pr.fsf@gmx.de> <720bcf72-e944-4978-982f-4b6fa8b31e5c@gmail.com> <83edttztfd.fsf@gnu.org> Reply-To: Danny Freeman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18897"; mail-complaints-to="usenet@ciao.gmane.io" Cc: felician.nemeth@gmail.com, 58790@debbugs.gnu.org, rcopley@gmail.com, michael.albinus@gmx.de, stefankangas@gmail.com, dgutov@yandex.ru, Eli Zaretskii To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 15:10:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxqSP-0004kb-EZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 15:10:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxqS2-000821-Nn; Wed, 23 Nov 2022 09:10:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxqRw-00081e-Ma for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 09:10:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxqRu-00027O-AC for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 09:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxqRt-0000LE-SF for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 09:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Danny Freeman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 14:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.16692125511246 (code B ref 58790); Wed, 23 Nov 2022 14:10:01 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 23 Nov 2022 14:09:11 +0000 Original-Received: from localhost ([127.0.0.1]:54217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxqR4-0000K2-Uf for submit@debbugs.gnu.org; Wed, 23 Nov 2022 09:09:11 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:32934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxqQz-0000Jq-2h for 58790@debbugs.gnu.org; Wed, 23 Nov 2022 09:09:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1669212543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f5msdWo9yvmZcGoroerhWPTTb73Fj8lpjFhGHb+AT1E=; b=HWi9L/nl2hesDB5+UGB1fdXXOCZFiscmv2koQnWfY09oNIiyWGeaM/DCY2HmD1W6CNjlex 87d/v+mrqoC2z8I3tJ/gYjb7Kb8MBgwGtrxrSCYsCpdhVg+6teLIMj9VB7HM7qgUT7ZIRg TJiZ8SiUD2P5nonE33aHdaiJhC0OK8I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248745 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Maybe I misunderstood, but it seemed like you were proposing that > we change url-parse.el so that it isn't fooled into thinking windows path > names are URLs with the drive letter as the 'url-type'. > > If that were the correct solution (I tend to think it is), then it would > _not_ suffice to fix Eglot on Emacsen older than 29, because url-parse.el > is not distributed separately as a :core ELPA package. > > So unless we made url-parse.el such a package, we would need a Danny's > "kludgy" patch to eglot.el anyway. > > In any case, I suggest that a solution be based on the patch shown in that >> bug#59338 discussion. >> > > Having now read Danny's patch, I think it's good to commit. > > Jo=C3=A3o Aside from the windows path bug, which is addressed in the other tick, is this ticket safe to close? Eglot now tries to avoid parsing non-file type URLs, and we decided against the warning message. Is there anything else to do? --=20 Danny Freeman