From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-heading-mode' Date: Thu, 08 Dec 2022 09:59:46 +0100 Message-ID: <87mt7ye0e5.fsf@gmail.com> References: <87v8mndrla.fsf@gmail.com> <837cz33wup.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10459"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59888@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 10:00:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3Clc-0002aJ-0n for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 10:00:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3ClR-0003Q6-AC; Thu, 08 Dec 2022 04:00:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ClA-0003PQ-PT for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3Cl8-0003Cr-GJ for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:00:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3Cl8-00060C-4r for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167049000123060 (code B ref 59888); Thu, 08 Dec 2022 09:00:02 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 8 Dec 2022 09:00:01 +0000 Original-Received: from localhost ([127.0.0.1]:55395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Cl6-0005za-OQ for submit@debbugs.gnu.org; Thu, 08 Dec 2022 04:00:01 -0500 Original-Received: from mail-ej1-f46.google.com ([209.85.218.46]:36352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Cl1-0005zU-Hq for 59888@debbugs.gnu.org; Thu, 08 Dec 2022 03:59:59 -0500 Original-Received: by mail-ej1-f46.google.com with SMTP id qk9so2324399ejc.3 for <59888@debbugs.gnu.org>; Thu, 08 Dec 2022 00:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=J/NrogAPqDMv8Tc9TRgMKdrkspJT6xRRa6ZRgW+f4t8=; b=fcujIMoyC6SDcckosr8j/akHQa4yAJegi91xMthA1K7yBl9DnDcY20O1ghjdD4KPFG KnqNDJdnjR9LWbxwrCUPQJgBrosHnOwfyaCFOeRyIWU17LhQusmLU/YbMxZYkxBqUIY4 fUA3svLCv5qWlIygar0YP+jnJ78tV5/l23XAevbVP9h+6yA/by8mVBdEX6WbRsMLrSdN shSK78i6clEs8QPrDxmaHAhXwO4BhAe3x5DAF2ZXF5DxfYI/X1FNtT4sUB7zhHSiX8qj zuEWQI2DDf5VW179sjeCBJJQG/ZZdzCuxVTYUkgSNXn836wkPAek8o8lqxsv3B3loq0E EqKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J/NrogAPqDMv8Tc9TRgMKdrkspJT6xRRa6ZRgW+f4t8=; b=nVNJ7O09APlxEWthsUzaWFXxQTreaT8QML7PouuXdIBc4ZEe8mEd8Z9z1Cy47bVkpD Q7RJEQ2Yby5kuOIG1z5DV8ScLIqGfCtCKjuQxeugrU17wjMC+p6d/xl0Ls7Sr1oihWSo eczg1r/EjKH9FjHcyOnxnle4yJC8xGr9YtoVmFLON6xtDuMy360lELIC+NY7K3+yuPUX 7v8xUzFHDlilhzhTjqV+FIiYtB4TrrnWkcDgTG4ny0iESETCVFLqb7x3wArDmsybPpvY SVpOoF0PNgs5e47294X6oeevS0mGw5iiz6aXpyK0ZyI+z1n3I+XksUYz3mgjdOZBFjQh qQtQ== X-Gm-Message-State: ANoB5pmOjuuaryQ1ur2PoEpx95jsLjEepJXvXZGB3zyMAsa071fgZYcg TyIgfKU6krZnQjETXuLLYFaqDRNCROBUuw== X-Google-Smtp-Source: AA0mqf7MGiHi9gqCPweSgDtyLs2IdJTuB5bkcqhYJS07aMvqPTJfBKIs6+WlUFqK0ESkKOUlUs3dMA== X-Received: by 2002:a17:906:7c45:b0:7c0:c45c:90e4 with SMTP id g5-20020a1709067c4500b007c0c45c90e4mr21086032ejp.473.1670489988041; Thu, 08 Dec 2022 00:59:48 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::a4bf]) by smtp.gmail.com with ESMTPSA id kx24-20020a170907775800b007c127e1511dsm973324ejc.220.2022.12.08.00.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 00:59:47 -0800 (PST) In-Reply-To: <837cz33wup.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Dec 2022 20:14:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250253 Archived-At: On Wed, 7 Dec 2022 at 20:14, Eli Zaretskii wrote: >> From: Augusto Stoffel >> Date: Wed, 07 Dec 2022 18:57:37 +0100 >> >> +(defcustom grep-heading-regexp >> + (rx bol >> + (or >> + (seq "Grep" (* (any "/a-zA-Z")) " " >> + (or "started" "finished" "exited" "interrupt" "killed" "terminated") > > Cannot these be translated to languages other than English in > localized versions of Grep? AFAICT these messages are generated by Emacs itself. We could also use "^Grep[/a-zA-Z]* [^\0t\]*$" here, which has a slightly higher change of being confused with actual grep output, but only when not using grep --null. >> 2. One could get rid of the awkward first alternative of >> `grep-heading-regexp' if there was a way to distringuish the grep >> process output from the header and footer added by grep-mode. > > You could put a special text property on the latter, no? That's an option and it would be useful for other extensions as well. So we would define something like --8<---------------cut here---------------start------------->8--- (defun compilation-insert-note (&rest args) (let ((start (point))) (apply #'insert args) (put-text-property start (point) 'compilation-note t))) --8<---------------cut here---------------end--------------->8--- and use throughout compile.el, right?