From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict Date: Tue, 31 Jan 2023 16:48:02 +0100 Message-ID: <87mt5yogct.fsf@gmail.com> References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> <831qna3frm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12991"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, mail@daniel-mendler.de, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 31 16:49:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMst2-0003ET-Pj for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Jan 2023 16:49:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMssA-0007UR-A8; Tue, 31 Jan 2023 10:48:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMsrf-0007OU-Lx for emacs-devel@gnu.org; Tue, 31 Jan 2023 10:48:08 -0500 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMsrd-00066F-Tf; Tue, 31 Jan 2023 10:48:07 -0500 Original-Received: by mail-wm1-x32c.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so12781222wma.1; Tue, 31 Jan 2023 07:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=C2JW82SUFBMAWjnsBDqWODcCWq+85aoSow7biK44vNg=; b=ZaXhsKGohTMUcsyC/QvUkckpiS027JWx9sQ6aq2Map39+uwzPb/DDPDU6fsuJjxV0T pZe1E6vWWEbiA6doTWYkS4m1RZsPL84I5vpftHbK5EB2frest//xDfmX2nf8yeHNdNal JVUYmPvqkIxM+hHn7rdCGtWYvhUtIJMu03BZFP8McJ7lXGeNmm8nFRMI/oA4PXiWdq+w 6dkkyCRQgrYBaiCK/OoIDpS4vaEQj2Jz0MEY9g3li9mESs8zrLfSsLnPHDVXQdcZqjko /xSYDTbePSNUAbu2ryxGiNc55fPo71blbCbKhS5r9vAyLI6Q7kvki12kxXlKu0A/6jPz +kiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C2JW82SUFBMAWjnsBDqWODcCWq+85aoSow7biK44vNg=; b=2iO27MHaYIoxbPD8dfsrepF8rceNZrnJAltVK9rB2xN31KLFO2E0x+T13pE9R5ohnX pEJEF025FGMx7UG7hDxOxH4WYvnfgckvTBD2efCl2tl+ASoR6gkd8O4RTOydIPISsp0z Cd8NmPHPVQweHLmfs+giqrNU5GXEs2/hT8p3pex2fjdBBhao2IsVw5FfWZq7QV87XiF8 2c/jWq3ShIANahcZ6uIxG/F3WfSkJJn0dcGF4T0XPrKRKkJ19t/NeS+PkqRianCIn60c fRfk6pSjoLViDJSbPv/zeaj9pEYEbcV6LxdLkJIKcVbCAQ/F6QzYQTQWdMKs3XqJ9UeV uvzA== X-Gm-Message-State: AFqh2kr0Pou6ZDyG/f/49OkqA+cBU7jlmCEX36pg0SyXUoZqaHK6Qjuw 9SKyekx1AWBBLDMJltGuRrE= X-Google-Smtp-Source: AMrXdXsBlIsl/m4NlhaQR/MsFXrJ4poUoU0qxb1j7+bNrgBfORkjPelANUex/N+myWbGK41nJhkjXg== X-Received: by 2002:a05:600c:310e:b0:3db:fc3:6de4 with SMTP id g14-20020a05600c310e00b003db0fc36de4mr51341534wmo.35.1675180083908; Tue, 31 Jan 2023 07:48:03 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id j5-20020a05600c1c0500b003dc4aae4739sm14207087wms.27.2023.01.31.07.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 07:48:03 -0800 (PST) In-Reply-To: <831qna3frm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Jan 2023 17:06:21 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302837 Archived-At: >>>>> On Tue, 31 Jan 2023 17:06:21 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Daniel Mendler , emacs-devel@gnu.org, = Stefan >> Monnier , Eli Zaretskii >> Date: Tue, 31 Jan 2023 10:05:15 +0100 >>=20 Lars> So keymap-local-set and keymap-global-set should be fixed to be s= trict Lars> again, otherwise there's not much point to the entire `keymap-*' Lars> exercise. >>=20 >> OK. How about this then (why are the `cursor-in-echo-area' shenaniga= ns >> necessary? I wonder if that=CA=BCs a bug, since without them we eith= er get >> the cursor not showing in the minibuffer for >> `read-key-sequence-vector', or we get an extra space displayed by >> `read-command') Eli> Why does it have to be so complicated, though? If the problem is = not Eli> to call key-description in non-interactive invocations, can't we c= all Eli> key-description inside the interactive form? Or use some other tr= ick Eli> to invoke key-description only in interactive calls? ? We=CA=BCre only calling key-description inside `interactive' in the patch. Ideally I=CA=BCd like to use a format string to `interactive', and massage the results, but I don=CA=BCt think that=CA=BCs possible (I=CA=BCd = love to be wrong). I guess we could use `called-interactively-p', but that=CA=BCs frowned upon, or add an optional `interactive' arg that=CA=BCs set to `t' by the `interactive' call, but that all feels messy. Or we add a new interactive spec: '=CE=9A' that does the same as 'K' but calls `key-description' (I=CA=BCm joking) Robert --=20