From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#61679: 29.0.60; Eglot: staying out of trouble Date: Tue, 21 Feb 2023 15:31:23 +0100 Message-ID: <87mt57f5tw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2376"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: 61679@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 21 15:32:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUTgp-0000T8-56 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Feb 2023 15:32:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUTgb-0005UR-CE; Tue, 21 Feb 2023 09:32:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUTgY-0005U1-VN for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 09:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUTgY-0002xL-MQ for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 09:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUTgY-00019V-Hy; Tue, 21 Feb 2023 09:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: joaotavora@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Feb 2023 14:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61679 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Received: via spool by submit@debbugs.gnu.org id=B.16769898914383 (code B ref -1); Tue, 21 Feb 2023 14:32:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Feb 2023 14:31:31 +0000 Original-Received: from localhost ([127.0.0.1]:55116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUTg3-00018d-AD for submit@debbugs.gnu.org; Tue, 21 Feb 2023 09:31:31 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:59348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUTg1-00018V-3A for submit@debbugs.gnu.org; Tue, 21 Feb 2023 09:31:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUTg0-0005EL-Pf for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 09:31:28 -0500 Original-Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUTfz-0002n1-6L for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 09:31:28 -0500 Original-Received: by mail-ed1-x52a.google.com with SMTP id cy6so12498292edb.5 for ; Tue, 21 Feb 2023 06:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=4cbf5Rvrtt2jFL6bidNox+DOc2K3pZ3LYRsL4s6N7SI=; b=QzHfa7syeMsMQkTS9Sz9ERSvG8OAtP9ogMit/YH30ZuHIjTJqupk+YJzhusqrb74p3 2L71RSzFVz0n019MSdXMMGJ6RqQoj4PqIhfJakjJ6HiRByXVUpv3Htx+Tw/5MkRN0Rck 0Tv/PDQqW/YHquOxmo28y6aqVYrT4RBBkaAYJqfxrJKXBLrD82Cl2VBq981b+vqvL8GI /lLea7lTZErOrtQ5KvjQKYUpdAdaVZ0jMy1DqlMlQELnu9k6En8FKXG0v0QvSro0kYHn 7V7ZjTXiXCfRzhOQffdHaSIGpeceDIzNg4HazCDrTSDaoOkDoC6VIU1Y9XxwTKruaNUb /pjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4cbf5Rvrtt2jFL6bidNox+DOc2K3pZ3LYRsL4s6N7SI=; b=C35jVDPh5YlYdHOR2R+2vR0UF3Du77E0pJh9vA5kL+HwO5Z51IdggxS54RtZwJVjUH 7qy0i86+9Km6stCs0YVYtXAiDojhGBdyUbYpsYZ3SEDEKanM04SkDG2FxEsxSNMu1niA 9kApNJwcA7TjabrwP+wDU/1xKkpWh8+ximYjg8XyLNmn35IlZZ6zUCOG7DKaDYxuzAGG HBlJVS1poKFTMmjzUimPW5k8EwBZ1v7mFz1BXHNX6cynUinuiVNW12tFYOFM2JnV6mAl nkwZj3P0/n45kBHKr+ud4ymveZN/KK2h5lvF+y8zVN41FX7tLvFQwY67TeK2miKAOB4U hTow== X-Gm-Message-State: AO0yUKWqIJFWishVR4+3dbIK80tL6hBy5J8mvpNR64MOy9RVvtjLXOoR Kh+wr0uozHrrQZLOJK9BApL1Hnb3C+4= X-Google-Smtp-Source: AK7set/pjtHFR6zD3s/Y6G3avrWko8SGJyK3RKNVHi54+CzrFMBqq5RhJpOdDW/CET1w1b5jGX6r1w== X-Received: by 2002:a17:906:d99:b0:8b2:2141:6de8 with SMTP id m25-20020a1709060d9900b008b221416de8mr14226190eji.73.1676989885007; Tue, 21 Feb 2023 06:31:25 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id p20-20020a1709060dd400b008be5b97ca49sm4572239eji.150.2023.02.21.06.31.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 06:31:24 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=arstoffel@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256275 Archived-At: Eglot modifies several Emacs features, and it seems to do so independently of the server capabilities. For instance, it registers a capf and Eldoc functions even if the server does't provide completions respectively "hover"/signature help. In some cases (capf, xref) this seems innocuous, in others (eldoc) Eglot is really overwriting a possibly useful function with a possibly useless one. Now, the above are somewhat silly examples, but the Flymake case is quite problematic. There exist good servers that don't provide diagnostics, and Eglot still overwrites `flymake-diagnostic-functions'. To make things worse, LSP doesn't provide a way to the server to advertise whether or not it provides diagnostics. I would suggest that Elgot initially should keep flymake-diagnostic-functions unchanged, and only overwrite it when the first diagnostic comes from the server.