From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Sat, 18 Mar 2023 10:38:39 +0100 Message-ID: <87mt4az9eo.fsf@gmx.de> References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> <875yb1pxai.fsf@miha-pc> <87ttykj45i.fsf@gmx.de> <878rfw51mh.fsf@gmail.com> <87pm98iw1e.fsf@gmx.de> <87fsa43f36.fsf@gmail.com> <87sfe4eh09.fsf@gmx.de> <87wn3g1ssd.fsf@gmail.com> <87fsa3ejxq.fsf@gmx.de> <87pm97eibv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62194@debbugs.gnu.org, miha@kamnitnik.top To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 10:39:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdT20-0007n8-0r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 10:39:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdT1k-0002QM-Lz; Sat, 18 Mar 2023 05:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdT1i-0002Pq-PJ for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 05:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdT1i-0001Ta-Bc for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 05:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdT1i-0006gX-6U for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 05:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.167913233225680 (code B ref 62194); Sat, 18 Mar 2023 09:39:02 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 18 Mar 2023 09:38:52 +0000 Original-Received: from localhost ([127.0.0.1]:46220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdT1X-0006g8-V7 for submit@debbugs.gnu.org; Sat, 18 Mar 2023 05:38:52 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:40143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdT1W-0006fv-Aj for 62194@debbugs.gnu.org; Sat, 18 Mar 2023 05:38:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679132323; i=michael.albinus@gmx.de; bh=sSMpQpvFCTJb837ZECSf53vxh3lB9e15QuQu7zU/fko=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=DHzx+lnFm3pg0UoT4NH2+Jq0qVJ/ch2VaP1asVX1pq6H83wwipqCMrngYS/yZnZrp yMqKQn4IZkG8HAnbmWyeZogFCk4bJS5TgXaFWK1cGdYckkDfjyqzJqZirSVkUIR3f5 GFZeAkNeA78VnjGkV6mmye04p4mkYK6k/tnfyHMkCY1knAtR8ZK+w4piyd/Y6FkEjc znnbaUHxwLO4eES6Vg8v1AIio4KQ+iNF92dM/L2y3cRHJ/iJjFQ32qsaUs4QmInPXY ZQeLmxe646Qhc7HQs6Ha/E5IsG9I2e9k/1MvBJHKqaehgBVUBpJB/r7pAljuI01QM5 TzZ6Lwcf8nHRg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQvD5-1ppvEq0yE3-00NyUI; Sat, 18 Mar 2023 10:38:43 +0100 In-Reply-To: <87pm97eibv.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 17 Mar 2023 11:19:16 +0000") X-Provags-ID: V03:K1:TrT9+OLv+/imkldSc3TF3cYk7RpiSSUQFWiz1B3BevuF5uJe41c yt9pGcfrzTMILITN+a69LD5GQb6P/RLkL3Ll4Pyuljw56zB1jjTIcPiiaDvSKVeRgxfdVsj kB59net2b1f0ieSLpK51ydd0DYBkETflWnuYSZZp2ZpET6DqFsqpfUt38WNEMZsaXGJLV68 0kd0127y1tM7GxzkcwALA== UI-OutboundReport: notjunk:1;M01:P0:93YpQ0OL3kQ=;cr1E7TK8vJX4Ed8BG35loOTOrFq osc2RJoGvDUGM4cSx48/HT+VXwahXpeFU1bQDTSQqF4QkozgYyzQMrP4CaSJb/dPEB5EQll2Y 4j0iySKdC0SsEqK5Y8d5NfcNuvWk2tgFb+Ju2N470y5rCv8dqnOOm36sUjdeN5kT+q5ADSQI9 gWK2A6c86b4HpojlkxHeBpkiFp5j7kts+LP3/U/G2d/6+O8f7S0s/9eFwUSZQYShnVGrqxIB4 qdOLcOJgaBm2kQT3clTf2FhEiIYKZH6c+Rf35T05LwTjHXEFkybOtHJY8tcE8l5M/8HiosDtm x5uL6O5QBOhzTXJVpZNobY0Pv8srBN9cLat3mWJQSWu3KQz9nQQHBuFfevrUFcBP4acXIfxyO DVgHRe7mmme07Tvja6Rg/mf+m09lrAlyBCBaOlVQ3tSWw2e5YjEzOz/me5/jV5JmnJ/wRgmOh xCL/aafHiGKOwxw8Dfyy8Yp85MUgJh1IWt5DXwdv6VI6GnoWCatCaQBJ74aT9ggZLLDQDqKrs qrjEQiMiKF8khtieJ0TZA2Yai0xt43nQccYDiuZD3QYTxnjtxe/5aKDmr9TbbIrjwomYVOqqY IufbNzz0gqqP8FrytewnrxJtkYQVU5btaoRKL0PnwkS5PR0ufO9eDAgb4c+3CR7TkZ6EqL/rH ebNUmdxxJIQ22u0JcTY5eiG9tx5ROTJQoet7JXop9AyK7d556VV3SlJVaXlixAR1/jazwdlON p1jeebJrDtzNBtYtx/WkaqPufKuRDtCvP+Kn6+ddda+4wUvi+LDi6ttuuk7eL8nqnNWtBJH0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258149 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, >> I've applied the patch, but Thomas' recipe still blocks for me. Sorry to >> tell you. > > Drats. Reproduced. > > I honestly don't know what's going on. Yesterday I got 0% failures, > today I get 100% failures with the very same code. Maybe there is some > SSH/ControlMaster thing at the OS level that's tainting the experiment. So I propose we let the state as-it-is in master. The relevant tests pass successfully, and we have your workaround in eglot.el, which makes the situation a little bit better. Just one remark: perhaps you could change this to --8<---------------cut here---------------start------------->8--- (let ((default-directory default-directory) ;; bug#61350: Tramp turns on a feature ;; by default that can't (yet) handle ;; very much data so we turn it off ;; unconditionally -- just for our ;; process. (tramp-use-ssh-controlmaster-options 'suppres= s) (tramp-ssh-controlmaster-options "-o ControlMaster=3Dno -o ControlPath=3Dnone= ")) --8<---------------cut here---------------end--------------->8--- For the Tramp < 2.6.0.3 it still works, because tramp-use-ssh-controlmaster-options is non-nil, and tramp-ssh-controlmaster-options is used. Starting with Tramp 2.6.0.3, the value `suppress' forces Tramp to compute its own tramp-ssh-controlmaster-options, which might be the same, or not. But it is Tramp's responsibility to DTRT. Note that I have plans to enable shared connections also for PuTTY, by a similar option tramp-use-shared-connection (or similar, not decided yet). But this will be relevant for MS Windows users only; I don't know how many of them use eglot. And it will definitively be in Tramp 2.7 only. As proposed. we shall close *this* bug. The reported problem is fixed, and for everything else we have bug#61350. > FWIW, removing the JUST-THIS-ONE make Thomas' example always pass, but > it has other implications like the re-entrancy thing, which I don't > understand. > > I don't have any better ideas at the moment, other than just biting the > bullet and reading Tramp's code very closely. I'll try my hand at > adapting a process-filter into it as I described in bug#61350, but I > don't know if I'll manage of course, since I'm not closely acquainted > with the API. I will continue to bring threads into play with Tramp, again. Slow progress only. But perhaps, it helps to improve the situation. > Very sorry for the noise, > Jo=C3=A3o Best regards, Michael.