From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62573: 29.0.60; Cursor color not being inverted in emacs-29 Date: Sun, 02 Apr 2023 08:44:09 +0800 Message-ID: <87mt3rru3q.fsf@yahoo.com> References: <83edp420lx.fsf@gnu.org> <83bkk817rr.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34268"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Al Haji-Ali , Eli Zaretskii , 62573@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 02 02:45:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pilqW-0008h2-KA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Apr 2023 02:45:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pilqD-0006MH-5a; Sat, 01 Apr 2023 20:45:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pilqC-0006M8-1g for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 20:45:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pilqB-0008N6-61 for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 20:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pilqA-00012X-K0 for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 20:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 00:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62573 X-GNU-PR-Package: emacs Original-Received: via spool by 62573-submit@debbugs.gnu.org id=B62573.16803962653929 (code B ref 62573); Sun, 02 Apr 2023 00:45:02 +0000 Original-Received: (at 62573) by debbugs.gnu.org; 2 Apr 2023 00:44:25 +0000 Original-Received: from localhost ([127.0.0.1]:38735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pilpZ-00011I-7q for submit@debbugs.gnu.org; Sat, 01 Apr 2023 20:44:25 -0400 Original-Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:45927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pilpX-000113-Sq for 62573@debbugs.gnu.org; Sat, 01 Apr 2023 20:44:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1680396257; bh=Tx6a9S6W+E0B8NnVMI2EXnhMg4qpThRIapt2kijfgqA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=g/5V+obxxeEPuVxiPf+EsIJD/lCBuT96yClFzGIXGrieMODep0kiBnkwFuuNmU8I9O60gcqxzN2N9o/bv0dpMpnwwCWZG/d9CwZeV7wPLQl6ThxUYO1n/W/MYnh4gMZCB0m3N0S+8C8Y/yV8vSnhJxRDZfuu1bvxmXb8HN2NCaqd8WpEcongiXcm+lLmwviSpMkBB0boWj3ofuCr4NtcplXTH8tMJLJWdx0qLkW05H6UmgGwTktjfcDoDAyRVuSpTOMHJaRnssoN7R5wjHh3HHSFNRIXQ/LeTGl8UTH+scCuJwebz+p9go9EZEh7qi192bx2hhOD3JzebfIPYtNDMg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1680396257; bh=YNLZ1hSc1DuXH9JynuDV3UHHLFab3aoVKmZGM7zBqIf=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jYwAT/tQsuWw+5KiB1RjfsrTNF5G8vIpbhLHIk2iCReRkTEZlkn9JmLtFcEJxuD55YtrpmBaUaJS0OI/LHtF5n8fq0IDZpxTpaMHcitOh68ZwsSV55LAJkQhPLTRZ98Xz8yydu/q8ANmh2EBPJAnpHzSgt2yhZNoNlsl9in+aAtx6aDrS78Lw+Cl1sIeilQnsAeS7G+iicmoWTG1S6AOYZrPsN/dIMNhfWE03lJKa/avsL5s5h4eAHhGoxAdqRBq2soD7jFTMdDnzJIGZZyNFgGeWgs2LSQFqlLT4z2uKUprXTZL8A/iFRUNHiAQS7BwwyYEUXU8OFgN4BF1GSqSfg== X-YMail-OSG: TxZITVkVM1m3YC6sgElpM4SDPSozGskxh4_FJjDcNUWurvDasUoFyEREyQFsKaQ pEJeeW6qphaxcZsaQRLr5arq1cbjShQMwrMsR25LAKAP70XNjLXaRY_BKUexq7.hi5oRMgYJ16TF i3__sy2ZOg_m1OGUIN0IZ5cQdv7pV865lTixfsHYvxxvpCwfkZYg7iL_IY4YbHWVhVsZcNhkU.i. PPwQCn3arflcimzXaya22rNVVGFpwAVUpjOirWc.qxElMsJpCBlffS1L8indN5yWGnHvPmnf0I8E nWT8WG8hX36FjrYnnpxXdoLswWFx_e5iWgDX9b4NI3Sfvv3Q8AwjIbWbWWhToFv50IIn27NrczW4 dfeA8nAmRpPwSBjA2CO6GbKTpjEor440x81geRMn50_HdccAKbWbt9kXs4M5FbCLBGtU3NUfPzMF 9nVqQ3wbfY.ZY5NKDHn3sSTKRfKV1_yKatxEOoZFt.1ooK6.z4hMEVAvwBKgsKYBtq2NOYjreJgc SkGM9ZORmjst38cytJmc2_IJIiN46.G8y0iYteEtxebSUeuA_YK9MYWLEif0P9GMIDCUCKMj.0.R qL0v0dX5uf.BDhMXVmq.gzFOJNIUfYBhFEO6q73uhjaCVFCZYJ3rTmeHgLZr0GN7J7minQU6la4q 5iR_IlQvTfWyC1EKSLVeMq8Z6qPQtmPug0qP7fnPVG1lNmFsEydWMFFUK0DOXKe11E4eOXjqaYCM rZNfTuSWITWhzWl3Fe.FNxPPWpSiuw8NZokxcAW6PWLmT8e.wcRxUO8nyNytJZJmFM0duCgh4g8o 5VCvkjOslQfKTvuyJZvbrY9py4f04wpltcb1gOf3MP X-Sonic-MF: X-Sonic-ID: 942022b6-6c28-45fc-b3fe-d5455b75a484 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sun, 2 Apr 2023 00:44:17 +0000 Original-Received: by hermes--production-sg3-6d6fb994f6-c7twq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 80af9d29171764568ac53e083e9e174f; Sun, 02 Apr 2023 00:44:13 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sat, 01 Apr 2023 21:56:33 +0200") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259080 Archived-At: Daniel Mart=C3=ADn writes: > I've solved the bug by replicating that logic in the appropriate places, > nsterm.m and macfont.m: Nice, thanks. > + CGColorRef colorref =3D get_cgcolor_from_nscolor (FRAME_CU= RSOR_COLOR (f), f); This row is now wider than 80 columns. Please wrap it. > struct face *face =3D s->face; > if (!face->stipple) > - { > - if (s->hl !=3D DRAW_CURSOR) > - [(NS_FACE_BACKGROUND (face) !=3D 0 > - ? [NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] > - : FRAME_BACKGROUND_COLOR (s->f)) set]; > - else > - [FRAME_CURSOR_COLOR (s->f) set]; > - } > + { > + if (s->hl !=3D DRAW_CURSOR) > + [(NS_FACE_BACKGROUND (face) !=3D 0 > + ? [NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (f= ace)] > + : FRAME_BACKGROUND_COLOR (s->f)) set]; > + else if (face && NS_FACE_BACKGROUND (face) > + =3D=3D [(NSColor*)FRAME_CURSOR_COLOR (s->f) unsig= nedLong]) > + [[NSColor colorWithUnsignedLong:NS_FACE_FOREGROUND (face= )] set]; > + else > + [FRAME_CURSOR_COLOR (s->f) set]; > + } > else > { > struct ns_display_info *dpyinfo =3D FRAME_DISPLAY_INFO (s-= >f); > Please write: (face && (NS_FACE_BACKGROUND (face) =3D=3D [(NSColor *) FRAME_CURSOR_COLOR (s->f) unsignedLong])) instead. > Could you give it a try on macOS and GNUstep? Thank you. Works for me, thanks. P.S. I think what needs to be done is to make the NS port keep track of glyph string colors through GCs, so that the relevant code can be easily synchronized with X.