From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#62444: [PATCH] erc: Fix "dcc get" flag parsing Date: Sat, 08 Apr 2023 15:53:23 -0700 Message-ID: <87mt3i56l8.fsf__17405.3245967784$1680994480$gmane$org@neverwas.me> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13267"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, 62444-done@debbugs.gnu.org To: Daniel Pettersson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 09 00:54:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plHS3-0003Ga-7F for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Apr 2023 00:54:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plHRc-0000p2-NX; Sat, 08 Apr 2023 18:54:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plHRb-0000oj-81 for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 18:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plHRa-0003kH-WC for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 18:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plHRa-0002Ds-IZ for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 18:54:02 -0400 Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 22:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62444 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 62444@debbugs.gnu.org, jp@neverwas.me, daniel@dpettersson.net Original-Received: via spool by 62444-done@debbugs.gnu.org id=D62444.16809944218507 (code D ref 62444); Sat, 08 Apr 2023 22:54:02 +0000 Original-Received: (at 62444-done) by debbugs.gnu.org; 8 Apr 2023 22:53:41 +0000 Original-Received: from localhost ([127.0.0.1]:59796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plHRE-0002D9-N5 for submit@debbugs.gnu.org; Sat, 08 Apr 2023 18:53:41 -0400 Original-Received: from mail-108-mta241.mxroute.com ([136.175.108.241]:37753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plHRC-0002Ct-S7 for 62444-done@debbugs.gnu.org; Sat, 08 Apr 2023 18:53:39 -0400 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta241.mxroute.com (ZoneMTA) with ESMTPSA id 187631316b1000edb4.001 for <62444-done@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 08 Apr 2023 22:53:28 +0000 X-Zone-Loop: 62030fb103e081dc7d7ef1ed59c2f65201114488681d X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZHoylFkAHm0302NGokBhruQ4iNu3/jByELhxodarjes=; b=muJ4kT204ewP6wm4VNxTOCIJ46 CmpHwh0NYT+WhGdVENcSIT8JxVDG4WbXOgR/F+AABNjp+W6w5h9HU71AuJyqddnQ2/cEpMEtl0lA+ tCeexi5SLhFCABurAQVIkvaxAxJYrYjHzMqQDrjzyGsxtmWBKAkX13yueeS1eoKnyw4rZKGz6fmdq OT1kz4CYXAs1XESbkWItEb1nQ5BP9umyEcQNcUCWJm7vqEISBGvGMdJ42EZfMzIjBeWeY2AUF0+hb LkGFFNYrQelRbh+rnT1rp3h3fi4apwtk6W10D59oxdl9+CJzaZNh/jt4wPCjZClyVDnMvwdvv2lCK jBnUmB6g==; In-Reply-To: (Daniel Pettersson's message of "Wed, 5 Apr 2023 20:27:33 +0200") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259499 Archived-At: Hi Daniel, Daniel Pettersson writes: > Hi J.P., > > Sorry for the delay for some reason the responses bounced my mailbox, > first and foremost I would like to thank you for your patience and > clarity in your response. Not at all, and you're welcome. >> Lastly, I have to mention the dreaded copyright thing because I couldn't >> tell from the discussion for bug#57905 whether you ended up filing. If >> not and we go with changes resembling those you've proposed, you'll >> probably want to do so. > > Attached my assignment. Thanks. (I would have taken your word for it). >> Alas, the following are just mechanical, style-related nits. Ignore them >> if you wish, but please see the attached patches for a reprise of your >> initial proposal with the changes I've outlined applied atop. (The first >> two patches are just thrown in for convenience but ultimately >> unrelated.) > > This is great, reminds me that I have some homework here; coding > standard, reading some more elisp in emacs packages and the bug > reporting. > > Sorry about that. No worries. I'm quite the serial offender myself. >> As mentioned, I've taken a slightly different tack WRT parsing based on >> the presence of pre-quoted args. Please check it out, give feedback, and >> by all means iterate. > > I don't have any feedback, looks great to me! Cool. I've added your changes to master and will probably backport the bug-fixing portion to 29.1 (or 29.2) once we figure out what to do with ERC's version number on the release branch. Thanks, and please consider contributing to ERC again in the future!