From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Tony Zorman via "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#60418: [PATCH] Add :vc keyword to use-package
Date: Mon, 17 Apr 2023 21:39:47 +0200
Message-ID: <87mt36uwl8.fsf@hyperspace>
References: <87zgb6uk2r.fsf@hyperspace>
 <handler.60418.B.167238381823776.ack@debbugs.gnu.org>
 <87tu0tl1s4.fsf@hyperspace> <87a5zt2emd.fsf@betli.tmit.bme.hu>
 <87fs9l9bim.fsf@posteo.net> <87y1n3zsro.fsf@posteo.net>
 <871qku220f.fsf@betli.tmit.bme.hu> <874jpq920b.fsf@posteo.net>
 <87cz4ezpwi.fsf@betli.tmit.bme.hu> <87h6tlinft.fsf@hyperspace>
 <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace>
 <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org>
Reply-To: Tony Zorman <soliditsallgood@mailbox.org>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="14893"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: philipk@posteo.net, felician.nemeth@gmail.com, 60418@debbugs.gnu.org,
 stefankangas@gmail.com
To: Eli Zaretskii <eliz@gnu.org>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 17 21:40:31 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1poUiF-0003h8-AX
	for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Apr 2023 21:40:31 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1poUhx-0005WU-JP; Mon, 17 Apr 2023 15:40:13 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1poUhn-0005VL-I5
 for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 15:40:05 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1poUhn-0004BL-8w
 for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 15:40:03 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1poUhm-0000GK-HF
 for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 15:40:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Tony Zorman <soliditsallgood@mailbox.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Mon, 17 Apr 2023 19:40:02 +0000
Resent-Message-ID: <handler.60418.B60418.1681760399995@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 60418
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.1681760399995
 (code B ref 60418); Mon, 17 Apr 2023 19:40:02 +0000
Original-Received: (at 60418) by debbugs.gnu.org; 17 Apr 2023 19:39:59 +0000
Original-Received: from localhost ([127.0.0.1]:56977 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1poUhj-0000Fz-Db
 for submit@debbugs.gnu.org; Mon, 17 Apr 2023 15:39:59 -0400
Original-Received: from mout-p-201.mailbox.org ([80.241.56.171]:59148)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <soliditsallgood@mailbox.org>) id 1poUhh-0000Fk-Qr
 for 60418@debbugs.gnu.org; Mon, 17 Apr 2023 15:39:58 -0400
Original-Received: from smtp1.mailbox.org (unknown [10.196.197.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4Q0cny3BqRz9sjK;
 Mon, 17 Apr 2023 21:39:50 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1681760390;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=7faocydV4fowUJqaKBeLrVdWbGf7xPRpRPO/q9EpOqU=;
 b=OcyiH4pEWkWIbqsSosVqLy/6E1FYT75CIiUlCxaOcnp6F4TpbfnIRGDZFjc9NUQ3r1ycCS
 ssN/wDZJSQwBqR2RuyGD96rHEe9OHD8lPq15XB69byNnyPV7jFBmhAEbwOHJca6CqkHZpj
 CRxITJR9uIy2MoGJE4YgDGJaA/i6FHTDahwgT0CO0S3xD8Kw9G9glU8T4zn8OyS5J8xG7j
 H5/t+6WrZuOMsp1lQRbtCbjQkLsYRfUw8kT5gK3zjeVKo9IZOryYJfUZwn9Dze8NpQoy1B
 /+b5rowbSYqS5ZHNpaNFIOnHRh7uPDd55sg+OtpuwdmdybHdKGUd4sfPWw7Xzg==
In-Reply-To: <835y9vbyfr.fsf@gnu.org>
X-MBO-RS-META: 1mwyuupr6mt83dotzkyetnx7hymomz4u
X-MBO-RS-ID: 477b2e197ab666d9341
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:260194
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/260194>

On Sun, Apr 16 2023 19:10, Eli Zaretskii wrote:
> Thanks, please see below a few minor comments.

Thanks for the comments! Sorry, I should have mirrored existing
conventions more closely (plus, proofreading; I reckon very few of the
"further"s would have survived even the first one). I do have one
question before preparing a new patch though.

>> +(defun use-package-handler/:vc (name _keyword arg rest state)
>> +  "Generate code for the :vc keyword."
>
> I don't think this is an accurate description of what the function
> does.  Also, we try very hard to mention at least the mandatory
> arguments in the first line of the doc strings.

I think I initially copied this from the handler for ":custom" (where
it's perhaps more applicable) and then forgot to change it. Still, I'm
not totally sure what to write here without assuming that the reader
already knows what the handler for a use-package keyword does (which is,
I guess, why none of the other handlers have much in the way of
documentation). Would it be a good idea to link to a relevant entry in
the info manual ((use-package) > Keyword extensions > Creating an
extension)?

Thanks again!

-- 
Tony Zorman | https://tony-zorman.com/