bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ]

[Michael Albinus <michael.albinus@gmx.de>]

Spencer Baugh <sbaugh@janestreet.com> writes:

Hi Spencer,

> Hmm, this change doesn't seem to fix my issue.  In fact, this change
> introduces a regression for me: I'm no longer able to use TRAMP ssh on
> my other machines which have color codes at the end of their prompt,
> which did work out of the box on Emacs 29!
>
> I'm guessing the reason is because this version of the regexp doesn't
> support multiple escape codes, or blanks in between/at the end of the
> escape codes?

Blanks as parts of escape codes are unlikely.

Multiple escape codes are not regarded indeed, my patch did expect that
there is not more as one escape code at the end of the shell prompt.

Your example is an indication of escape codes, mixed inside the shell
prompt. My first attempt (removing all escape codes from the buffer
region) did handle that. But as said, there were other regressions with
that attemot.

Hmm. Could you please send me a tramp-verbose 10 trace of your failing test?

Best regards, Michael.