From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Fri, 02 Jun 2023 01:30:45 +0200 Message-ID: <87mt1isqu2.fsf@web.de> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> <83edmwfz6p.fsf@gnu.org> <87r0qwk6bz.fsf@localhost> <83ttvseg3k.fsf@gnu.org> <87o7m0k1li.fsf@localhost> <87pm6g14hy.fsf@web.de> <87pm6f9zet.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:4/n8WdA/Nz82N/nVHbKsAOEUMBQ= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 02 01:32:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4rm8-00033q-LE for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Jun 2023 01:32:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4rlN-0001SB-32; Thu, 01 Jun 2023 19:31:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4rky-0001RC-8C for emacs-devel@gnu.org; Thu, 01 Jun 2023 19:31:02 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4rkt-0003RK-F7 for emacs-devel@gnu.org; Thu, 01 Jun 2023 19:30:59 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1q4rkr-0001Ye-Fr for emacs-devel@gnu.org; Fri, 02 Jun 2023 01:30:53 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306534 Archived-At: Ihor Radchenko writes: > Yes. And they selectively use some parts of isearch but not other. If a > third-party library is to re-bind `isearch-filter-predicate' what should > it expect about the environment? For now, it appears that even though > `isearch-mode-end-hook' is not always called, `isearch-clean-overlays' > does. But it may not be in future, for example. Potentially breaking the > working code. More accurate documentation would at least provide a guide > what to expect. Your case is special, though, since you need to hack _into_ an internal Isearch mechanism, your goal is the interoperation with isearch code. To me the appropriate solution is clearly: extend Isearch so that it can handle the invisible text property itself (or provide a clear interface that allows to implement that cleanly). Thos would be a better investment of time, more useful and maybe even not much harder than documenting all of those details. Michael.