From: Michael Albinus <michael.albinus@gmx.de>
To: Andrew Tropin <andrew@trop.in>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon
Date: Fri, 28 Jul 2023 09:24:58 +0200 [thread overview]
Message-ID: <87mszglcqd.fsf@gmx.de> (raw)
In-Reply-To: <87bkfwr4mg.fsf@trop.in> (Andrew Tropin's message of "Fri, 28 Jul 2023 09:23:35 +0400")
Andrew Tropin <andrew@trop.in> writes:
Hi Andrew,
>>>> Thanks. Eli, if you don't have further comments, I would push this to master.
>>>
>>> Please do, and thanks.
>>
>> Done as commit 42a911c61e67caa807750cd40887b729f09aaf52.
>
> Thank you!
You're welcome.
I've digged the documentation further, and it seems like we've overlooked,
that XDG icon names are possible already, via the :image-path argument:
(notifications-notify :title "I am playing music" :image-path "multimedia-player")
So the patch wasn't necessary. I'm a little bit undecided, whether we
shall revert it. Eli?
Best regards, Michael.
next prev parent reply other threads:[~2023-07-28 7:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 8:39 [PATCH] notifications: Don't expand-file-name app-icon Andrew Tropin
2023-07-24 8:39 ` [PATCH v2] notifications: Allow to use Icon Naming Specification for app-icon Andrew Tropin
2023-07-24 12:35 ` [PATCH] notifications: Don't expand-file-name app-icon Eli Zaretskii
2023-07-25 4:39 ` Andrew Tropin
2023-07-25 12:01 ` Eli Zaretskii
2023-07-25 12:59 ` Dmitry Gutov
2023-07-25 13:41 ` Andrew Tropin
2023-07-25 14:05 ` Eli Zaretskii
2023-07-25 16:48 ` Dmitry Gutov
2023-07-25 17:40 ` Eli Zaretskii
2023-07-25 19:09 ` Michael Albinus
2023-07-25 19:18 ` Eli Zaretskii
2023-07-26 7:05 ` Michael Albinus
2023-07-26 11:16 ` Eli Zaretskii
2023-07-26 12:36 ` Matthias Meulien
2023-07-26 13:14 ` Michael Albinus
2023-07-26 17:46 ` Matthias Meulien
2023-07-25 13:48 ` Eli Zaretskii
2023-07-25 10:43 ` Michael Albinus
2023-07-25 12:51 ` Eli Zaretskii
2023-07-25 13:51 ` Andrew Tropin
2023-07-25 14:47 ` Michael Albinus
2023-07-26 6:47 ` Andrew Tropin
2023-07-26 7:13 ` Michael Albinus
2023-07-26 12:05 ` Andrew Tropin
2023-07-26 11:59 ` [PATCH v3] notifications: Allow to use Icon Naming Specification for app-icon Andrew Tropin
2023-07-26 15:23 ` Eli Zaretskii
2023-07-26 17:46 ` Michael Albinus
2023-07-27 8:38 ` Andrew Tropin
2023-07-27 8:03 ` [PATCH v4] " Andrew Tropin
2023-07-27 11:49 ` Michael Albinus
2023-07-27 12:43 ` Eli Zaretskii
2023-07-27 14:59 ` Michael Albinus
2023-07-28 5:23 ` Andrew Tropin
2023-07-28 7:24 ` Michael Albinus [this message]
2023-07-28 11:07 ` Eli Zaretskii
2023-07-28 11:15 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mszglcqd.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=andrew@trop.in \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.