From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Sat, 02 Sep 2023 15:05:19 +0200 Message-ID: <87msy420a8.fsf@ledu-giraud.fr> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33819"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas , 64440@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 15:06:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcQKg-0008Yp-9r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 15:06:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcQK3-0000QR-GL; Sat, 02 Sep 2023 09:05:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcQK1-0000FB-PW for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:05:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcQK1-0003Ws-FJ for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:05:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcQKA-0006rJ-9P for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.169365993726332 (code B ref 64440); Sat, 02 Sep 2023 13:06:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 2 Sep 2023 13:05:37 +0000 Original-Received: from localhost ([127.0.0.1]:35428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcQJl-0006qd-CJ for submit@debbugs.gnu.org; Sat, 02 Sep 2023 09:05:37 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:2566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcQJh-0006qQ-I9 for 64440@debbugs.gnu.org; Sat, 02 Sep 2023 09:05:36 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=Zg8MFRsd 4hZFMItXNRl/ryLsG8/7iS9jGBqcxSOByJE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Z6/0Xvvz8zFeZCn3xbwvmT7FdH9oIu 8AgkG7b7K2DzQwvXexQ9BetOcNDCNQomUWbGNsCSI4YqN3ywXpQCMiDg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=Zg8MFRsd4hZFMItX NRl/ryLsG8/7iS9jGBqcxSOByJE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=0bwKxzFe1UwwwCG44C7PKevb6GxDZaPoiD2kib q1sTVT8WuvVV+w0FeQGstMA1kfCcerLhiAWSlWzBIpHLoWrGr+7z7Ihh2VN+4mxPMnmFZx P82uyX7OCh5IxW0TZrSic+1rYvLfLbCYPHRPwtMhELcQWfGCLJlkB//eCV6NzaH7Hmjt+t 6dpNcqDlbEh+GmvhHFDtALfhImct+uZgbfvvSZ9GAMoXO5GwCsBsOqSGZIof5DAPeOy6sx 8UufLBitZNKGhmi9aAnwNdmRwdJ7obSr4NeybVfO+OzWntEM5k9VqfBbUNiU5Ey3VOdBdb yHpC5l/BGHWE0+2A+AiND+nw== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 1b06b020 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 2 Sep 2023 15:05:20 +0200 (CEST) In-Reply-To: <87fs3xo13z.fsf@yahoo.com> (Po Lu's message of "Sat, 02 Sep 2023 08:44:16 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268994 Archived-At: Po Lu writes: > Stefan Kangas writes: > >>> Here is a new set of patches with two more on top of the previous ones >>> (ie. Number 1 and 2 should be the same as before). >>> >>> Number 3 sets the default mouse cursor to be an arrow on the default >>> menu bar area. Number 4 fixes a flickering I had while moving the mouse >>> pointer *into* a menu bar entry. >> >> Po Lu, do you have any comments on this patch series? >> >> Thanks in advance. > > Thanks. I don't understand why adjustments to note_tab_bar_highlight or > note_tool_bar_highlight are warranted, and I think this ought to be > optional. Ok, I'll look into those two adjustements. BTW, I was more hesitant about the global modification of 'window_from_coordinates' (even on machines I don't have access to). > ChangeLog entries are also absent from the commit messages. Noted. -- Manuel Giraud