From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Why shouldn't we have a #if .... #else .... #endif construct in Emacs Lisp? Date: Wed, 20 Sep 2023 12:59:32 +0000 Message-ID: <87msxh6lvv.fsf@localhost> References: <87cyyr7i2i.fsf@localhost> <87jzsypgqo.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34581"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, ulm@gentoo.org, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 20 14:59:23 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiwnZ-0008bN-6x for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Sep 2023 14:59:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiwmg-0008VS-8b; Wed, 20 Sep 2023 08:58:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiwme-0008Sj-Je for emacs-devel@gnu.org; Wed, 20 Sep 2023 08:58:24 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiwmc-0006WN-9b for emacs-devel@gnu.org; Wed, 20 Sep 2023 08:58:24 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D6192240103 for ; Wed, 20 Sep 2023 14:58:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695214699; bh=tNEC3ZmDtPma9aGGp3iy87fZ84ZeQGiYClN9xQfp3CU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=iyMR4UwNdMx9Squd5kqEB7l+zGtsnASUA2v9rt7Cb25u2xtWrDL8RyUceSrjs7RZ/ rhsQh5RNE/rppTSNTygpUUSIz5keXsGCXGN0NKfRfph43NLfHS/t3ji2z381E8SbBj nSRWgjL+mbI44YfoRwMWiQlypOOjCLcFnkpmAllMHAa8rjXRkPMti2enyxEA5n4EdS EDSHKYxrX/f9eHQOM6JTPchD+RT11SO59vRY1YUwDYXDrOmpfex2sQbe0u1W17mpsc DUbgqDrGG0/8kKliY2IPG9qCmIrP7EwhCaGGro65MMF/8hMnuUqopd7ENX3IO0dP8O J/KoJCS5jcOzQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RrJVf3QQ3z9rxL; Wed, 20 Sep 2023 14:58:17 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310835 Archived-At: Richard Stallman writes: > As I understand it, the proposal was to handle at compile time > certain conditionals at _top-level_ in the source file being compiled. > Things like > > (if (fboundp 'whatever) > ...conditional-code...) > > However, what you've shown is a conditional inside a function definition > that is part of org-mode -- right? You are right. Though we also have top-level instances of `fboundp' in Org that should not be optimized away during compile time. In particular, ol-w3m.el in Org has (when (and (boundp 'w3m-mode-map) (keymapp w3m-mode-map)) (define-key w3m-mode-map "\C-c\C-x\M-w" 'org-w3m-copy-for-org-mode) (define-key w3m-mode-map "\C-c\C-x\C-w" 'org-w3m-copy-for-org-mode)) w3m-mode-map is only available when w3m package is installed, which can happen after Org mode is compiled. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at