From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/hyperdrive b5294b4354 4/4: Tidy: Use zerop instead of = 0 Date: Fri, 13 Oct 2023 22:12:24 +0000 Message-ID: <87mswmqiif.fsf@posteo.net> References: <169722725606.27637.3820182151024041420@vcs2.savannah.gnu.org> <20231013200057.2C7FCC09BC9@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13074"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Joseph Turner To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 14 00:13:46 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrQPi-0003Bj-8s for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Oct 2023 00:13:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrQOb-0002Ms-0E; Fri, 13 Oct 2023 18:12:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrQOY-0002MO-FL for emacs-devel@gnu.org; Fri, 13 Oct 2023 18:12:34 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrQOW-0008BW-5X for emacs-devel@gnu.org; Fri, 13 Oct 2023 18:12:34 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D3F99240101 for ; Sat, 14 Oct 2023 00:12:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1697235146; bh=3e+WVXAJhnRYSkw5Rvmry84+LqPGCJYzOa3Y0v3N6go=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=npIwbLUAdcsBAMOBC58wnHvp584qOVxhyUZSOV+ZqJJWKV3kN8fUxv/m1cDlq6yuA lSxL0y92IEh0qcBk69/bGPqbwD0LUreXj8AG3hTqIUiUlBOOO62ImmbbpYv2T1q+kt lB9/8uudjv0JqY7HaVkdcoLnfx1lFC0WisVDkd1tEU0n20pGKDedstkypa58eTGRx1 /LnIo10WhZbhsiODi+X8+UUlFP8NDuvvC+30b2XO2/y3/uFoo7zrQuPSeuWmMYgOsi 9FpBlNhx2Ths7dpgNrAiUbhIAwpfxcqAKfLNgoege9KE2Bcxc1DxOQ04TXaYL6lMH3 CHcEjCsE8UnKg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4S6gjQ2SXxz6txP; Sat, 14 Oct 2023 00:12:26 +0200 (CEST) In-Reply-To: <20231013200057.2C7FCC09BC9@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Fri, 13 Oct 2023 16:00:57 -0400 (EDT)") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311435 Archived-At: FWIW this doesn't matter that much, you can check the disassembly to see what is going on after byte compilation: (disassemble (byte-compile (lambda (a) (= a 0)))) (disassemble (byte-compile (lambda (a) (zerop a)))) ELPA Syncer writes: > branch: elpa/hyperdrive > commit b5294b43547379e87435c294670f4a23ac0739b7 > Author: Joseph Turner > Commit: Joseph Turner > > Tidy: Use zerop instead of = 0 > --- > hyperdrive-lib.el | 2 +- > hyperdrive.el | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hyperdrive-lib.el b/hyperdrive-lib.el > index 1801fe0076..e2696160c9 100644 > --- a/hyperdrive-lib.el > +++ b/hyperdrive-lib.el > @@ -1033,7 +1033,7 @@ With universal prefix argument \\[universal-argument], prompt for entry." > With FORCE-PROMPT or when current hyperdrive does not match > PREDICATE, return a hyperdrive selected with completion. In this > case, when PREDICATE, only offer hyperdrives matching it." > - (when (= 0 (hash-table-count hyperdrive-hyperdrives)) > + (when (zerop (hash-table-count hyperdrive-hyperdrives)) > (hyperdrive-user-error "No known hyperdrives. Use `hyperdrive-new' to create a new one")) > (unless predicate > ;; cl-defun default value doesn't work when nil predicate value is passed in. > diff --git a/hyperdrive.el b/hyperdrive.el > index 824d33ba24..fcd2715b55 100644 > --- a/hyperdrive.el > +++ b/hyperdrive.el > @@ -827,7 +827,7 @@ The return value of this function is the retrieval buffer." > :help "Create a new hyperdrive"] > ("Drives" > :active (< 0 (hash-table-count hyperdrive-hyperdrives)) > - :label (if (= 0 (hash-table-count hyperdrive-hyperdrives)) > + :label (if (zerop (hash-table-count hyperdrive-hyperdrives)) > "Drives (empty)" > "Drives") > :filter (lambda (_)