From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Sat, 21 Oct 2023 20:48:34 +0800 Message-ID: <87mswc2lb1.fsf@yahoo.com> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87sf7kh1rg.fsf@ledu-giraud.fr> <87wmwv7hur.fsf@yahoo.com> <83edj3png3.fsf@gnu.org> <877cov7d7b.fsf@yahoo.com> <83bke7pm6m.fsf@gnu.org> <87y1hb5y0x.fsf@yahoo.com> <83a5trplax.fsf@gnu.org> <87pm2n5wyk.fsf@yahoo.com> <871qf22f5g.fsf@ledu-giraud.fr> <87wmvzkjaw.fsf@ledu-giraud.fr> <87wmvzc2qq.fsf@yahoo.com> <87sf6nn4km.fsf@ledu-giraud.fr> <87o7hbn3mo.fsf@ledu-giraud.fr> <87r0lo2s8a.fsf@ledu-giraud.fr> <874jik46cs.fsf@yahoo.com> <87mswc2q70.fsf@ledu-giraud.fr> <87zg0c2pua.fsf@yahoo.com> <87il702nfo.fsf@ledu-giraud.fr> <87v8b02mae.fsf@yahoo.com> <87a5sc2lh4.fsf@ledu-giraud.fr> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31214"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , stefankangas@gmail.com, 64440@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 21 14:49:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1quBQI-0007tC-20 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Oct 2023 14:49:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quBQ8-0001U4-49; Sat, 21 Oct 2023 08:49:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quBQ6-0001Tw-UA for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 08:49:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quBQ6-0006fJ-MC for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 08:49:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quBQY-0007VY-EG for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 08:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.169789256228790 (code B ref 64440); Sat, 21 Oct 2023 12:50:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 21 Oct 2023 12:49:22 +0000 Original-Received: from localhost ([127.0.0.1]:42525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quBPt-0007UH-Mx for submit@debbugs.gnu.org; Sat, 21 Oct 2023 08:49:21 -0400 Original-Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:35742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quBPs-0007Ti-0Q for 64440@debbugs.gnu.org; Sat, 21 Oct 2023 08:49:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697892526; bh=zy9kM7RiymaHyTppK/LNovILdRlZSrDYE+ddbJpjD4M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=XetVmfYwmNc8gqFkCx9tNmQ4fO+802v3xJo/i5i4CLPU+Z9LqhdLbHPH97JZi1RieuWZcTujpYWk8f/0frwI101dvNqwwv1i+7+71Bl39z3rm9LEasTIhONhwv7qL/VaNjcNvpkdwxMW5lewVGFdMoz1LmcXApiIZjiz6JSIb7DcBEL0uWvHTu0qIYhqHyhteYFeHmjJqhQgFbpbjDiwWJdAzI9jRK+oFe/lo25f77bi1XCunhTPIqAxBb/IJAz15K4Qt7bCP1CDvq3mrI9nj469iGZ8A/Cm1dydmqYRG8U/EzMsFlI63fsrIqB9gEqO461IlNk9Z5bFvL1004qLqg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697892526; bh=vNDQ4lD8ZEvnXKt+o2Z873S8zhwi3Q4NcYA7or7eJEo=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=pBdAgEFtai5iOVLk2L5P5wvhoulcFnTPjSlr1V5ooc6RW2xOqqy//JejfQ5Zzm2/RL+otRjd/Xp3BYO6X/jgHjTck1vX+vBqYSbRfKVJVt6lKTrTqdlxaOQ8p5mfv+DSkJNwxPpElc6ErLIyYqLl3yAQkavOxgWwPu5ztSSGBqXL/IsEZrVZPT8HpD3o4RupOfmBzM6Dj8kOUhSlCdkUXfh3xC5YcaXtub36TuQDfXxCFTcDFHfIIat9dWatqAkPGnlYShWWmrshbk4bfh0TY0DofianTq/Au11rOcs7KSkGUiz8R5YPQRjuN+6Pu0876AHOMEFnkOwZWO1FkgQ/aw== X-YMail-OSG: sstbYUEVM1n8kZs8qZc._091nOXA.wgUAYJ3nQ3mISQiCx4QoZ.cnn6FCp5vEAb 27G28cfelC0WSunidsdXakWp0vX2i9Fr5pwur7sNV2OLp5MHXVHGZdwiHwnlRs3SeuYU_xAIYWo6 zDem2PDLUldTmZFXYEwAAaTFFbtxcAMN0xTm1hyj_cOvwjLDFgCb.g892ua7FZdxkklAOilLYTdc dYtcrXOzZAQj3LoIKq19.qaJAVJ81nurXzU.gIhiNpkHmtf6EF6mSZf50rIZWsXq9AKXwM.V9VrP m496wPQjeRwBcjPpCIi3VPjw1Q.JjKUK0JPKMLYR.0WNt03pOYWgxQun1G9Ej5rFH8feq0PKZxL9 fd5qKxTTjvrMwCQy0HbgFdcxcViG8.COOyJNfaIh8hHkukVvGnphcrNjk.rHT.FcWYuCNJ_8hEbs op7hmrdynR0AEE9lJasMeDuuL4vMbDc4opG40fbHwuC98ov1o8dZpbDKzICh4TsfuEQvp0chftih J.83TaEgb4irYdnM6N3ggeOFOoZha5YTFiDKmbiX5sYCMvi4I8EY2cJhq1MBzcfHe0ybLYzCXYcy hK74wfMWwOEgLMUL3Vkm04V4aJCKHCCKYtzfMB5mJoG75rwB1_SM5_TKOBIUGRNo5Wrd3h5.MvDS zBxDNZZYqLLRlygjIDca4a7k6u2GOsk..976Q72SWT3NzMWRfvSAO2Pdj2LObBK1xNWB6_CXM3ar S8AaM9j16G_Y0p3FPehPmWAmyQOqJmHvIBuHVL.Bv8iyWbmKSuzU3jQQMg1sEEnGr3.GTM4Q_ufe FQ0etD162jwdTHlI7byn.kJ5kUdkEGIVeeBfdZY0so X-Sonic-MF: X-Sonic-ID: d39ffb4a-2185-4e1b-8910-9d8f90612c9f Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sat, 21 Oct 2023 12:48:46 +0000 Original-Received: by hermes--production-sg3-57f7997989-b8zls (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3212e2600617f73a8e05606b6740184a; Sat, 21 Oct 2023 12:48:41 +0000 (UTC) In-Reply-To: <87a5sc2lh4.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Sat, 21 Oct 2023 14:44:55 +0200") X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272890 Archived-At: Manuel Giraud writes: > Po Lu writes: > >> Manuel Giraud writes: >> >>> Alright. But in such case, I do not really know what to say: I am >>> adding one argument to all callers based on its siblings' values. >> >> In this (and only this) case, our practice is to omit functions modified >> solely to introduce the new argument from the log message, and to append >> to the entry designating the recipient of the new argument the words >> ``All callers changed.'' >> >> So long as the default value for the argument is straightforward, of >> course. If computing the argument demands non-trivial changes, then the >> ChangeLog should relate them as it would any other. > > What about this patch then? > > From 5047d98ecd209c514eec50b9c84a32bbddfa414f Mon Sep 17 00:00:00 2001 > From: Manuel Giraud > Date: Sat, 21 Oct 2023 14:36:24 +0200 > Subject: [PATCH] Support for menu bar in window_from_coordinates > > * src/window.c (window_from_coordinates): In the no toolkit build, add > support for the menu bar window. Add a new 'menu_bar_p' argument so > the function's signature has changed. All callers changed. Better, thanks. Although the commit message must be filled to 64 columns, and I'd rather callers passing true be enumerated there.