* bug#67976: java-ts-mode test failure
@ 2023-12-22 21:09 john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 5:28 ` Yuan Fu
0 siblings, 1 reply; 6+ messages in thread
From: john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-12-22 21:09 UTC (permalink / raw)
To: 67976
Bisect says the first bad commit is 9874561f39e
/home/build/emacs/src/emacs -batch -load .emacs -load /home/build/emacs/lisp/progmodes/java-ts-mode.el ert -load /home/build/emacs/test/lisp/progmodes/java-ts-mode-tests.el -eval '(ert-run-tests-batch-and-exit '\''(not (tag :unstable)))'
Running 2 tests (2023-12-22 19:05:47+0000, selector ‘(not (tag :unstable))’)
Test java-ts-mode-test-indentation backtrace:
signal(ert-test-failed (("Mismatch in test \"Statements\", file /hom
ert-fail(("Mismatch in test \"Statements\", file /home/build/emacs/t
ert-test--erts-test(((code lambda nil (setq indent-tabs-mode nil) (s
ert-test-erts-file("/home/build/emacs/test/lisp/progmodes/java-ts-mo
(closure (t) nil (let* ((fn-0 #'treesit-ready-p) (args-1 (condition-
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name java-ts-mode-test-indentation :docume
ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
command-line-1(("-load" ".emacs" "-load" "/home/build/emacs/lisp/pro
command-line()
normal-top-level()
Test java-ts-mode-test-indentation condition:
(ert-test-failed
("Mismatch in test \"Statements\", file /home/build/emacs/test/lisp/progmodes/java-ts-mode-resources/indent.erts"
#(
"if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n\11for (int i = 0; x < foos.size(); i++) {\n return;\n\11}\n } else {\n\11return;\n }\n"
0 159 (fontified nil))
"if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n for (int i = 0; x < foos.size(); i++) {\n return;\n }\n} else {\n return;\n}\n"))
FAILED 1/2 java-ts-mode-test-indentation (0.010839 sec) at emacs/test/lisp/progmodes/java-ts-mode-tests.el:26
passed 2/2 java-ts-mode-test-movement (0.004179 sec)
Ran 2 tests, 1 results as expected, 1 unexpected (2023-12-22 19:05:47+0000, 0.134714 sec)
1 unexpected results:
FAILED java-ts-mode-test-indentation
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#67976: java-ts-mode test failure
2023-12-22 21:09 bug#67976: java-ts-mode test failure john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-12-23 5:28 ` Yuan Fu
2023-12-28 8:02 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Yuan Fu @ 2023-12-23 5:28 UTC (permalink / raw)
To: john muhl; +Cc: Theodor Thornhill, 67976
> On Dec 22, 2023, at 1:09 PM, john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
>
> Bisect says the first bad commit is 9874561f39e
>
> /home/build/emacs/src/emacs -batch -load .emacs -load /home/build/emacs/lisp/progmodes/java-ts-mode.el ert -load /home/build/emacs/test/lisp/progmodes/java-ts-mode-tests.el -eval '(ert-run-tests-batch-and-exit '\''(not (tag :unstable)))'
> Running 2 tests (2023-12-22 19:05:47+0000, selector ‘(not (tag :unstable))’)
> Test java-ts-mode-test-indentation backtrace:
> signal(ert-test-failed (("Mismatch in test \"Statements\", file /hom
> ert-fail(("Mismatch in test \"Statements\", file /home/build/emacs/t
> ert-test--erts-test(((code lambda nil (setq indent-tabs-mode nil) (s
> ert-test-erts-file("/home/build/emacs/test/lisp/progmodes/java-ts-mo
> (closure (t) nil (let* ((fn-0 #'treesit-ready-p) (args-1 (condition-
> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> ert-run-test(#s(ert-test :name java-ts-mode-test-indentation :docume
> ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
> ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
> ert-run-tests-batch((not (tag :unstable)))
> ert-run-tests-batch-and-exit((not (tag :unstable)))
> eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
> command-line-1(("-load" ".emacs" "-load" "/home/build/emacs/lisp/pro
> command-line()
> normal-top-level()
> Test java-ts-mode-test-indentation condition:
> (ert-test-failed
> ("Mismatch in test \"Statements\", file /home/build/emacs/test/lisp/progmodes/java-ts-mode-resources/indent.erts"
> #(
> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n\11for (int i = 0; x < foos.size(); i++) {\n return;\n\11}\n } else {\n\11return;\n }\n"
> 0 159 (fontified nil))
> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n for (int i = 0; x < foos.size(); i++) {\n return;\n }\n} else {\n return;\n}\n"))
> FAILED 1/2 java-ts-mode-test-indentation (0.010839 sec) at emacs/test/lisp/progmodes/java-ts-mode-tests.el:26
> passed 2/2 java-ts-mode-test-movement (0.004179 sec)
>
> Ran 2 tests, 1 results as expected, 1 unexpected (2023-12-22 19:05:47+0000, 0.134714 sec)
>
> 1 unexpected results:
> FAILED java-ts-mode-test-indentation
>
CC’ing Theo here, since I don’t know java-ts-mode very well.
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#67976: java-ts-mode test failure
2023-12-23 5:28 ` Yuan Fu
@ 2023-12-28 8:02 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-28 9:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-12-28 8:02 UTC (permalink / raw)
To: Yuan Fu, john muhl; +Cc: 67976
Yuan Fu <casouri@gmail.com> writes:
>> On Dec 22, 2023, at 1:09 PM, john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
>>
>> Bisect says the first bad commit is 9874561f39e
>>
>> /home/build/emacs/src/emacs -batch -load .emacs -load /home/build/emacs/lisp/progmodes/java-ts-mode.el ert -load /home/build/emacs/test/lisp/progmodes/java-ts-mode-tests.el -eval '(ert-run-tests-batch-and-exit '\''(not (tag :unstable)))'
>> Running 2 tests (2023-12-22 19:05:47+0000, selector ‘(not (tag :unstable))’)
>> Test java-ts-mode-test-indentation backtrace:
>> signal(ert-test-failed (("Mismatch in test \"Statements\", file /hom
>> ert-fail(("Mismatch in test \"Statements\", file /home/build/emacs/t
>> ert-test--erts-test(((code lambda nil (setq indent-tabs-mode nil) (s
>> ert-test-erts-file("/home/build/emacs/test/lisp/progmodes/java-ts-mo
>> (closure (t) nil (let* ((fn-0 #'treesit-ready-p) (args-1 (condition-
>> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>> ert-run-test(#s(ert-test :name java-ts-mode-test-indentation :docume
>> ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
>> ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
>> ert-run-tests-batch((not (tag :unstable)))
>> ert-run-tests-batch-and-exit((not (tag :unstable)))
>> eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
>> command-line-1(("-load" ".emacs" "-load" "/home/build/emacs/lisp/pro
>> command-line()
>> normal-top-level()
>> Test java-ts-mode-test-indentation condition:
>> (ert-test-failed
>> ("Mismatch in test \"Statements\", file /home/build/emacs/test/lisp/progmodes/java-ts-mode-resources/indent.erts"
>> #(
>> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n\11for (int i = 0; x < foos.size(); i++) {\n return;\n\11}\n } else {\n\11return;\n }\n"
>> 0 159 (fontified nil))
>> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n for (int i = 0; x < foos.size(); i++) {\n return;\n }\n} else {\n return;\n}\n"))
>> FAILED 1/2 java-ts-mode-test-indentation (0.010839 sec) at emacs/test/lisp/progmodes/java-ts-mode-tests.el:26
>> passed 2/2 java-ts-mode-test-movement (0.004179 sec)
>>
>> Ran 2 tests, 1 results as expected, 1 unexpected (2023-12-22 19:05:47+0000, 0.134714 sec)
>>
Thanks, I'll look at it!
Theo
>> 1 unexpected results:
>> FAILED java-ts-mode-test-indentation
>>
>
> CC’ing Theo here, since I don’t know java-ts-mode very well.
>
> Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#67976: java-ts-mode test failure
2023-12-28 8:02 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-12-28 9:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-30 19:18 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-12-28 9:00 UTC (permalink / raw)
To: Yuan Fu; +Cc: john muhl, 67976
Theodor Thornhill <theo@thornhill.no> writes:
> Yuan Fu <casouri@gmail.com> writes:
>
>>> On Dec 22, 2023, at 1:09 PM, john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
[...]
>>> ("Mismatch in test \"Statements\", file /home/build/emacs/test/lisp/progmodes/java-ts-mode-resources/indent.erts"
>>> #(
>>> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n\11for (int i = 0; x < foos.size(); i++) {\n return;\n\11}\n } else {\n\11return;\n }\n"
>>> 0 159 (fontified nil))
>>> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n for (int i = 0; x < foos.size(); i++) {\n return;\n }\n} else {\n return;\n}\n"))
>>> FAILED 1/2 java-ts-mode-test-indentation (0.010839 sec) at emacs/test/lisp/progmodes/java-ts-mode-tests.el:26
>>> passed 2/2 java-ts-mode-test-movement (0.004179 sec)
>>>
>>> Ran 2 tests, 1 results as expected, 1 unexpected (2023-12-22 19:05:47+0000, 0.134714 sec)
>>>
>
> Thanks, I'll look at it!
>
> Theo
>
So I understand the bug now, and it seems you're right in that commit
being the offender. I'll see if I can rewrite the matchers to skip the
assumption that no longer works. It looks a little like a "rewrite" of
the indentation, though, so I need some time to do it correctly.
Theo
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#67976: java-ts-mode test failure
2023-12-28 9:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-12-30 19:18 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06 9:04 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-12-30 19:18 UTC (permalink / raw)
To: Theodor Thornhill; +Cc: Yuan Fu, 67976
Theodor Thornhill <theo@thornhill.no> writes:
> Theodor Thornhill <theo@thornhill.no> writes:
>
>> Yuan Fu <casouri@gmail.com> writes:
>>
>>>> On Dec 22, 2023, at 1:09 PM, john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
>
> [...]
>
>>>> ("Mismatch in test \"Statements\", file /home/build/emacs/test/lisp/progmodes/java-ts-mode-resources/indent.erts"
>>>> #(
>>>> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n\11for (int i = 0; x < foos.size(); i++) {\n return;\n\11}\n } else {\n\11return;\n }\n"
>>>> 0 159 (fontified nil))
>>>> "if (x) {\n for (var foo : foos) {\n \n }\n} else if (y) {\n for (int i = 0; x < foos.size(); i++) {\n return;\n }\n} else {\n return;\n}\n"))
>>>> FAILED 1/2 java-ts-mode-test-indentation (0.010839 sec) at emacs/test/lisp/progmodes/java-ts-mode-tests.el:26
>>>> passed 2/2 java-ts-mode-test-movement (0.004179 sec)
>>>>
>>>> Ran 2 tests, 1 results as expected, 1 unexpected (2023-12-22 19:05:47+0000, 0.134714 sec)
>>>>
>>
>> Thanks, I'll look at it!
>>
>> Theo
>>
>
> So I understand the bug now, and it seems you're right in that commit
> being the offender. I'll see if I can rewrite the matchers to skip the
> assumption that no longer works. It looks a little like a "rewrite" of
> the indentation, though, so I need some time to do it correctly.
>
> Theo
It looks like 9874561f39e got reverted so the tests pass again.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-06 9:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-22 21:09 bug#67976: java-ts-mode test failure john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 5:28 ` Yuan Fu
2023-12-28 8:02 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-28 9:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-30 19:18 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06 9:04 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.