all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Steven Allen <steven@stebalien.com>
Cc: 68761@debbugs.gnu.org
Subject: bug#68761: [PATCH] Record dependencies in packages installed via package-vc
Date: Tue, 06 Feb 2024 20:05:25 +0000	[thread overview]
Message-ID: <87mssdqry2.fsf@posteo.net> (raw)
In-Reply-To: <87il3eu4ow.fsf@stebalien.com> (Steven Allen's message of "Sat, 27 Jan 2024 08:22:23 -0800")

Steven Allen <steven@stebalien.com> writes:

> The dependency list wasn't getting recorded in the package's `-pkg.el` file.

Did you notice this because of some bug or what is the motivation for
this change?  I'll certainly look into it, I just wanted some context.

>>From edc9f75958d5feb2a82c53879e9dde4c51921bb6 Mon Sep 17 00:00:00 2001
> From: Steven Allen <steven@stebalien.com>
> Date: Sat, 27 Jan 2024 08:17:08 -0800
> Subject: [PATCH] Record dependencies in packages installed via package-vc
>
> * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Record a
> package's declared dependencies in the package's metadata ("-pkg.el").
> ---
>  lisp/emacs-lisp/package-vc.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index db0cc515e46..fc402716dab 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -532,6 +532,7 @@ package-vc--unpack-1
>                  (setq deps))))))
>        (dolist (dep deps)
>          (cl-callf version-to-list (cadr dep)))
> +      (setf (package-desc-reqs pkg-desc) deps)
>        (setf missing (package-vc-install-dependencies (delete-dups deps)))
>        (setf missing (delq (assq (package-desc-name pkg-desc)
>                                  missing)





  reply	other threads:[~2024-02-06 20:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-27 16:22 bug#68761: [PATCH] Record dependencies in packages installed via package-vc Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-06 20:05 ` Philip Kaludercic [this message]
2024-02-06 20:15   ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-07  7:18     ` Philip Kaludercic
2024-02-07 12:57       ` Eli Zaretskii
2024-02-07 17:07         ` Philip Kaludercic
2024-02-07 17:18           ` Eli Zaretskii
2024-02-07 18:42             ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 15:54               ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mssdqry2.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=68761@debbugs.gnu.org \
    --cc=steven@stebalien.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.