From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master babe6a5e948 1/2: Introduce a new TRAMP method `androidsu' Date: Sun, 03 Mar 2024 13:50:09 +0100 Message-ID: <87msrffpj2.fsf@gmx.de> References: <170892805989.23297.10872025500935567738@vcs2.savannah.gnu.org> <20240226061420.EF1D4C00231@vcs2.savannah.gnu.org> <875xybtxq0.fsf@gmx.de> <87a5nn61k7.fsf@yahoo.com> <87r0gzpopy.fsf@gmx.de> <875xyb5wct.fsf@yahoo.com> <87edcsptvh.fsf@gmx.de> <87sf182ep4.fsf@yahoo.com> <877cijhbxy.fsf@gmx.de> <87a5nf34ba.fsf@yahoo.com> <87r0grfr0t.fsf@gmx.de> <875xy3332q.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34247"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 03 13:51:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rglJ3-0008kg-Vt for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Mar 2024 13:51:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rglIG-0003eA-Vg; Sun, 03 Mar 2024 07:50:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rglIF-0003dz-0p for emacs-devel@gnu.org; Sun, 03 Mar 2024 07:50:15 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rglID-00007C-Cm for emacs-devel@gnu.org; Sun, 03 Mar 2024 07:50:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1709470209; x=1710075009; i=michael.albinus@gmx.de; bh=S5hSf9xROW/beHAkLAY97X5dYFvTtvu0RZ9p2vrVI08=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=HObnmDJ8ec7DnvvqHsrQkv8zNhTeVmkPHSDsRJeWY2ECbymJOPR52bQeqly6QKNd kTraDsFpz/Sd/8/ttKn5TEor9XQz0FA9VvwgsEpHGWVa8VFhRREXzcOXcKKuNAbic DhGb51Zn9oXCKBKArp55jkrIT7Pqg5x0LzxLZ8CZ8XNaXan1E3nSOzb+2LsGuGNSH 95gahChYtHmb8VDoabp8cNKrZXQje+H6Fsg16U5THdKfjnGU9XpDewuSgyL4qxBwZ lltSevtMcYxBRZToLk3IUKFeTDhvb0BEyGSy1dCjX1ExxyQIFeShJwE3KHvQRJwS5 W9wSrXsoPXGSLOWhmQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N1fis-1qjPS52gx6-011wuG; Sun, 03 Mar 2024 13:50:09 +0100 In-Reply-To: <875xy3332q.fsf@yahoo.com> (Po Lu's message of "Sun, 03 Mar 2024 20:35:57 +0800") X-Provags-ID: V03:K1:75z+060tI9aYe9TC6ZHsQN2P6VTpGJvlKw76JC/kJ00Eup78YqS PBPZgMsZHXn4FYlkjv6Q/qM0E6wTB5YT8OQDa3D2rsZzJQk8wiRcnXcybJkoOZD96ZuVJdQ hI/7RVETsSwppRisCtLobKTzAfYRA2eGTV/YGy57wBDg3jPQcmPjFJrZPWrLpAZUmIxpbmw bCx6dg34KHWslPf0t9/sw== UI-OutboundReport: notjunk:1;M01:P0:XurYvDj/sRw=;QJYDfDZ+/DzRTdyN76VATQ4gHXk Tua3dB+xn2k0ZwqmO8A/oXcjoknjZSrg2WTaakgSLIoKGm/ttmsHa4YHrAI8g1eQ+pYCeX2vP We50eN4cqF2nn3nuoPfOzl9gYCONewToXpx7JGNjBCopvS/7Fu2/f8mPRddaV/eKrCKIPMkuX mSkdE6xhOOku6BknMjVrHhymVRkDz76JCGorrzf1/Lq0N46kj8DLEvTddsrXAPRISOz05675W 6wetIyU7wMm/zTlrfZEMuKJccbgGwHTT7TFQ7xafYm71D3W/UUnd0P05FAKcbqAPAFg67hK8s WD0Tpuk+ogHE3DF4kqFvHotyMRF46DuFamHQiayc6KAqUZpIUfjktKbbjV/9scpPOZn8rxxbW ave3Cz8ZKADsZzK+9NelOck6duuIZefkxaa38bP48usczvlHwQ0vgk+M2i+4Gg7DI0mdWghGv isCrghG2ZuijdSzLZumlJCarklCIk9D8FDDrDyNO2c/QNflN+tuFzer6AunF/gIdflXa1TOh7 l3mnf+G9oTAZMQ6rfr928KZd01Q7zh6Fkv6481z+aQdET3jdJdjl4Pu3xJuAxYUYOTmWIAvxz 8JvlHuzK0VJ4bKxRp4xUT/ryBlWlmgAbQcEjbAz684g6Ym44Wr/KBMxLHzpbQcsaFH4AoWy8M zBTV7NHgWOgL4hXXW2h1vSvLqHuUnNARfcjWfoP9u9Gg4ZJ8eJJ0SS6QMmapLZKcHqzViQgma uuf8EuuimhV9QtHFuylJ0p5svN0rjonLp+sDiLZz/KVmD4CvfMkzgOnm1GYqmzPZNJePJ7zG Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316750 Archived-At: Po Lu writes: Hi, >> No. In multi-hop connections, every hop is checked via >> tramp-multi-hop-p. This includes tramp-sh-file-name-handler-p, which >> returns nil for the tramp-androidsu backend. > > That raises a different question: won't such a check disable multi-hop > connections involving the `su' method from being established to > non-Android hosts? Is it possible to detect whether VEC appertains to a > multi-hop connection early, in tramp-androidsh-file-name-handler-p > itself? Good question. So perhaps we must improve the check like (untested) (defsubst tramp-androidsu-file-name-p (vec-or-filename) "Check whether VEC-OR-FILENAME is for the `androidsu' method." (when-let* ((vec (tramp-ensure-dissected-file-name vec-or-filename))) (and (eq system-type 'android) (equal (tramp-file-name-method vec) tramp-androidsu-method) (null (tramp-file-name-hop vec))))) Best regards, Michael.