Re: master 91e02dde5fe: New tests for nested archives (bug#70987)

[Michael Albinus <michael.albinus@gmx.de>]

Eli Zaretskii <eliz@gnu.org> writes:

Hi,

>> From: Juri Linkov <juri@linkov.net>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
>> Date: Mon, 20 May 2024 20:00:55 +0300
>> 
>> >> It should succeed now that I installed the fix for bug#70987.
>> >
>> > Yep.
>> 
>> This is called Test-Driven Development ;-)
>
> Indeed.  TDD, here we come!

In order to keep the ball rolling: while tar-mode-tests succeed in my
local environment, they fail on emba:

<https://emba.gnu.org/emacs/emacs/-/jobs/85996#L904>

--8<---------------cut here---------------start------------->8---
uncompressing tg.tar.gz...
uncompressing tg.tar.gz...done
Parsing tar file... 
Parsing tar file...done
uncompressing gVv6Udu.gz...
uncompressing gVv6Udu.gz...done
   passed  1/3  tar-mode-test-tar-extract-gz (0.093691 sec)
uncompressing tzg.tar.gz...
uncompressing tzg.tar.gz...done
Parsing tar file... 
Parsing tar file...done
Parsing archive file...
Parsing archive file...done.
Searching for program: No such file or directory, unzip
Test tar-mode-test-tar-extract-zip-and-gz backtrace:
  signal(ert-test-failed (((should (equal (char-after) 10052)) :form (
  ert-fail(((should (equal (char-after) 10052)) :form (equal 103 10052
  (if (unwind-protect (setq value-22 (apply fn-20 args-21)) (setq form
  (let (form-description-24) (if (unwind-protect (setq value-22 (apply
  (let ((value-22 'ert-form-evaluation-aborted-23)) (let (form-descrip
  (let* ((fn-20 #'equal) (args-21 (condition-case err (list (char-afte
  (save-current-buffer (set-buffer (setq zip-buffer (tar-extract))) (s
  (save-current-buffer (set-buffer (setq tar-buffer (find-file-noselec
  (unwind-protect (save-current-buffer (set-buffer (setq tar-buffer (f
  (let* ((tar-file (expand-file-name "tzg.tar.gz" tar-mode-tests-data-
  #f(lambda () [t] (let* ((fn-15 #'executable-find) (args-16 (conditio
  #f(compiled-function () #<bytecode -0x1810b1c9d596429f>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x1810b1c9d596429
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name tar-mode-test-tar-extract-zip-and-gz 
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ... ...))
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test tar-mode-test-tar-extract-zip-and-gz condition:
    (ert-test-failed
     ((should (equal (char-after) 10052)) :form (equal 103 10052) :value
      nil :explanation
      (different-atoms (103 "#x67" "?g") (10052 "#x2744" "?❄"))))
   FAILED  2/3  tar-mode-test-tar-extract-zip-and-gz (0.049103 sec) at lisp/tar-mode-tests.el:49
   passed  3/3  tar-mode-test-tar-grind-file-mode (0.000273 sec)
Ran 3 tests, 2 results as expected, 1 unexpected (2024-05-27 09:08:03+0000, 0.358310 sec)
1 unexpected results:
   FAILED  tar-mode-test-tar-extract-zip-and-gz  ((should (equal (char-after) 10052)) :form (equal 103 10052) :value nil :explanation (different-atoms (103 "#x67" "?g") (10052 "#x2744" "?❄")))
--8<---------------cut here---------------end--------------->8---

Perhaps it needs a test whether executable unzip does exist?

Best regards, Michael.