From: Michael Heerdegen <michael_heerdegen@web.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Michael Heerdegen via "Emacs development discussions."
<emacs-devel@gnu.org>
Subject: Re: pcase generates an unprintable expansion for a form in test erc--restore-initialize-priors
Date: Wed, 29 May 2024 17:39:09 +0200 [thread overview]
Message-ID: <87mso84ogy.fsf@web.de> (raw)
In-Reply-To: <jwvsey3avw0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 27 May 2024 15:42:32 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > (pcase '(a . b)
> > (`(a . ,'b) t))
>
> The code I sent wasn't quite right, indeed. 🙂
> [ I didn't think of it as a failure of the test, but a failure of the
> code which (re)constructs the resulting quote pattern. ]
Anyway, apart from this little detail the patch is an obvious
improvement, so please go ahead. The occupied lisp eval depth shrinks
around 50% when the `pcase' pattern in the originally posted ert test is
compiled.
I must admit however - I still wonder: Code and matched structures will
be proper short-length lists most of the time - would it be possible and
make sense to handle all list elements at the same recursion level
instead of doing O(length) recursive descents?
Michael.
next prev parent reply other threads:[~2024-05-29 15:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 15:30 pcase generates an unprintable expansion for a form in test erc--restore-initialize-priors Alan Mackenzie
2024-05-26 21:19 ` Michael Heerdegen via Emacs development discussions.
2024-05-27 17:39 ` Stefan Monnier
2024-05-27 18:23 ` Stefan Monnier
2024-05-27 19:29 ` Michael Heerdegen via Emacs development discussions.
2024-05-27 19:42 ` Stefan Monnier
2024-05-29 15:39 ` Michael Heerdegen [this message]
2024-05-30 23:43 ` Stefan Monnier
2024-05-31 7:32 ` Andrea Corallo
2024-05-31 12:45 ` Stefan Monnier
2024-06-03 17:42 ` Stefan Monnier
2024-06-04 0:57 ` Michael Heerdegen
2024-05-27 20:14 ` F. Jason Park
2024-05-27 22:31 ` Stefan Monnier
2024-05-30 23:45 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mso84ogy.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.