bug#72193: 31.0.50; DocView on Postscript with SVG support

bug#72193: 31.0.50; DocView on Postscript with SVG support

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Hi,

DocView seems to do the wrong thing on a Postscript file when there is
support for SVG in Emacs.  I also have "gs" and "mutool" installed.

How to reproduce:
    - emacs -Q
    - C-x C-f "existing-document.ps"
    - C-c C-c -> no images displayed

Looking for pages into the cache with `doc-view-dired-cache', it seems
that DocView has produced PNG content into files with "svg" extension.
Emacs then tries to display SVG images with PNG content and, obviously,
failed.

The following patch fixes the issue for me but maybe there is more than
meets the eye:

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index f96b1bad886..e3539f8f886 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter
   (pcase-let ((`(,conv-function ,type ,extension)
                (pcase doc-view-doc-type
                  ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif"))
+                 ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png"))
                  (_ (if (and (eq doc-view-pdf->png-converter-function
                                  #'doc-view-pdf->png-converter-mupdf)
                              doc-view-mupdf-use-svg)



In GNU Emacs 31.0.50 (build 20, x86_64-unknown-openbsd7.5) of 2024-07-18
 built on computer
Repository revision: da97096fdbb50bf69348813c960eb8d10b2bdc44
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: OpenBSD computer 7.5 GENERIC.MP#191 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=no --without-cairo
 --without-compress-install'

Configured features:
DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF
LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS
TIFF TREE_SITTER WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ELisp/l

Minor modes in effect:
  bug-reference-prog-mode: t
  display-time-mode: t
  display-battery-mode: t
  desktop-save-mode: t
  exwm-randr-mode: t
  server-mode: t
  outline-minor-mode: t
  electric-pair-mode: t
  override-global-mode: t
  repeat-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/manuel/prog/elisp/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-randr
/home/manuel/prog/elisp/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm
/home/manuel/prog/elisp/exwm/exwm-xsettings hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xsettings
/home/manuel/prog/elisp/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xim
/home/manuel/prog/elisp/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-workspace
/home/manuel/prog/elisp/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-systemtray
/home/manuel/prog/elisp/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-manage
/home/manuel/prog/elisp/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-layout
/home/manuel/prog/elisp/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-input
/home/manuel/prog/elisp/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-floating
/home/manuel/prog/elisp/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-core
/home/manuel/prog/elisp/exwm/exwm-config hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-config
/home/manuel/prog/elisp/exwm/exwm-background hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-background
/home/manuel/.emacs.d/elpa/ef-themes-1.7.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/31.0.50/lisp/theme-loaddefs

Features:
(shadow descr-text dabbrev emacsbug smerge-mode diff whitespace edebug
debug backtrace vc-annotate shortdoc comp-common display-line-numbers
bookmark add-log vc-hg vc-bzr vc-src vc-sccs vc-svn cl-print doctor
help-fns radix-tree ps-mode ibuf-ext ibuffer ibuffer-loaddefs mule-util
shr-color mailalias smtpmail flow-fill sort gnus-cite mail-extr textsec
uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check
gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-cache qp utf-7
imap rfc2104 nndoc nndraft nnmh network-stream nnfolder nnml gnus-agent
gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss
pcmpl-gnu misearch multi-isearch tabify imenu man pcmpl-unix pulse
org-indent org-agenda texinfo texinfo-loaddefs bug-reference flymake-cc
flymake warnings python conf-mode oc-basic org-element org-persist
org-id org-element-ast inline avl-tree ol-eww ol-rmail ol-mhe ol-irc
ol-info ol-gnus nnselect ol-docview doc-view filenotify jka-compr
image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi
gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob
ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list
org-footnote org-faces org-entities org-version ob-emacs-lisp ob-core
ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc
org-loaddefs org-compat org-macs vc-dir ewoc vc on-screen eww url-queue
mm-url vc-git diff-mode track-changes vc-dispatcher vc-cvs vc-rcs
log-view pcvs-util make-mode view gnus-dired sh-script smie treesit
executable time battery cus-load desktop frameset exwm-randr xcb-randr
exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor
xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb
xcb-xproto xcb-types xcb-debug server ef-kassio-theme ef-themes
modus-operandi-theme modus-themes zone speed-type url-http url-auth
url-gw nsm ytdious mpdired transmission color calc-bin calc-ext calc
calc-loaddefs rect calc-macs supercite regi ebdb-gnus gnus-msg gnus-art
mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill
kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus
xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int
gnus-range gnus-win ebdb-message message sendmail yank-media puny rfc822
mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader
ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar
ezimage dframe find-func eieio-base timezone icalendar gnus nnheader
gnus-util mail-utils range mm-util mail-prsvr wid-edit web-mode derived
disp-table erlang-start skeleton cc-mode cc-fonts cc-guess cc-menus
cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep
slime-tramp tramp rx trampver tramp-integration files-x tramp-message
tramp-compat xdg shell pcomplete parse-time iso8601 time-date
format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent
cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu
slime-references slime-compiler-notes-tree advice slime-scratch
slime-presentations bridge slime-macrostep macrostep compat
slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl slime-parse slime apropos compile text-property-search etags
fileloop generator xref project arc-mode archive-mode noutline outline
pp comint ansi-osc ansi-color ring hyperspec thingatpt elec-pair edmacro
kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs
cal-menu calendar cal-loaddefs pcase dired-x dired-aux dired
dired-loaddefs use-package-core repeat easy-mmode calfw-autoloads
calfw-cal-autoloads calfw-org-autoloads debbugs-autoloads ebdb-autoloads
cl-extra help-mode ef-themes-autoloads exwm-autoloads
hyperbole-autoloads kotl-autoloads hact set hhist on-screen-autoloads
osm-autoloads rust-mode-autoloads info slime-autoloads
macrostep-autoloads speed-type-autoloads transmission-autoloads
xelb-autoloads ytdious-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs icons password-cache json
subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib
rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt
fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode
register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind kqueue lcms2 dynamic-setting system-font-setting
font-render-setting xinput2 x multi-tty move-toolbar
make-network-process emacs)

Memory information:
((conses 16 1235798 352745) (symbols 48 72425 28)
 (strings 32 345078 5656) (string-bytes 1 10173833)
 (vectors 16 185050) (vector-slots 8 2589583 99750)
 (floats 8 769 8358) (intervals 56 52756 11540) (buffers 992 186))

-- 
Manuel Giraud

bug#72193: 31.0.50; DocView on Postscript with SVG support

[Eli Zaretskii]

> Date: Fri, 19 Jul 2024 14:30:54 +0200
> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> DocView seems to do the wrong thing on a Postscript file when there is
> support for SVG in Emacs.  I also have "gs" and "mutool" installed.
> 
> How to reproduce:
>     - emacs -Q
>     - C-x C-f "existing-document.ps"
>     - C-c C-c -> no images displayed
> 
> Looking for pages into the cache with `doc-view-dired-cache', it seems
> that DocView has produced PNG content into files with "svg" extension.
> Emacs then tries to display SVG images with PNG content and, obviously,
> failed.
> 
> The following patch fixes the issue for me but maybe there is more than
> meets the eye:
> 
> diff --git a/lisp/doc-view.el b/lisp/doc-view.el
> index f96b1bad886..e3539f8f886 100644
> --- a/lisp/doc-view.el
> +++ b/lisp/doc-view.el
> @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter
>    (pcase-let ((`(,conv-function ,type ,extension)
>                 (pcase doc-view-doc-type
>                   ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif"))
> +                 ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png"))
>                   (_ (if (and (eq doc-view-pdf->png-converter-function
>                                   #'doc-view-pdf->png-converter-mupdf)
>                               doc-view-mupdf-use-svg)

Tassilo, any comments or suggestions?

bug#72193: 31.0.50; DocView on Postscript with SVG support

[Tassilo Horn]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Manuel & Eli,

>> Looking for pages into the cache with `doc-view-dired-cache', it
>> seems that DocView has produced PNG content into files with "svg"
>> extension.  Emacs then tries to display SVG images with PNG content
>> and, obviously, failed.
>> 
>> The following patch fixes the issue for me but maybe there is more than
>> meets the eye:
>> 
>> diff --git a/lisp/doc-view.el b/lisp/doc-view.el
>> index f96b1bad886..e3539f8f886 100644
>> --- a/lisp/doc-view.el
>> +++ b/lisp/doc-view.el
>> @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter
>>    (pcase-let ((`(,conv-function ,type ,extension)
>>                 (pcase doc-view-doc-type
>>                   ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif"))
>> +                 ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png"))
>>                   (_ (if (and (eq doc-view-pdf->png-converter-function
>>                                   #'doc-view-pdf->png-converter-mupdf)
>>                               doc-view-mupdf-use-svg)
>
> Tassilo, any comments or suggestions?

The patch is absolutely correct.  That's been an oversight, I think.
Thanks Manuel!

Bye,
  Tassilo

bug#72193: 31.0.50; DocView on Postscript with SVG support

[Eli Zaretskii]

> From: Tassilo Horn <tsdh@gnu.org>
> Cc: Manuel Giraud <manuel@ledu-giraud.fr>,  72193@debbugs.gnu.org
> Date: Sat, 20 Jul 2024 22:27:03 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> Hi Manuel & Eli,
> 
> >> Looking for pages into the cache with `doc-view-dired-cache', it
> >> seems that DocView has produced PNG content into files with "svg"
> >> extension.  Emacs then tries to display SVG images with PNG content
> >> and, obviously, failed.
> >> 
> >> The following patch fixes the issue for me but maybe there is more than
> >> meets the eye:
> >> 
> >> diff --git a/lisp/doc-view.el b/lisp/doc-view.el
> >> index f96b1bad886..e3539f8f886 100644
> >> --- a/lisp/doc-view.el
> >> +++ b/lisp/doc-view.el
> >> @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter
> >>    (pcase-let ((`(,conv-function ,type ,extension)
> >>                 (pcase doc-view-doc-type
> >>                   ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif"))
> >> +                 ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png"))
> >>                   (_ (if (and (eq doc-view-pdf->png-converter-function
> >>                                   #'doc-view-pdf->png-converter-mupdf)
> >>                               doc-view-mupdf-use-svg)
> >
> > Tassilo, any comments or suggestions?
> 
> The patch is absolutely correct.  That's been an oversight, I think.
> Thanks Manuel!

Thanks, now installed on the emacs-30 branch, and closing the bug.