From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72692: Emacs 31.05 (40eecd594ac) get SIGSEGV on Linux (Linux 6.6.45 Kde Wayland) Date: Mon, 26 Aug 2024 19:20:59 +0000 Message-ID: <87mskz146e.fsf@protonmail.com> References: <8b1c8e1f-e0b9-4049-888c-3f723e0008a9@gmail.com> <86wmkcwj9c.fsf@gnu.org> <867cc6nv7u.fsf@gnu.org> <87v7zq5jap.fsf@protonmail.com> <86v7zqmdo5.fsf@gnu.org> <86bk1gxz1z.fsf@mail.linkov.net> <86v7zojuqw.fsf@gnu.org> <87y14j25mg.fsf@protonmail.com> <86cylvjw5l.fsf@gnu.org> <87r0ab14ye.fsf@protonmail.com> Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4561"; mail-complaints-to="usenet@ciao.gmane.io" Cc: execvy@gmail.com, 72692@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 26 21:22:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sifIQ-00011t-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Aug 2024 21:22:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sifI5-0006KV-4g; Mon, 26 Aug 2024 15:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sifI2-0006KL-ST for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 15:22:11 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sifI2-0006Es-JR for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 15:22:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=o03WttJQW/60wtjbO2ptcixpWvLjgVm6D3pKdEzgmjA=; b=udnrljRD7g5jI5YbwS0GuqUJxyoLae0LerIlomcQFz7J64ATWm4RSw9DgXMcBC5BcQkNLm88QZzWtU1p2GBIov9qWd2KsRi5O+XJlyljy3we5kajtOuiwCRF75EttvPAZXSdfqbrrgJLW9xEXvymEpL4tK7wiBjeI2fBf+QFHMu6ePWcEH0bsux085dp4GEBD43Tsx+NIzXnMGZnRGLsmI4Ep6VnyapsakLjxOOsJUdtKnh6e+wtEsFD66f5Pc3yx4GFRnIk8lBB9e5uINWYhcLs2eatliTtLlzj+qZMxm19YaCso1ySwhhNS1dZFY4Clm9Os98sMZM8HeZDJADLhw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sifIr-0007D2-Lv for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 15:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2024 19:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72692 X-GNU-PR-Package: emacs Original-Received: via spool by 72692-submit@debbugs.gnu.org id=B72692.172470012327631 (code B ref 72692); Mon, 26 Aug 2024 19:23:01 +0000 Original-Received: (at 72692) by debbugs.gnu.org; 26 Aug 2024 19:22:03 +0000 Original-Received: from localhost ([127.0.0.1]:45232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sifHu-0007Ba-VG for submit@debbugs.gnu.org; Mon, 26 Aug 2024 15:22:03 -0400 Original-Received: from mail-4316.protonmail.ch ([185.70.43.16]:18721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sifHt-0007B4-19 for 72692@debbugs.gnu.org; Mon, 26 Aug 2024 15:22:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1724700063; x=1724959263; bh=o03WttJQW/60wtjbO2ptcixpWvLjgVm6D3pKdEzgmjA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=s6yS/+tv83YktvI91u9rf/vHaVgCIZgmvEt55qCNOPfbH5J1U6pO7ojSBKCnuGhjx O1YVs7y0quM669sAcS0Cn0iPbcyNEbDy5BzTosJUHMGXISpWbQw2A3WJ5l9lZUfTv5 mHnkPkn9i/jTFOdyPMvJNP/T2hGZd55yiZ777Xbby1ZFo/4+qQX/W6KfQGp/P8wbjh qVHLUtjbH/g0AFHNsZJ4zaureZ+SeuMZI8Q1X/+BteKydgD0PGB816613UeFuOsuHO m2OpccxJRLAv+n1u6zJXdufxe636VfbBw3WlwW/VtJoKd152SzyHDA/b8URV7Th0eL 5rTZ0bxuTLQ7A== In-Reply-To: <87r0ab14ye.fsf@protonmail.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: a81e673e6d0e60863b459a16e97d62ee16760724 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290790 Archived-At: "Pip Cet" writes: > "Eli Zaretskii" writes: > >>> Date: Mon, 26 Aug 2024 05:52:11 +0000 >>> From: Pip Cet >>> Cc: Juri Linkov , execvy@gmail.com, 72692@debbugs.gnu.= org >>> >>> >> - f->face_change =3D true; >>> > >>> > Sorry about that. I've now reverted that change; we will have to fin= d >>> > a cheaper solution for the original problem. >>> >>> This patch, moving down the setting of f->face_change to when we >>> definitely know it's required, seems to avoid the >>> always-in-the-foreground problem, but I'm not sure it fixes Juri's >>> performance issue: >> >> If all we want is to set the face_change flag without causing >> performance issues, then the patch below does it, and AFAIU should >> prevent the segfaults in this bug (please check, as I'm unable to >> trigger the segfaults): > > Will do. That was quick. With this patch: diff --git a/src/fontset.c b/src/fontset.c index 16d14669c89..41d845c9bc5 100644 --- a/src/fontset.c +++ b/src/fontset.c @@ -921,8 +921,6 @@ free_face_fontset (struct frame *f, struct face *face) eassert (! BASE_FONTSET_P (fontset)); eassert (f =3D=3D XFRAME (FONTSET_FRAME (fontset))); ASET (Vfontset_table, face->fontset, Qnil); - if (face->fontset < next_fontset_id) - next_fontset_id =3D face->fontset; if (! NILP (FONTSET_DEFAULT (fontset))) { int id =3D XFIXNUM (FONTSET_ID (FONTSET_DEFAULT (fontset))); @@ -931,8 +929,6 @@ free_face_fontset (struct frame *f, struct face *face) eassert (!NILP (fontset) && ! BASE_FONTSET_P (fontset)); eassert (f =3D=3D XFRAME (FONTSET_FRAME (fontset))); ASET (Vfontset_table, id, Qnil); - if (id < next_fontset_id) -=09next_fontset_id =3D face->fontset; } face->fontset =3D -1; } diff --git a/src/xfaces.c b/src/xfaces.c index 684b6ccfac7..02fc934ee4d 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -733,9 +733,12 @@ recompute_basic_faces (struct frame *f) { if (FRAME_FACE_CACHE (f)) { + bool was_empty =3D FRAME_FACE_CACHE (f)->used =3D=3D 0; clear_face_cache (false); if (!realize_basic_faces (f)) =09emacs_abort (); + if (!was_empty) +=09f->face_change =3D true; } } =20 and this hibiscus.el: (while t (insert (concat (make-string 1 (floor (random 132000))))) (set-frame-parameter nil 'alpha-background 1.0) (sit-for 1.0)) emacs -Q --load hibiscus.el works. Without the last hunk, it segfaults almost immediately. And the patch makes sense, too: if the face cache was empty, there's no need to set f->face_change to true. Is that case sufficiently common to result in acceptable performance? Pip