bug#74759: 30.0.92; Gnus configuration warning

bug#74759: 30.0.92; Gnus configuration warning

[Anush V]

Hello maintainers,

I tried executing the sample gnus configuration from [[info:gnus#Search
Engines][gnus#Search Engines]] in emacs with ~--no-init~ option, and I'm getting
a warning.  This code snippets works as expected, though.

Steps to reproduce:

emacs -Q
M-x ielm

executed this code

       (setopt gnus-select-method
       '(nnmaildir "My Mail"
               (directory "/home/user/.mail")
               (gnus-search-engine gnus-search-notmuch
                                   (config-file
       "/home/user/.mail/.notmuch_config"))))


I get this warning

  ■  Warning (emacs): Value ‘(nnmaildir "My Mail" (directory "/home/user/.mail") (gnus-search-engine gnus-search-notmuch (config-file "/home/user/.mail/.notmuch_config")))’ does not match type gnus-select-method


I’m wondering if this is a bug, or if Im doing something wrong.

Thank you for your time.

* * *

In GNU Emacs 30.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo
version 1.18.0)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: Guix System

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/3jhfhxdf6v5ms10x5zmnl166dh3yhbr1-bash-minimal-5.1.16/bin/bash
 SHELL=/gnu/store/3jhfhxdf6v5ms10x5zmnl166dh3yhbr1-bash-minimal-5.1.16/bin/bash --prefix=/gnu/store/dgpfiflaxb8j33jcbqk29wadcykajl51-emacs-next-30.0.92-0.881d593 --enable-fast-install --with-cairo --with-modules --with-native-compilation=aot --disable-build-details'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2
LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

--
Regards,
Anush V

bug#74759: 30.0.92; Gnus configuration warning

[Robert Pluim]

>>>>> On Mon, 09 Dec 2024 22:09:07 -0500, Anush V <j@gnu.org> said:

    Anush>        (setopt gnus-select-method
    Anush>        '(nnmaildir "My Mail"
    Anush>                (directory "/home/user/.mail")
    Anush>                (gnus-search-engine gnus-search-notmuch
    Anush>                                    (config-file
    Anush>        "/home/user/.mail/.notmuch_config"))))


    Anush> I get this warning

    Anush>   ■  Warning (emacs): Value ‘(nnmaildir "My Mail" (directory "/home/user/.mail") (gnus-search-engine gnus-search-notmuch (config-file "/home/user/.mail/.notmuch_config")))’ does not match type gnus-select-method


    Anush> I’m wondering if this is a bug, or if Im doing something wrong.

Itʼs an oversight in the definition of the custom type of
`gnus-select-method'. Iʼll see if I can come up with a fix.

Robert
-- 

bug#74759: 30.0.92; Gnus configuration warning

[Robert Pluim]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

>>>>> On Tue, 10 Dec 2024 12:58:17 +0100, Robert Pluim <rpluim@gmail.com> said:
    Robert> Itʼs an oversight in the definition of the custom type of
    Robert> `gnus-select-method'. Iʼll see if I can come up with a fix.

This works for me. Maintainers, master or emacs-30? (Iʼd lean towards
the latter)

Robert
-- 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-gnus-select-method-custom-type.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From d14a9c0d71e0e2240c97e449f4875577e7b44f73 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Tue, 10 Dec 2024 14:56:21 +0100
Subject: [PATCH] Fix 'gnus-select-method' custom type
To: emacs-devel@gnu.org

* lisp/gnus/gnus.el (gnus-redefine-select-method-widget): Cater
for the 'gnus-search-engine' configuration variable, which takes
2 args instead of 1.   (Bug#74759)
---
 lisp/gnus/gnus.el | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el
index 62a090bd9df..0d0e678309f 100644
--- a/lisp/gnus/gnus.el
+++ b/lisp/gnus/gnus.el
@@ -1402,9 +1402,14 @@ gnus-redefine-select-method-widget
 	    (string :tag "Address")
 	    (repeat :tag "Options"
 		    :inline t
-		    (list :format "%v"
-			  variable
-			  (sexp :tag "Value"))))))
+                    (radio
+		     (list :tag "Single var" :format "%v"
+			   variable
+			   (sexp :tag "Value"))
+                     (list :tag "Multiple var" :format "%v"
+			   variable
+                           variable
+			   (sexp :tag "Value")))))))
 
 (gnus-redefine-select-method-widget)
 
-- 
2.39.5

bug#74759: 30.0.92; Gnus configuration warning

[Eli Zaretskii]

> Cc: 74759@debbugs.gnu.org
> From: Robert Pluim <rpluim@gmail.com>
> Date: Tue, 10 Dec 2024 15:01:16 +0100
> 
> >>>>> On Tue, 10 Dec 2024 12:58:17 +0100, Robert Pluim <rpluim@gmail.com> said:
>     Robert> Itʼs an oversight in the definition of the custom type of
>     Robert> `gnus-select-method'. Iʼll see if I can come up with a fix.
> 
> This works for me. Maintainers, master or emacs-30? (Iʼd lean towards
> the latter)

Yes, emacs-30 is fine.

Thanks.

bug#74759: 30.0.92; Gnus configuration warning

[Robert Pluim]

tags 74759 fixed
close 74759 30.1
quit

>>>>> On Tue, 10 Dec 2024 16:42:46 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> Cc: 74759@debbugs.gnu.org
    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Tue, 10 Dec 2024 15:01:16 +0100
    >> 
    >> >>>>> On Tue, 10 Dec 2024 12:58:17 +0100, Robert Pluim <rpluim@gmail.com> said:
    Robert> Itʼs an oversight in the definition of the custom type of
    Robert> `gnus-select-method'. Iʼll see if I can come up with a fix.
    >> 
    >> This works for me. Maintainers, master or emacs-30? (Iʼd lean towards
    >> the latter)

    Eli> Yes, emacs-30 is fine.

OK

Closing.
Committed as fbcb357b9db

Robert
--