From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id AIsnB+LScmcS1wAA62LTzQ:P1 (envelope-from ) for ; Mon, 30 Dec 2024 17:05:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id AIsnB+LScmcS1wAA62LTzQ (envelope-from ) for ; Mon, 30 Dec 2024 18:05:38 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=N0yjlM14; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735578337; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=XwI39QZPiLEsMkjgKrZAlsfUOFSndrGHrYzEGZACC7A=; b=rH//utpomVwiIlyr7OWGdeLVCM0yZ99XjJjUYc6/5RdF95ApMHvNGgzTDnZUPnlyxOUg+j r/MZSkc2DrfR2XsOGl50kYflnCHDYgVmPkmo0YqsXrQ7/aI3bhfJQdcvvS79/o8m3ZHxbg pA20L+vL8iXb4bmGFAP/PAkEuJMLM+o0AKyvh68fKjSz88HeL45SoTrTESO+KQr1x3HhSC W4AizIwvXzTh0DwKkFWksDYlm6sDkfWHVYqrWtN9mwWEKO45IkBJtNSqBOb05GF5mMoEPD rBchomn4HpYe4NF3l0nOAM9z1netyYYQQWF4yCar3ExvbcQ/xLVDVgCHkFVV1g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=N0yjlM14; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735578337; a=rsa-sha256; cv=none; b=ZWaDiNResiycChRqyYtvozYPD2U3cK+uDLedGhSW14tmOYE91qZ38dLM9nB5P20ZxwVBQ9 V6t78CHS1uuwPd9xSQS4yHBcZYhEvPLFiPskoEyTIwOiHblXFNLes6DRc8K9CXhWfxSYCc CAVj1Bjb0YDlgn5OykdMqiDngCaIpypJKW86DkIZSg/7H188NUrzePVPWNDEATILKX6IFW AfsqW5wht6TYKMAXs3FSPrMoZroD7ivbJNkcfCDq2R3EPHfPAA9Sfw9iNudZKZ50cIEXKK SAFEOxSQjf3WLBrPV6zbHpc0OZGwpBbeYDsw0Jmg9D6biP0aEEYatRIZubzXJQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 974148BD4E for ; Mon, 30 Dec 2024 18:05:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSJCJ-0005Pb-Pg; Mon, 30 Dec 2024 12:04:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSJBy-0005Ja-JF for emacs-orgmode@gnu.org; Mon, 30 Dec 2024 12:04:38 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSJBw-0002oM-1y for emacs-orgmode@gnu.org; Mon, 30 Dec 2024 12:04:34 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 07A0C240027 for ; Mon, 30 Dec 2024 18:04:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735578270; bh=ArwQx/GAx5UMKgTFqij9+1SNSzYd3KUwLfjpvYV0+Mc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=N0yjlM14bHSYpH7bWpfqcnC7Qnbc1W3U/FdR1BYdFBhAdCE1PrcVeaFMP5ANXTnR9 uqCkY2ZU4lBj4yPUSDGze+o6vMCegg23bkY0yT81EfhcSrTjZMzj/rZTMVnhhqPs3P n8V/afc8YzrKi4v70Fyj5a+cTnrtxcoatNC5V1H1I8UT/rcBMPIJ+pS2jTJU2WV0FO xaKyOyCX3ciRbbz09qfURgf2v40YsYkBGq7O/ZmE7Nk2b1IVxFGV/NDQtqpavPuq4m Y3vf3QuXAAwVGXS33X/6D5VIVUW/wlv1WYpVC4T+ZZBxYiLG8ZYNYAFbSgjZFJIqaD VWBvBskrmqukg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YMMs925jzz6tvc; Mon, 30 Dec 2024 18:04:29 +0100 (CET) From: Ihor Radchenko To: =?utf-8?Q?Bj=C3=B6rn?= Bidar Cc: Karthik Chikmagalur , emacs-orgmode@gnu.org Subject: Re: Link preview generation with new link preview property In-Reply-To: <8734i68peo.fsf@> References: <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com> <874j382kue.fsf@gmail.com> <87pllug2y4.fsf@localhost> <87ldwfnff4.fsf@gmail.com> <874j328aym.fsf@localhost> <6764aa79.050a0220.23273b.09a5SMTPIN_ADDED_BROKEN@mx.google.com> <87y102mgdx.fsf@gmail.com> Date: Mon, 30 Dec 2024 17:05:59 +0000 Message-ID: <87msgd2j9k.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -6.18 X-Spam-Score: -6.18 X-Migadu-Queue-Id: 974148BD4E X-TUID: XwvE6rdRyZGj Bj=C3=B6rn Bidar writes: >> It looks like you are respecting the alignment specifications, set via >> org-image-align or the :align property of #+attr_*, but not the :width >> property. Is the idea that the preview implementation that provides the >> image should independently use org-display-inline-image--width? > > The width is set before the inline image is created. I'm not sure how > this should be handled. Is the with set when creating the inline image > Ihor? > If the width is set before the image is created how should it be handled > in > the preview image-data function? Both alignment and width are derived from LINK AST node. I am not sure what is the problem. AFAIU, Karthik is simply asking why you decided to calculate alignment from LINK, but not width. >> At minimum this requires making org-display-inline-image--width a public >> function. But it would be good for org-link-preview-image-data to >> respect both properties. > > I agree with both but I'm not sure what should be done on this. If we think about the API function to be more useful, we can derive alignment and width from LINK itself by default, but also provide optional parameters, so that the caller can override the values manually. If both alignment and width parameters are explicitly specified, LINK does not have to be provided. --=20 Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at