From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages Date: Mon, 06 Jan 2025 10:53:47 +0000 Message-ID: <87msg4kybo.fsf@gmail.com> References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> <861pxsul6k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29338"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: mail@thomasvoss.com, 73472-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 06 11:54:18 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUkkU-0007U1-52 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jan 2025 11:54:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUkkG-00089g-PN; Mon, 06 Jan 2025 05:54:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUkkE-000898-T5 for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 05:54:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUkkE-0004sY-JC for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 05:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=HkHzn3yQHCEdupz+1hngw++zpGNhg9KhoTWzWH7UGzk=; b=neSBT0P0BnZGYAUFwejBpS9PRmbq9FlZOTOoGLgsLgrQvJiNeg4jxe4DJwGrFBYB1iUyNTb1jHzLj0Qnxc5Nj617f+aERt0YMwdunc9Y+tDC1FF+qsj5pef2aGZtQSkfjudOLJooPUEmnHstbjrZrD+jrHc8DFRThNn1TwrQUJxdzbGQlJAzANqeuwXqJzpwUcT6jOmO254aIpAcxXtuQh3hruRHuyaLNFqElmgQV/uPIYyau85Cbl7gkwPsHzers5xAKuMBlMLAjXeQIAIs4as9Cas2mqEyH2w/p2mVKKL2Y404jGr7MiyAdH759LVWufm/mnqOOZq+GikrMPIMrA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUkkE-0004Tl-Dz for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 05:54:02 -0500 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2025 10:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 73472@debbugs.gnu.org, joaotavora@gmail.com, mail@thomasvoss.com Original-Received: via spool by 73472-done@debbugs.gnu.org id=D73472.173616083417198 (code D ref 73472); Mon, 06 Jan 2025 10:54:02 +0000 Original-Received: (at 73472-done) by debbugs.gnu.org; 6 Jan 2025 10:53:54 +0000 Original-Received: from localhost ([127.0.0.1]:36881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUkk6-0004TJ-69 for submit@debbugs.gnu.org; Mon, 06 Jan 2025 05:53:54 -0500 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:61761) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUkk3-0004T4-HF for 73472-done@debbugs.gnu.org; Mon, 06 Jan 2025 05:53:52 -0500 Original-Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4368a293339so109135905e9.3 for <73472-done@debbugs.gnu.org>; Mon, 06 Jan 2025 02:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736160824; x=1736765624; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HkHzn3yQHCEdupz+1hngw++zpGNhg9KhoTWzWH7UGzk=; b=Wh8Jx23+S2wbn7qhCe8aQnHyGAgPj6SENK4s2HuwC5I9iP4Bdzrm7+pqTVnvW9bk+x jZ84pAPojmF2RlzvJL2gUk1jp0ju2xfhWPtd8vSxXQVhW0jKrZ66lQgNDVVwLyQMp9ly JZeMGTmRrC9PdXZshmVcP01xTIyniV4PehE4T1ZKUVX9tQ6qIp/xzJvslwuIw7SOH1fz l+E7+k8AODw7vN4FRN7lCS2m+xPqyFMTqh6/EnaAcv2g7WJOZa1smA/0rIaG6N4Kj9dC GadNIg+wITwZo/mrb5rgyP6ZW8+NwJBXYJelVQhCFvoxkmqPR3agVUrfhDY45yOt8Ql9 LlGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736160824; x=1736765624; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HkHzn3yQHCEdupz+1hngw++zpGNhg9KhoTWzWH7UGzk=; b=BjkMErMwOj87x7eRwSgEJWP7mrtmh4FuSD/B+DvL3yg48qelX7SP1Fj6Z4D+Q3l8Ct 8Hyga9if2UphNae0hQR1cjrN11zxNXkjQ79fLBJnangVjBKUUzGc/QkNk4Xfl7XD1WqP ocN/PKT+65QlE6NERnnmkG2WHD4V1AtxxAKVSMPmWIYSalHoFCWMQz2/qNUaur8MVUah YK4GnWD/zRbTvR5ti7upFB6zjhMJKDRyK9+fvunC5i79QZ9ZKuWStmj4NGIfIhbR8mHY d0ntrJKUiWX8O6oVeaMWWmbz4Rh6MMa3STAGaBr8ydnSTNt21qvzAnN1LpFZV6flN2pv JXgA== X-Forwarded-Encrypted: i=1; AJvYcCUSyOomSCKyJqbI3GJaU1P427VEhZWbXfGF8wOiWHgq0nKPOavSZvh5G4jfcA7V/tHP8bb5kBshxZOT@debbugs.gnu.org X-Gm-Message-State: AOJu0YyDNhFsVZGgP4yLzTjpctvuv653GzS/E0OHhogY03Cv8FgTl+Em /vbSUN39K+c3sevRzkzqWkeApHkcibFOc9+cKx+kNTxzBhn8xM8qrURrwg== X-Gm-Gg: ASbGncs7ypi+gbFezpYQCyWbpDwi9iYHo1r4lvNAbYxUsh9boNK4SdpKq8gWClVTdnP 3r8h6HeNag11HSFHg8IVjYTDjnFc4iWGe5IVc/e0AY1FEsoald0nXNPUoV6wlLhFXemsLmQbXnJ IcXNJJmxdXu8Jhkp3ix0gsLBCUV4kQzE++uK+XOfMBoa2Wgudp45a+/OtQwKd+egaKsAwa2aGhh WfuIEkx7fCZuccgac/JzJx7l4mieigwdGytZDXIE6Jx97c= X-Google-Smtp-Source: AGHT+IEyT6I4YseHh9tjUve8tFhHFtR0CGLQoqi9+1zMxie+YfNvcMeAkOIEFY58IDuiLvFpG7v5aw== X-Received: by 2002:a05:6000:470a:b0:386:3825:2c3b with SMTP id ffacd0b85a97d-38a221eaa0bmr35605305f8f.18.1736160824375; Mon, 06 Jan 2025 02:53:44 -0800 (PST) Original-Received: from krug ([62.28.172.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828a8dsm47936134f8f.2.2025.01.06.02.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 02:53:43 -0800 (PST) In-Reply-To: <861pxsul6k.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Dec 2024 13:00:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298643 Archived-At: Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Date: Thu, 12 Dec 2024 10:57:48 +0000 >> Cc: Thomas Voss , 73472@debbugs.gnu.org >>=20 >> On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii wr= ote: >> > >> > > Date: Mon, 09 Dec 2024 19:01:28 +0100 >> > > From: "Thomas Voss" >> > > >> > > Apologies for the long delay; I have been super busy recently. >> > > >> > > > Ping! >> > > > >> > > > > Thanks. Jo=C3=A3o, any comments? >> > > > > >> > > > > My only comment is that the log message says "format-prompt", bu= t the >> > > > > code actually uses substitute-quotes. >> > > >> > > Uh=E2=80=A6 are we looking at the same patch? The log message in th= e patch I >> > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the p= laces where I used >> > > that function, and only says =E2=80=98format-prompt=E2=80=99 for the= place where I used >> > > that function (=E2=80=98eglot-rename=E2=80=99). >> > > >> > > Just in case, I attached the patch again to this email. >> > >> > Thanks. >> > >> > Jo=C3=A3o, are you okay with me installing this? >>=20 >> Just had a look. The patch won't break anything, but it has some problems >> around the part where substitute quotes isn't around a literal, but wraps >> a bigger block. I'll try to fix it. It would also be great to have som= e file >> local symbol-shortening mechanism to avoid that long name, but I'm >> not going to worry about that. > > Ping! Did you have time to look into this? Alright. I finally looked into Thomas' patch properly, and fixed the problems it had. I can produce that patch if anyone's interested. But looking at it, it's just way too verbose: the long 'substitute-quotes' sprinkled everywhere is hideos, shame we can't use shorthands or have a reader macro for that. So I opted to bring `substitute-quotes` into a new `eglot--format` helper and use it in eglot--error, eglot--warn, etc. Which is ugly in itself (I don't like my helpers to do this kind of stuff), but given the situation and my want to kill this bug, it'll do. Closing the bug. Jo=C3=A3o