From: Pranshu Sharma via "Emacs development discussions." <emacs-devel@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Treesitter injection support
Date: Tue, 07 Jan 2025 19:36:47 +1000 [thread overview]
Message-ID: <87msg3ge34.fsf@bauherren.ovh> (raw)
In-Reply-To: <847D011B-65B8-4A41-9010-20BD529CE627@gmail.com> (Yuan Fu's message of "Sat, 4 Jan 2025 11:23:55 -0800")
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
Yuan Fu <casouri@gmail.com> writes:
>>> Ok, so the problem is nested parsers. I don’t think the overlap
>>> would
>>> cause any problem. Right now treesit-range-settings can only give
>>> you
>>> one nested layer. I’ll need to make it support nesting a parser
>>> inside
>>> a local parser of the same language. I’ll work on that once I wrap
>>> up
>>> the thing I’m working on right now :-)
>>
>> Thanks, this definetly seems like the problem. Also the
>> treesit-range-settings seems kind of unstable, example when I
>> purposly
>> leave closed string before it, and close the string, it doesn't
>> reparse.
>
> Can you show me a concrete example (reproduce recipe)? I can look into
> it.
>
I attached a video that demostrated it. It also shows a second bug, in
which perfomance is exponentially bad because of
treesit-font-lock-settings.
I've attached all the relevent fiels, and note the long file with
horrible perfomance was
https://github.com/git/git/blob/master/gitweb/gitweb.perl.
[-- Attachment #2: Bug --]
[-- Type: video/x-matroska, Size: 1092164 bytes --]
[-- Attachment #3: perl-ts-mode.el --]
[-- Type: application/emacs-lisp, Size: 16705 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: test.pl --]
[-- Type: text/x-perl, Size: 2813 bytes --]
# Comment
use hello qw(he owq);
require few;
my $var = <<"BLAH";
Test thing this is string $vlah
BLAH
my $var = "thing";
my $newvar = 'thing' . $var;
# ew
($var, my @arr) = (1,2,3,4,5);
my $sarr = join '-', @arr;
my $teacher = Person->new;
# my @txt_files = <ProgramFiles/*.tx>;
$teacher->name('Foo');
print for qw[1 2 3 4];
$var =~ m#h(el)lo#;
$thign =~ /^eg([2-1])regex$/;
sub thing {
say for (1,2,3,4)
}
=head1 First level heading
Here's a line of code that won't execute:
print "How'd you see this!?\n";
say "hello" for (1,2,3);
=over 4
Hello
=item First item
=item Second item
=back
=cut
sub func {
$thing =~ s/edw/s/;
$thing =~ s/(([0-9]+),)+\+/ join ",", "hello" for @_ /e;
# ^^^^^^^^^^^^^^^^^^^^^^
# |
# Here watch how it loses it's colour
$thing =~ m/thing/;
$thing =~ y/thing/about/c;
}
my $thing = abs(/1/, 1);
if (1) {
2;
}
# $thing =~ s/(([0-9]+),)+/ "$_" for @_ /e;
my %hash = (
thing => 1 + 2,
other => 2,
blah => 2
);
my @ls = (
1, 3,
2, 3, 3
);
if (3) {
while (my ($a, $b) = each %hash) {
my $file = do {local $/ = undef;};
chomp;
abs 2;
sort @thing;
map { $_ + 1 } qw(1 2 43 4 );
unpack "thing";
return "string";
}
}
print "hello $we wow @thing, re";
$thing->whe;
class My::Example 1.234 {
field $x;
ADJUST {
$x = "Hello, world";
}
ADJUST {
$x = "Hello, world";
}
method print_message {
say $x;
}
sub thing {
"thing"
}
}
class New::Example 1.234 {
field $x;
ADJUST {
$x = "Hello, world";
}
ADJUST {
$x = "Hello, world";
}
method print_message {
say $x;
}
}
package PDate;
sub new {
my $class = shift;
my $self = { year => 0 + shift,
month => 0 + shift,
day => 0 + shift,
};
bless $self, $class;
return $self;
}
# $d1 is greater than $d2
sub cmp {
my ($d1, $d2) = @_;
for ($d1->{year} <=> $d2->{year},
$d1->{month} <=> $d2->{month},
$d1->{day} <=> $d2->{day}) {
return $_ unless $_ == 0
}
0
}
use overload '<=>' => \&cmp;
sub fmt {
my $self = shift;
my @months =
qw(January Febuary March April May June July August September November October December);
my $n = $self->{day};
if ($n == 1) { $n = '1st' }
elsif (($n - 2) % 10 == 0) { $n = "${n}nd" }
elsif (($n - 3) % 10 == 0) { $n = "${n}rd" }
else { $n = "${n}th" }
$months[$self->{month} - 1] . " $n, " . $self->{year}
}
sub short_fmt {
my $self = shift;
join "-", ($self->{year}, $self->{month}, $self->{day});
}
sub text_easy {
my $self = shift;
join "-", ($self->{year}, $self->{month}, $self->{day});
}
say %latest_commit = %{$commitlist[0]};
say Dumper %hello;
say $thing{hello};
[-- Attachment #5: Type: text/plain, Size: 47 bytes --]
--
Pranshu Sharma <https://p.bauherren.ovh>
prev parent reply other threads:[~2025-01-07 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 14:48 Treesitter injection support Pranshu Sharma via Emacs development discussions.
2025-01-04 8:21 ` Yuan Fu
2025-01-04 16:33 ` Pranshu Sharma via Emacs development discussions.
2025-01-04 19:23 ` Yuan Fu
2025-01-07 9:36 ` Pranshu Sharma via Emacs development discussions. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msg3ge34.fsf@bauherren.ovh \
--to=emacs-devel@gnu.org \
--cc=casouri@gmail.com \
--cc=pranshu@bauherren.ovh \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.