From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Yoichi NAKAYAMA Newsgroups: gmane.emacs.devel Subject: Re: patch: fix wrong-type-argument error in vc-registered Date: Wed, 13 Oct 2004 09:20:45 +0900 Organization: Geiin.org Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <87llebtqn6.wl%yoichi@geiin.org> References: <87pt3ohu06.wl%yoichi@geiin.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (generated by EMIKO 1.14.1 - "Choanoflagellata") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1097626877 8232 80.91.229.6 (13 Oct 2004 00:21:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 13 Oct 2004 00:21:17 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 13 02:21:07 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CHWt8-0002NQ-00 for ; Wed, 13 Oct 2004 02:21:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CHX09-0001wC-M5 for ged-emacs-devel@m.gmane.org; Tue, 12 Oct 2004 20:28:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CHX02-0001w5-PT for emacs-devel@gnu.org; Tue, 12 Oct 2004 20:28:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CHX02-0001vs-5P for emacs-devel@gnu.org; Tue, 12 Oct 2004 20:28:14 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CHX02-0001vp-20 for emacs-devel@gnu.org; Tue, 12 Oct 2004 20:28:14 -0400 Original-Received: from [80.91.229.2] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CHWsy-00034R-GL for emacs-devel@gnu.org; Tue, 12 Oct 2004 20:20:56 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CHWsx-0007Vg-00 for ; Wed, 13 Oct 2004 02:20:55 +0200 Original-Received: from 109.40.244.43.ap.yournet.ne.jp ([43.244.40.109]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Oct 2004 02:20:55 +0200 Original-Received: from yoichi by 109.40.244.43.ap.yournet.ne.jp with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Oct 2004 02:20:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 25 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 109.40.244.43.ap.yournet.ne.jp In-Reply-To: User-Agent: Wanderlust/2.11.32 (Wonderwall) EMIKO/1.14.1 (Choanoflagellata) FLIM/1.14.7 (=?ISO-2022-JP?B?GyRCOzA+chsoQg==?=) APEL/10.6 Emacs/21.3.50 (i686-pc-linux-gnu) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Face: wLZki+KbGjgKe0,<&3g*rA|R**vj[a8L%[v]ecJh1L(Uqm|LBx; v7Nq7n%?0d.aS]F#[~C\!{m?m,C&#U5}$_pZvBR>5VmX1Ol0`P\M-U8`sUF<5Quj'z&zzW8r|Zl9#W7Wut3duYzpKrP{n+AbarKtJ!i"Al7]P; -?[=iBZa*]r=>C':0~JECx]IH+RXq=/hUX}MB9e]oQKBxsDd/ X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28324 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28324 At Tue, 12 Oct 2004 12:14:39 -0400, Stefan Monnier wrote: > > > 2004-09-12 Stefan Monnier > > > * vc-hooks.el (vc-ignore-dir-regexp): New var. > > > overlooked that (file-name-directory file) may return nil. > > Following is the patch against it. > > Hmm... your patch looks fine, except that I don't understand why it's > needed: I thought vc-registered is only ever called with an absolute file > name, and (file-name-directory file) never returns nil if file is an > absolute file name. > > In which cases does it return nil on an absolute file name, or in which > cases is vc-registered called with a non-absolute file name? For example, mime-view.el in EMIKO module http://cvs.m17n.org/cgi-bin/viewcvs/semi/mime-view.el?rev=1.150.2.33.2.38&only_with_tag=emiko-1_14&content-type=text/vnd.viewcvs-markup calles set-auto-mode after setting buffer-file-name to non-absolute path for highlighting. -- Yoichi NAKAYAMA