all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marcelo Toledo <marcelo@marcelotoledo.org>
Subject: Re: syntax highlight fix for add-log.el
Date: Sun, 03 Apr 2005 19:47:54 -0300	[thread overview]
Message-ID: <87ll7zcw9x.fsf@kali.intranet> (raw)
In-Reply-To: E1DICVd-0001Ss-OY@fencepost.gnu.org

Richard Stallman <rms@gnu.org> writes:

> 	  ;; File names.
>     !     ("^\\(?: \\{8\\}\\|\t\\)\\* \\([^ ,:([\n]+\\)"
>
> This seems to insist on 8 spaces.
> It can be any number of spaces; one space is enough.

Modified to work with 1 or more spaces.

> 	    (log-edit-previous-comment arg)
>     !       (indent-region (point-min) (point-max) nil)
>
> This change looks like a no-op.  What is the bug you intend to fix?

I was looking old code and old documentation where column was no
optional, sorry. Just ignore it.

I've installed this patch:

Index: lisp/ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.7247
diff -u -r1.7247 ChangeLog
--- lisp/ChangeLog	3 Apr 2005 21:26:11 -0000	1.7247
+++ lisp/ChangeLog	3 Apr 2005 22:44:25 -0000
@@ -1,3 +1,11 @@
+2005-04-03  Marcelo Toledo  <marcelo@marcelotoledo.org>
+
+        * add-log.el (change-log-font-lock-keywords): The manual
+        describing a Change Log entry, says: (...) "Aside from these
+        header lines, every line in the change log starts with a space or
+        a tab.". The font-lock was not highlighting lines started with
+        spaces, added support for it.
+
 2005-04-03  Roland Winkler  <Roland.Winkler@physik.uni-erlangen.de>
 
 	* textmodes/bibtex.el (bibtex-url): Use format to generate the url.
Index: lisp/add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.156
diff -u -r1.156 add-log.el
--- lisp/add-log.el	21 Mar 2005 14:37:35 -0000	1.156
+++ lisp/add-log.el	3 Apr 2005 22:44:33 -0000
@@ -225,7 +225,7 @@
       (2 'change-log-email-face)))
     ;;
     ;; File names.
-    ("^\t\\* \\([^ ,:([\n]+\\)"
+    ("^\\(?: +\\|\t\\)\\* \\([^ ,:([\n]+\\)"
      (1 'change-log-file-face)
      ;; Possibly further names in a list:
      ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))

-- 
Marcelo Toledo
marcelo@marcelotoledo.org
http://www.marcelotoledo.org
Mobile: 55 71 9116-1101

  reply	other threads:[~2005-04-03 22:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-03  2:16 syntax highlight fix for add-log.el Marcelo Toledo
2005-04-03 21:19 ` Richard Stallman
2005-04-03 22:47   ` Marcelo Toledo [this message]
2005-04-04 10:45 ` Lute Kamstra
2005-04-04 15:51   ` Marcelo Toledo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ll7zcw9x.fsf@kali.intranet \
    --to=marcelo@marcelotoledo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.