all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Richard M. Stallman" <rms@gnu.org>,
	bug-cc-mode@gnu.org, emacs-devel@gnu.org
Subject: Re: Warnings in cc mode
Date: Tue, 15 Nov 2005 19:06:11 -0500	[thread overview]
Message-ID: <87lkzpiho0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <Pine.LNX.3.96.1051115102252.273C-100000@acm.acm> (Alan Mackenzie's message of "Tue, 15 Nov 2005 10:34:04 +0000 (GMT)")

> What is so bad about calling `make-variable-buffer-local' from a function
> rather than top level?  Or even, for that matter, calling it from an
> `eval-after-load' form?

make-variable-buffer-local changes the behavior of a variable globally and
for ever.  So it's a property of the variable and should only ever appear
right next to the corresponding defvar.

Many people incorrectly use make-variable-buffer-local where they meant
make-local-variable, and this warning catches this (that's the reason why
I added the warning).

Just like for all warnings, there are corner cases where the warning is
triggered in a situation where the code is actually really doing what it
intends to do.


        Stefan


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click


      parent reply	other threads:[~2005-11-16  0:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1EbOsE-0000q9-I3@fencepost.gnu.org>
2005-11-15 10:34 ` Warnings in cc mode Alan Mackenzie
2005-11-15 23:22   ` Richard M. Stallman
2005-11-16  0:06   ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lkzpiho0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bug-cc-mode@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.