Spurious new code in byte-opt.el?

Spurious new code in byte-opt.el?

[Juanma Barranquero]

The change below is part of:

2007-04-05  Chong Yidong  <cyd@stupidchicken.com>

        * emacs-lisp/byte-opt.el (byte-optimize-form-code-walker):
        Print entire form.

but it seems pointless.

             Juanma


Index: lisp/emacs-lisp/byte-opt.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/byte-opt.el,v
retrieving revision 1.88
retrieving revision 1.89
diff -u -2 -r1.88 -r1.89
--- lisp/emacs-lisp/byte-opt.el	21 Jan 2007 02:44:24 -0000	1.88
+++ lisp/emacs-lisp/byte-opt.el	5 Apr 2007 17:57:05 -0000	1.89
@@ -535,4 +535,5 @@
 		    ;; Detect the expansion of (pop foo).
 		    ;; There is no need to compile the call to `car' there.
+		    (progn (setq foo (list form fn)) nil)
 		    (and (eq fn 'car)
 			 (eq (car-safe (cadr form)) 'prog1)

Re: Spurious new code in byte-opt.el?

[Chong Yidong]

"Juanma Barranquero" <lekktu@gmail.com> writes:

> The change below is part of:
>
> 2007-04-05  Chong Yidong  <cyd@stupidchicken.com>
>
>        * emacs-lisp/byte-opt.el (byte-optimize-form-code-walker):
>        Print entire form.
>
> but it seems pointless.

Oops, sorry.  This was a careless mistake on my part.  I've removed it.

Re: Spurious new code in byte-opt.el?

[Miles Bader]

Chong Yidong <cyd@stupidchicken.com> writes:
> +		    (progn (setq foo (list form fn)) nil)
> Oops, sorry.  This was a careless mistake on my part.  I've removed it.

Now we know your debugging secrets.  :-)

-Miles

-- 
The automobile has not merely taken over the street, it has dissolved the
living tissue of the city.  Its appetite for space is absolutely insatiable;
moving and parked, it devours urban land, leaving the buildings as mere islands
of habitable space in a sea of dangerous and ugly traffic.
[James Marston Fitch, New York Times, 1 May 1960]