From: Sebastian Tennant <sebyte@smolny.plus.com>
To: help-gnu-emacs@gnu.org
Subject: Re: A macro and an unwanted containing list in the resulting form
Date: Thu, 24 May 2007 00:32:56 +0300 [thread overview]
Message-ID: <87lkff8buf.fsf@moley.org> (raw)
In-Reply-To: 87ejl7vj8a.fsf@thalassa.lan.informatimago.com
Quoth Pascal Bourguignon <pjb@informatimago.com>:
> So when you want to write s-exps, you can easily see what the result
> will be:
>
> (defmacro build-cond (alist)
> `(cond ,@(mapcar (lambda (each)
> `((equal my-var ,(car each)) ,(cdr each)))
> alist)))
Hmm, that's really good to know. It's certainly a lot more readable,
but I dread to think how this C-code must look (not that I'm a
C-coder), given that you have unquoted lists within a backquoted list
within an unspliced list within another backquoted list... It must be
a veritable spaghetti-junction, with a few chopped onions thrown in
for good measure!
> And never put a quote before a lambda expression!!! It works by
>chance in emacs lisp, but it prevents the compiler to compile the
>anonymous function, and it wouldn't work in other lisps.
Noted, although presumably you mean you shouldn't _directly_ quote a
lambda expression? In the above code, the lambda expression occurs
within an unspliced list, itself within a backquoted list... Ah, I
suppose this has the effect of the lambda expression not being quoted
at all?
> Also, it would be better if you hadn't magic variable names in your
> macro. Instead of using my-var, let the user of the macro decide what
> variable name should be tested. You could also use a better name
> than build-cond; for example, string-case. And let's improve a little
> the syntax, removing one layer of useless parentheses, getting the
> list of clauses from the &rest of the arguments:
>
> (defmacro string-case (var-name &rest alist)
> `(cond ,@(mapcar (lambda (each)
> `((equal ,var-name ,(car each)) ,(cdr each)))
> alist)))
>
> So now you can write:
>
> (string-case e
> ("hello" . (message "hi"))
> ("goodbye" . (message "bye")))
I understand your point, but I don't think it is necessary in this
case.
I'm writing a wrapper function to make-comint-in-buffer that also sets
up a simple process sentinel given the ("string" . FORM) alist. The
"string" is matched against the process event ("finished" or "killed",
for example) so the variable is always 'ev' (or whatever variable I
choose to hard-code in the process sentinel's lambda function).
> But if you write:
>
> (string-case (concat "hel" "lo")
> ("hello" . (message "hi"))
> ("goodbye" . (message "bye")))
>
> the expansion will evaluate several times (concat "hel" "lo"), which
> would be very bad when the expression has side effects. We need to
> take care of that in the macro, building a temporary and unique
> variable name with gensym, and binding it to the expression:
>
> (defmacro string-case (strexpr &rest alist)
> (let ((var-name (gensym)))
> `(let ((,var-name ,strexpr))
> (cond ,@(mapcar (lambda (each)
> `((equal ,var-name ,(car each)) ,(cdr each)))
> alist)))))
Hmm, I think I follow... just! Excuse me if I annotate what follows
for my benefit (and hopefully other's).
> And finally, it would be better if we could have several forms in each
> branches, and if we lost the dot:
"lost the dot" = "do without cons cells" -----+
|
+--------
|
\/
> (defmacro string-case (strexpr &rest alist)
> (let ((var-name (gensym)))
> `(let ((,var-name ,strexpr))
> (cond ,@(mapcar (lambda (each)
> `((equal ,var-name ,(car each)) ,@(cdr each)))
> alist))))) ^
|
I see. ----------------------------------------------------+--+
|
> (macroexpand '(string-case (aref my-strings (incf i)) |
> ("hello" (message "hi") (message "ho")) |
> ("goodbye" (message "bye")))) |
|
Unique variable name created by (gensym) ---+ |
| |
---------------------------------+ |
| |
\/ |
> (let ((G42298 (aref my-strings (incf i)))) |
> (cond |
> ((equal G42298 "hello") |
> (message "hi") (message "ho")) <--+---------------------+
> ((equal G42298 "goodbye") |
> (message "bye")))) |
|
"several forms in each branch" ----------+
Well Pascal, thank you for an excellent crash-course in macro
expansion!
I hope my annotations are correct, and not out of place, although
people not reading this in a fixed-with font will no doubt wonder what
on earth is going on, not to mention the other nasty things
line-wrapping news-manglers are inclined to do!
Sebastian
next prev parent reply other threads:[~2007-05-23 21:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1062.1179919591.32220.help-gnu-emacs@gnu.org>
2007-05-23 12:04 ` A macro and an unwanted containing list in the resulting form Pascal Bourguignon
2007-05-23 21:32 ` Sebastian Tennant [this message]
[not found] ` <mailman.1104.1179956594.32220.help-gnu-emacs@gnu.org>
2007-05-23 23:48 ` Pascal Bourguignon
2007-05-23 11:28 Sebastian Tennant
2007-05-23 11:39 ` Juanma Barranquero
2007-05-23 12:51 ` Sebastian Tennant
2007-05-23 13:14 ` Juanma Barranquero
2007-05-23 21:40 ` Sebastian Tennant
[not found] ` <mailman.1069.1179924576.32220.help-gnu-emacs@gnu.org>
2007-05-23 16:57 ` Pascal Bourguignon
2007-05-23 21:45 ` Sebastian Tennant
[not found] ` <mailman.1113.1179959874.32220.help-gnu-emacs@gnu.org>
2007-05-24 8:47 ` Tim X
2007-05-24 13:49 ` Sebastian Tennant
2007-05-24 16:12 ` Johan Bockgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lkff8buf.fsf@moley.org \
--to=sebyte@smolny.plus.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.