From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: doc-view support for bookmark.el Date: Tue, 25 Dec 2007 19:43:56 +0100 Message-ID: <87lk7i398z.fsf@member.fsf.org> References: <8763yn3v07.fsf@member.fsf.org> <477143E8.1090508@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198608254 26839 80.91.229.12 (25 Dec 2007 18:44:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2007 18:44:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 25 19:44:27 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J7ElN-0005U2-R7 for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 19:44:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7El2-00026j-TC for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 13:44:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J7Ekz-00026b-Ts for emacs-devel@gnu.org; Tue, 25 Dec 2007 13:44:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J7Ekx-00026J-Ha for emacs-devel@gnu.org; Tue, 25 Dec 2007 13:44:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7Ekx-00026G-Bn for emacs-devel@gnu.org; Tue, 25 Dec 2007 13:43:59 -0500 Original-Received: from out4.smtp.messagingengine.com ([66.111.4.28]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J7Ekx-0005Im-29 for emacs-devel@gnu.org; Tue, 25 Dec 2007 13:43:59 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id D079D80E5E; Tue, 25 Dec 2007 13:43:58 -0500 (EST) Original-Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 25 Dec 2007 13:43:58 -0500 X-Sasl-enc: B5W7XC1/TCCrT1Ig7KVI4SNxCZ3El3ezyHMaFyq62YKZ 1198608238 Original-Received: from baldur (dslb-084-063-018-200.pools.arcor-ip.net [84.63.18.200]) by mail.messagingengine.com (Postfix) with ESMTP id DFEA12821; Tue, 25 Dec 2007 13:43:57 -0500 (EST) Mail-Followup-To: martin rudalics , emacs-devel@gnu.org In-Reply-To: <477143E8.1090508@gmx.at> (martin rudalics's message of "Tue, 25 Dec 2007 18:54:48 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85451 Archived-At: martin rudalics writes: Hi Martin, >> When I was doing that I found some strange code: >> bookmark-jump-noselect opened the bookmarked file, set point at the >> correct position and returned a cons (BUFFER . POSITION). All >> calling functions did set the position once again. I suspect that >> was a relict of the past, so I removed it and now >> bookmark-jump-noselect only returns the buffer. > > (defun bookmark-jump-noselect (str) > ... > (save-excursion > ... > (cons (current-buffer) (point)))) > > The position might be in the same buffer where the excursion occurred, > hence this is needed. Ok, I get it. But it's at least a bit ugly and hard-wired to bookmarks that actually save the value of point. We should come up with a better way that allows bookmarking images, pdfs and everything else emacs can display. At least for those two examples there's no need to save the value of point. Bye, Tassilo