all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [user42@zip.com.au: compilation regexps for perl and weblint]
@ 2007-10-25  9:02 Richard Stallman
  2007-11-12  4:03 ` Vinicius Jose Latorre
  0 siblings, 1 reply; 12+ messages in thread
From: Richard Stallman @ 2007-10-25  9:02 UTC (permalink / raw)
  To: emacs-devel

Would someone please install these error patterns in the trunk,
if they are correct?  (I cannot tell if they are correct.)

We have papers from Kevin Ryde.

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
From: Kevin Ryde <user42@zip.com.au>
To: gnu-emacs-sources@gnu.org
Organization: Bah Humbug
Date: Thu, 25 Oct 2007 10:38:01 +1000
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Subject: compilation regexps for perl and weblint

- --=-=-=

As part of my ongoing effort to get stuff out of my .emacs, this is a
few compilation-mode regexps I've had bouncing around, for perl
podchecker and Test, and for weblint (the one written in perl).  Emacs
already matches perl's ordinary compile/run errors, but podchecker and
Test are a bit different.  What ought to be four lines is rather
severely bloated by coping with different versions of emacs, but you get
that.


- --=-=-=
Content-Type: application/emacs-lisp
Content-Disposition: attachment; filename=compilation-perl.el
Content-Transfer-Encoding: quoted-printable

;;; compilation-perl.el --- error regexps for perl podchecker and Test

;; Copyright 2007 Kevin Ryde

;; Author: Kevin Ryde <user42@zip.com.au>
;; Version: 1
;; Keywords: processes
;; URL: http://www.geocities.com/user42_kevin/compilation/index.html
;; EmacsWiki: PerlLanguage

;; compilation-perl.el is free software; you can redistribute it and/or
;; modify it under the terms of the GNU General Public License as published
;; by the Free Software Foundation; either version 3, or (at your option)
;; any later version.
;;
;; compilation-perl.el is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
;; Public License for more details.
;;
;; You can get a copy of the GNU General Public License online at
;; <http://www.gnu.org/licenses>.


;;; Commentary:

;; This is a spot of code adding `compilation-error-regexp-alist' patterns
;; for perl podchecker (the Pod::Checker module) and Test and Test::Harness
;; module error output.
;;
;; Emacs already has patterns for perl's normal compile and run errors, but
;; podchecker and Test are a bit different.

;;; Install:

;; Put compilation-perl.el somewhere in your `load-path', and in .emacs put
;;
;;     (eval-after-load "compile" '(require 'compilation-perl))
;;
;; There's an autoload cookie below for this, if you use
;; `update-file-autoloads' and friends.

;;; Emacsen:

;; Works in Emacs 22, Emacs 21, and XEmacs 21.

;;; History:

;; Version 1 - the first version.


;;; Code:

;;;###autoload (eval-after-load "compile" '(require 'compilation-perl))

(eval-after-load "compile"
  '(dolist
       (elem
        '(;; podchecker error messages, per Pod::Checker.
          ;; The style is from the Pod::Checker::poderror() function, eg.
          ;; *** ERROR: Spurious text after =3Dcut at line 193 in file foo.=
pm
          ;;
          ;; Plus end_pod() can give "at line EOF" instead of a number, so
          ;; for that match "on line N" which is the originating spot, eg.
          ;; *** ERROR: =3Dover on line 37 without closing =3Dback at line =
EOF in file bar.pm
          ;;
          ;; Plus command() can give both "on line N" and "at line N"; the
          ;; latter is desired and is matched because the .* is greedy.
          ;; *** ERROR: =3Dover on line 1 without closing =3Dback (at head1=
) at line 3 in file x.pod
          ;;
          (compilation-perl--Pod::Checker
           "^\\*\\*\\* \\(?:ERROR\\|\\(WARNING\\)\\).* \\(?:at\\|on\\) line=
 \\([0-9]+\\) \\(?:.* \\)?in file \\([^ \t\n]+\\)"
           3 2 nil (1))

          ;; perl Test module error messages.
          ;; Style per the ok() function "$context", eg.
          ;; # Failed test 1 in foo.t at line 6
          ;;
          (compilation-perl--Test
           "^# Failed test [0-9]+ in \\([^ \t\r\n]+\\) at line \\([0-9]+\\)"
           1 2)

          ;; perl Test::Harness output, eg.
          ;; NOK 1# Test 1 got: "1234" (t/foo.t at line 46)
          ;;
          ;; Test::Harness is slightly designed for tty output, since it
          ;; prints CRs to overwrite progress messages, but if you run it in
          ;; with M-x compile this pattern can at least step through the
          ;; failures.
          ;;
          (compilation-perl--Test::Harness
           "^.*NOK.* \\([^ \t\r\n]+\\) at line \\([0-9]+\\)"
           1 2)))

     (cond ((boundp 'compilation-error-regexp-systems-list)
            ;; xemacs21
            (setq elem (remove '(1) elem)) ;; drop "type" specifier
            (add-to-list 'compilation-error-regexp-alist-alist
                         (list (car elem) (cdr elem)))
            (compilation-build-compilation-error-regexp-alist))

           ((boundp 'compilation-error-regexp-alist-alist)
            ;; emacs22
            (add-to-list 'compilation-error-regexp-alist-alist elem)
            (add-to-list 'compilation-error-regexp-alist (car elem)))

           (t
            ;; emacs21
            (setq elem (remove '(1) elem)) ;; drop "type" specifier
            (add-to-list 'compilation-error-regexp-alist (cdr elem))))))

(provide 'compilation-perl)

;;; compilation-perl.el ends here

- --=-=-=
Content-Type: application/emacs-lisp
Content-Disposition: attachment; filename=compilation-weblint.el
Content-Transfer-Encoding: quoted-printable

;;; compilation-weblint.el --- error regexps for weblint

;; Copyright 2007 Kevin Ryde

;; Author: Kevin Ryde <user42@zip.com.au>
;; Version: 1
;; Keywords: processes
;; URL: http://www.geocities.com/user42_kevin/compilation/index.html
;; EmacsWiki: CompilationMode

;; compilation-weblint.el is free software; you can redistribute it and/or
;; modify it under the terms of the GNU General Public License as published
;; by the Free Software Foundation; either version 3, or (at your option)
;; any later version.
;;
;; compilation-weblint.el is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
;; Public License for more details.
;;
;; You can get a copy of the GNU General Public License online at
;; <http://www.gnu.org/licenses>.


;;; Commentary:

;; This is a spot of code adding a `compilation-error-regexp-alist' pattern
;; for messages from the weblint program (the one based on the perl
;; HTML::Lint modules).

;;; Install:

;; Put compilation-weblint.el somewhere in your `load-path', and in .emacs =
put
;;
;;     (eval-after-load "compile" '(require 'compilation-weblint))
;;
;; There's an autoload cookie below for this, if you use
;; `update-file-autoloads' and friends.

;;; Emacsen:

;; Works in Emacs 22, Emacs 21, and XEmacs 21.

;;; History:

;; Version 1 - the first version.


;;; Code:

;;;###autoload (eval-after-load "compile" '(require 'compilation-weblint))

(eval-after-load "compile"
  '(progn
     ;; The style comes from HTML::Lint::Error::as_string(), eg.
     ;; index.html (13:1) Unknown element <fdjsk>
     ;;
     ;; The pattern only matches filenames without spaces, since that should
     ;; be usual and should help reduce the chance of a false match of a
     ;; message from some unrelated program.
     ;;
     ;; This message style is quite close to the "ibm" entry of emacs22
     ;; `compilation-error-regexp-alist-alist' which is for IBM C, though
     ;; that ibm bit doesn't put a space after the filename.
     ;;
     (let ((elem '(compilation-weblint
                   "^\\([^ \t\r\n(]+\\) (\\([0-9]+\\):\\([0-9]+\\)) "
                   1 2 3)))

       (cond ((boundp 'compilation-error-regexp-systems-list)
              ;; xemacs21
              (add-to-list 'compilation-error-regexp-alist-alist
                           (list (car elem) (cdr elem)))
              (compilation-build-compilation-error-regexp-alist))

             ((boundp 'compilation-error-regexp-alist-alist)
              ;; emacs22
              (add-to-list 'compilation-error-regexp-alist-alist elem)
              (add-to-list 'compilation-error-regexp-alist (car elem)))

             (t
              ;; emacs21
              (add-to-list 'compilation-error-regexp-alist (cdr elem))

              ;; Remove the "4.3BSD lint pass 3" element because it wrongly
              ;; matches weblint messages.  It's apparently supposed to
              ;; match something like
              ;;
              ;;     bloofle defined( /users/wolfgang/foo.c(4) ) ...
              ;;
              ;; but it's rather loose and ends up matching the "(13:1)"
              ;; part from weblint as if "13" is the filename and "1" is the
              ;; line number.  Forcibly removing this is a bit nasty, but
              ;; emacs22 has dropped it, so consider it an upgrade!
              ;;
              ;; xemacs21 has the same pattern, but somehow the problem
              ;; doesn't arise, so leave it alone there, for now.
              ;;
              (setq compilation-error-regexp-alist
                    (remove '(".*([ \t]*\\([a-zA-Z]?:?[^:( \t\n]+\\)[:(][ \=
t]*\\([0-9]+\\))" 1 2)
                            compilation-error-regexp-alist)))))))

(provide 'compilation-weblint)

;;; compilation-weblint.el ends here

- --=-=-=


- -- 
"But I don't work Sundays or me day off."

- --=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
gnu-emacs-sources mailing list
gnu-emacs-sources@gnu.org
http://lists.gnu.org/mailman/listinfo/gnu-emacs-sources

- --=-=-=--
------- End of forwarded message -------

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12  4:03 ` Vinicius Jose Latorre
@ 2007-11-12  4:01   ` Dan Nicolaescu
  2007-11-12 17:18     ` Richard Stallman
  2007-11-12 17:48     ` Vinicius Jose Latorre
  0 siblings, 2 replies; 12+ messages in thread
From: Dan Nicolaescu @ 2007-11-12  4:01 UTC (permalink / raw)
  To: Vinicius Jose Latorre; +Cc: rms, emacs-devel

Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:

  > Richard Stallman wrote:
  > > Would someone please install these error patterns in the trunk,
  > > if they are correct?  (I cannot tell if they are correct.)
  > >
  > > We have papers from Kevin Ryde.
  > >   
  > 
  > Installed in the trunk.

Both new files do something like: 

;;;###autoload (eval-after-load "compile" '(require 'compilation-perl))

the goal is just to add some patterns to
compilation-error-regexp-alist*. 

Isn't this ugly? 

For an outside package this is OK. But IMHO when including this stuff
in emacs it might be a better idea to just add the patterns to
compile.el and be done with it.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-10-25  9:02 [user42@zip.com.au: compilation regexps for perl and weblint] Richard Stallman
@ 2007-11-12  4:03 ` Vinicius Jose Latorre
  2007-11-12  4:01   ` Dan Nicolaescu
  0 siblings, 1 reply; 12+ messages in thread
From: Vinicius Jose Latorre @ 2007-11-12  4:03 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel

Richard Stallman wrote:
> Would someone please install these error patterns in the trunk,
> if they are correct?  (I cannot tell if they are correct.)
>
> We have papers from Kevin Ryde.
>   

Installed in the trunk.

> ------- Start of forwarded message -------
> X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
> 	autolearn=failed version=3.1.0
> From: Kevin Ryde <user42@zip.com.au>
> To: gnu-emacs-sources@gnu.org
> Organization: Bah Humbug
> Date: Thu, 25 Oct 2007 10:38:01 +1000
> MIME-Version: 1.0
> Content-Type: multipart/mixed; boundary="=-=-="
> Subject: compilation regexps for perl and weblint
>
> - --=-=-=
>
> As part of my ongoing effort to get stuff out of my .emacs, this is a
> few compilation-mode regexps I've had bouncing around, for perl
> podchecker and Test, and for weblint (the one written in perl).  Emacs
> already matches perl's ordinary compile/run errors, but podchecker and
> Test are a bit different.  What ought to be four lines is rather
> severely bloated by coping with different versions of emacs, but you get
> that.
>
>
> - --=-=-=
> Content-Type: application/emacs-lisp
> Content-Disposition: attachment; filename=compilation-perl.el
> Content-Transfer-Encoding: quoted-printable
>
> ;;; compilation-perl.el --- error regexps for perl podchecker and Test
>
> ;; Copyright 2007 Kevin Ryde
>
> ;; Author: Kevin Ryde <user42@zip.com.au>
> ;; Version: 1
> ;; Keywords: processes
> ;; URL: http://www.geocities.com/user42_kevin/compilation/index.html
> ;; EmacsWiki: PerlLanguage
>
> ;; compilation-perl.el is free software; you can redistribute it and/or
> ;; modify it under the terms of the GNU General Public License as published
> ;; by the Free Software Foundation; either version 3, or (at your option)
> ;; any later version.
> ;;
> ;; compilation-perl.el is distributed in the hope that it will be useful,
> ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
> ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
> ;; Public License for more details.
> ;;
> ;; You can get a copy of the GNU General Public License online at
> ;; <http://www.gnu.org/licenses>.
>
>
> ;;; Commentary:
>
> ;; This is a spot of code adding `compilation-error-regexp-alist' patterns
> ;; for perl podchecker (the Pod::Checker module) and Test and Test::Harness
> ;; module error output.
> ;;
> ;; Emacs already has patterns for perl's normal compile and run errors, but
> ;; podchecker and Test are a bit different.
>
> ;;; Install:
>
> ;; Put compilation-perl.el somewhere in your `load-path', and in .emacs put
> ;;
> ;;     (eval-after-load "compile" '(require 'compilation-perl))
> ;;
> ;; There's an autoload cookie below for this, if you use
> ;; `update-file-autoloads' and friends.
>
> ;;; Emacsen:
>
> ;; Works in Emacs 22, Emacs 21, and XEmacs 21.
>
> ;;; History:
>
> ;; Version 1 - the first version.
>
>
> ;;; Code:
>
> ;;;###autoload (eval-after-load "compile" '(require 'compilation-perl))
>
> (eval-after-load "compile"
>   '(dolist
>        (elem
>         '(;; podchecker error messages, per Pod::Checker.
>           ;; The style is from the Pod::Checker::poderror() function, eg.
>           ;; *** ERROR: Spurious text after =3Dcut at line 193 in file foo.=
> pm
>           ;;
>           ;; Plus end_pod() can give "at line EOF" instead of a number, so
>           ;; for that match "on line N" which is the originating spot, eg.
>           ;; *** ERROR: =3Dover on line 37 without closing =3Dback at line =
> EOF in file bar.pm
>           ;;
>           ;; Plus command() can give both "on line N" and "at line N"; the
>           ;; latter is desired and is matched because the .* is greedy.
>           ;; *** ERROR: =3Dover on line 1 without closing =3Dback (at head1=
> ) at line 3 in file x.pod
>           ;;
>           (compilation-perl--Pod::Checker
>            "^\\*\\*\\* \\(?:ERROR\\|\\(WARNING\\)\\).* \\(?:at\\|on\\) line=
>  \\([0-9]+\\) \\(?:.* \\)?in file \\([^ \t\n]+\\)"
>            3 2 nil (1))
>
>           ;; perl Test module error messages.
>           ;; Style per the ok() function "$context", eg.
>           ;; # Failed test 1 in foo.t at line 6
>           ;;
>           (compilation-perl--Test
>            "^# Failed test [0-9]+ in \\([^ \t\r\n]+\\) at line \\([0-9]+\\)"
>            1 2)
>
>           ;; perl Test::Harness output, eg.
>           ;; NOK 1# Test 1 got: "1234" (t/foo.t at line 46)
>           ;;
>           ;; Test::Harness is slightly designed for tty output, since it
>           ;; prints CRs to overwrite progress messages, but if you run it in
>           ;; with M-x compile this pattern can at least step through the
>           ;; failures.
>           ;;
>           (compilation-perl--Test::Harness
>            "^.*NOK.* \\([^ \t\r\n]+\\) at line \\([0-9]+\\)"
>            1 2)))
>
>      (cond ((boundp 'compilation-error-regexp-systems-list)
>             ;; xemacs21
>             (setq elem (remove '(1) elem)) ;; drop "type" specifier
>             (add-to-list 'compilation-error-regexp-alist-alist
>                          (list (car elem) (cdr elem)))
>             (compilation-build-compilation-error-regexp-alist))
>
>            ((boundp 'compilation-error-regexp-alist-alist)
>             ;; emacs22
>             (add-to-list 'compilation-error-regexp-alist-alist elem)
>             (add-to-list 'compilation-error-regexp-alist (car elem)))
>
>            (t
>             ;; emacs21
>             (setq elem (remove '(1) elem)) ;; drop "type" specifier
>             (add-to-list 'compilation-error-regexp-alist (cdr elem))))))
>
> (provide 'compilation-perl)
>
> ;;; compilation-perl.el ends here
>
> - --=-=-=
> Content-Type: application/emacs-lisp
> Content-Disposition: attachment; filename=compilation-weblint.el
> Content-Transfer-Encoding: quoted-printable
>
> ;;; compilation-weblint.el --- error regexps for weblint
>
> ;; Copyright 2007 Kevin Ryde
>
> ;; Author: Kevin Ryde <user42@zip.com.au>
> ;; Version: 1
> ;; Keywords: processes
> ;; URL: http://www.geocities.com/user42_kevin/compilation/index.html
> ;; EmacsWiki: CompilationMode
>
> ;; compilation-weblint.el is free software; you can redistribute it and/or
> ;; modify it under the terms of the GNU General Public License as published
> ;; by the Free Software Foundation; either version 3, or (at your option)
> ;; any later version.
> ;;
> ;; compilation-weblint.el is distributed in the hope that it will be useful,
> ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
> ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
> ;; Public License for more details.
> ;;
> ;; You can get a copy of the GNU General Public License online at
> ;; <http://www.gnu.org/licenses>.
>
>
> ;;; Commentary:
>
> ;; This is a spot of code adding a `compilation-error-regexp-alist' pattern
> ;; for messages from the weblint program (the one based on the perl
> ;; HTML::Lint modules).
>
> ;;; Install:
>
> ;; Put compilation-weblint.el somewhere in your `load-path', and in .emacs =
> put
> ;;
> ;;     (eval-after-load "compile" '(require 'compilation-weblint))
> ;;
> ;; There's an autoload cookie below for this, if you use
> ;; `update-file-autoloads' and friends.
>
> ;;; Emacsen:
>
> ;; Works in Emacs 22, Emacs 21, and XEmacs 21.
>
> ;;; History:
>
> ;; Version 1 - the first version.
>
>
> ;;; Code:
>
> ;;;###autoload (eval-after-load "compile" '(require 'compilation-weblint))
>
> (eval-after-load "compile"
>   '(progn
>      ;; The style comes from HTML::Lint::Error::as_string(), eg.
>      ;; index.html (13:1) Unknown element <fdjsk>
>      ;;
>      ;; The pattern only matches filenames without spaces, since that should
>      ;; be usual and should help reduce the chance of a false match of a
>      ;; message from some unrelated program.
>      ;;
>      ;; This message style is quite close to the "ibm" entry of emacs22
>      ;; `compilation-error-regexp-alist-alist' which is for IBM C, though
>      ;; that ibm bit doesn't put a space after the filename.
>      ;;
>      (let ((elem '(compilation-weblint
>                    "^\\([^ \t\r\n(]+\\) (\\([0-9]+\\):\\([0-9]+\\)) "
>                    1 2 3)))
>
>        (cond ((boundp 'compilation-error-regexp-systems-list)
>               ;; xemacs21
>               (add-to-list 'compilation-error-regexp-alist-alist
>                            (list (car elem) (cdr elem)))
>               (compilation-build-compilation-error-regexp-alist))
>
>              ((boundp 'compilation-error-regexp-alist-alist)
>               ;; emacs22
>               (add-to-list 'compilation-error-regexp-alist-alist elem)
>               (add-to-list 'compilation-error-regexp-alist (car elem)))
>
>              (t
>               ;; emacs21
>               (add-to-list 'compilation-error-regexp-alist (cdr elem))
>
>               ;; Remove the "4.3BSD lint pass 3" element because it wrongly
>               ;; matches weblint messages.  It's apparently supposed to
>               ;; match something like
>               ;;
>               ;;     bloofle defined( /users/wolfgang/foo.c(4) ) ...
>               ;;
>               ;; but it's rather loose and ends up matching the "(13:1)"
>               ;; part from weblint as if "13" is the filename and "1" is the
>               ;; line number.  Forcibly removing this is a bit nasty, but
>               ;; emacs22 has dropped it, so consider it an upgrade!
>               ;;
>               ;; xemacs21 has the same pattern, but somehow the problem
>               ;; doesn't arise, so leave it alone there, for now.
>               ;;
>               (setq compilation-error-regexp-alist
>                     (remove '(".*([ \t]*\\([a-zA-Z]?:?[^:( \t\n]+\\)[:(][ \=
> t]*\\([0-9]+\\))" 1 2)
>                             compilation-error-regexp-alist)))))))
>
> (provide 'compilation-weblint)
>
> ;;; compilation-weblint.el ends here
>
> - --=-=-=
>
>
> - -- 
> "But I don't work Sundays or me day off."
>
> - --=-=-=
> Content-Type: text/plain; charset="us-ascii"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
>
> _______________________________________________
> gnu-emacs-sources mailing list
> gnu-emacs-sources@gnu.org
> http://lists.gnu.org/mailman/listinfo/gnu-emacs-sources
>
> - --=-=-=--
> ------- End of forwarded message -------
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel
>
>   

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12  4:01   ` Dan Nicolaescu
@ 2007-11-12 17:18     ` Richard Stallman
  2007-11-12 17:48     ` Vinicius Jose Latorre
  1 sibling, 0 replies; 12+ messages in thread
From: Richard Stallman @ 2007-11-12 17:18 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel

    For an outside package this is OK. But IMHO when including this stuff
    in emacs it might be a better idea to just add the patterns to
    compile.el and be done with it.

You're right -- they should definitely go in compile.el.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12  4:01   ` Dan Nicolaescu
  2007-11-12 17:18     ` Richard Stallman
@ 2007-11-12 17:48     ` Vinicius Jose Latorre
  2007-11-12 17:52       ` Vinicius Jose Latorre
  2007-11-12 17:55       ` Dan Nicolaescu
  1 sibling, 2 replies; 12+ messages in thread
From: Vinicius Jose Latorre @ 2007-11-12 17:48 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: rms, emacs-devel

Dan Nicolaescu wrote:
> Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>
>   > Richard Stallman wrote:
>   > > Would someone please install these error patterns in the trunk,
>   > > if they are correct?  (I cannot tell if they are correct.)
>   > >
>   > > We have papers from Kevin Ryde.
>   > >   
>   > 
>   > Installed in the trunk.
>
> Both new files do something like: 
>
> ;;;###autoload (eval-after-load "compile" '(require 'compilation-perl))
>
> the goal is just to add some patterns to
> compilation-error-regexp-alist*. 
>
> Isn't this ugly? 
>
> For an outside package this is OK. But IMHO when including this stuff
> in emacs it might be a better idea to just add the patterns to
> compile.el and be done with it.
>   


Is there any problem if I just installed the patterns
into compile.el as Dan suggests?

If the patterns are installed into compile.el, should the
compilation-perl.el and compilation-weblint.el files be removed?

If the patterns are not installed into compile.el, could I insert
at end of those files a command like below?

    (eval-after-load "compile" '(require 'compilation-perl))

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12 17:48     ` Vinicius Jose Latorre
@ 2007-11-12 17:52       ` Vinicius Jose Latorre
  2007-11-12 17:55       ` Dan Nicolaescu
  1 sibling, 0 replies; 12+ messages in thread
From: Vinicius Jose Latorre @ 2007-11-12 17:52 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: rms, emacs-devel

Vinicius Jose Latorre wrote:
> [......]
> If the patterns are not installed into compile.el, could I insert
> at end of those files a command like below?
>
>    (eval-after-load "compile" '(require 'compilation-perl))


Hummm, that is, insert at end of compile.el the following commands:

    (require 'compilation-perl)
    (require 'compilation-weblint)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12 17:48     ` Vinicius Jose Latorre
  2007-11-12 17:52       ` Vinicius Jose Latorre
@ 2007-11-12 17:55       ` Dan Nicolaescu
  2007-11-12 19:29         ` Vinicius Jose Latorre
  1 sibling, 1 reply; 12+ messages in thread
From: Dan Nicolaescu @ 2007-11-12 17:55 UTC (permalink / raw)
  To: Vinicius Jose Latorre; +Cc: rms, emacs-devel

Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:

  > Dan Nicolaescu wrote:
  > > Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
  > >
  > >   > Richard Stallman wrote:
  > >   > > Would someone please install these error patterns in the trunk,
  > >   > > if they are correct?  (I cannot tell if they are correct.)
  > >   > >
  > >   > > We have papers from Kevin Ryde.
  > >   > >     >   > Installed in the trunk.
  > >
  > > Both new files do something like: 
  > >
  > > ;;;###autoload (eval-after-load "compile" '(require 'compilation-perl))
  > >
  > > the goal is just to add some patterns to
  > > compilation-error-regexp-alist*. 
  > >
  > > Isn't this ugly? 
  > >
  > > For an outside package this is OK. But IMHO when including this stuff
  > > in emacs it might be a better idea to just add the patterns to
  > > compile.el and be done with it.
  > >   
  > 
  > 
  > Is there any problem if I just installed the patterns
  > into compile.el as Dan suggests?

When you add the patterns to compile.el, can you please add
corresponding entries to etc/compilation.txt ? 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12 17:55       ` Dan Nicolaescu
@ 2007-11-12 19:29         ` Vinicius Jose Latorre
  2007-11-14  9:10           ` Glenn Morris
  2007-12-29  0:52           ` Kevin Ryde
  0 siblings, 2 replies; 12+ messages in thread
From: Vinicius Jose Latorre @ 2007-11-12 19:29 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: rms, emacs-devel

Dan Nicolaescu wrote:
> Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>
>   > Dan Nicolaescu wrote:
>   > > Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>   > >
>   > >   > Richard Stallman wrote:
>   > >   > > Would someone please install these error patterns in the trunk,
>   > >   > > if they are correct?  (I cannot tell if they are correct.)
>   > >   > >
>   > >   > > We have papers from Kevin Ryde.
>   > >   > >     >   > Installed in the trunk.
>   > >
>   > > Both new files do something like: 
>   > >
>   > > ;;;###autoload (eval-after-load "compile" '(require 'compilation-perl))
>   > >
>   > > the goal is just to add some patterns to
>   > > compilation-error-regexp-alist*. 
>   > >
>   > > Isn't this ugly? 
>   > >
>   > > For an outside package this is OK. But IMHO when including this stuff
>   > > in emacs it might be a better idea to just add the patterns to
>   > > compile.el and be done with it.
>   > >   
>   > 
>   > 
>   > Is there any problem if I just installed the patterns
>   > into compile.el as Dan suggests?
>
> When you add the patterns to compile.el, can you please add
> corresponding entries to etc/compilation.txt ?
>   

Ok, done in trunk.

Patterns installed into lisp/progmodes/compile.el.

Corresponding entries into etc/compilation.txt.

Should the progmodes/compilation-perl.el and
progmodes/compilation-weblint.el files be removed?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12 19:29         ` Vinicius Jose Latorre
@ 2007-11-14  9:10           ` Glenn Morris
  2007-12-29  0:52           ` Kevin Ryde
  1 sibling, 0 replies; 12+ messages in thread
From: Glenn Morris @ 2007-11-14  9:10 UTC (permalink / raw)
  To: Vinicius Jose Latorre; +Cc: Dan Nicolaescu, rms, emacs-devel

Vinicius Jose Latorre wrote:

> Should the progmodes/compilation-perl.el and
> progmodes/compilation-weblint.el files be removed?

IMO, yes, without question.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-11-12 19:29         ` Vinicius Jose Latorre
  2007-11-14  9:10           ` Glenn Morris
@ 2007-12-29  0:52           ` Kevin Ryde
  2008-01-08  8:03             ` Glenn Morris
  1 sibling, 1 reply; 12+ messages in thread
From: Kevin Ryde @ 2007-12-29  0:52 UTC (permalink / raw)
  To: emacs-devel

Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>
> Patterns installed into lisp/progmodes/compile.el.

I've since or at some point also added a pattern for the two-arg form of
the Test module ok() func.

          ;; Or when comparing got/want values,
          ;; # Test 2 got: "xx" (t-compilation-perl-2.t at line 10)
          ;;
          ;; And under Test::Harness they're preceded by progress stuff with
          ;; \r and "NOK",
          ;; ... NOK 1# Test 1 got: "1234" (t/foo.t at line 46)
          ;;
          (compilation-perl--Test2
           "^\\(.*NOK.*\\)?# Test [0-9]+ got:.* (\\([^ \t\r\n]+\\) at line \\([0-9]+\\))"
           2 3)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2007-12-29  0:52           ` Kevin Ryde
@ 2008-01-08  8:03             ` Glenn Morris
  2008-01-21 20:45               ` Kevin Ryde
  0 siblings, 1 reply; 12+ messages in thread
From: Glenn Morris @ 2008-01-08  8:03 UTC (permalink / raw)
  To: Kevin Ryde; +Cc: emacs-devel

Kevin Ryde wrote:

> I've since or at some point also added a pattern for the two-arg form of
> the Test module ok() func.

Thanks; installed.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [user42@zip.com.au: compilation regexps for perl and weblint]
  2008-01-08  8:03             ` Glenn Morris
@ 2008-01-21 20:45               ` Kevin Ryde
  0 siblings, 0 replies; 12+ messages in thread
From: Kevin Ryde @ 2008-01-21 20:45 UTC (permalink / raw)
  To: emacs-devel

Glenn Morris <rgm@gnu.org> writes:
>
> Thanks; installed.

Incidentally, the only reason the keys were "compilation-weblint" or
"compilation-perl--xsubpp" was to identify my compilation-perl.el etc as
being the bit to blame.  Feel free to shorten to "weblint" or
"perl-Pod::Checker" or whatever.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2008-01-21 20:45 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-25  9:02 [user42@zip.com.au: compilation regexps for perl and weblint] Richard Stallman
2007-11-12  4:03 ` Vinicius Jose Latorre
2007-11-12  4:01   ` Dan Nicolaescu
2007-11-12 17:18     ` Richard Stallman
2007-11-12 17:48     ` Vinicius Jose Latorre
2007-11-12 17:52       ` Vinicius Jose Latorre
2007-11-12 17:55       ` Dan Nicolaescu
2007-11-12 19:29         ` Vinicius Jose Latorre
2007-11-14  9:10           ` Glenn Morris
2007-12-29  0:52           ` Kevin Ryde
2008-01-08  8:03             ` Glenn Morris
2008-01-21 20:45               ` Kevin Ryde

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.