From: Daiki Ueno <ueno@unixuser.org>
To: Glenn Morris <rgm@gnu.org>, Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: update of the EasyPG integration patch (Re: minor fixes for EasyPG
Date: Mon, 28 Apr 2008 08:21:21 +0900 [thread overview]
Message-ID: <87lk2ydgum.fsf@broken.deisui.org> (raw)
In-Reply-To: <gtskx7kpdu.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 27 Apr 2008 16:35:09 -0400")
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Glenn Morris <rgm@gnu.org> writes:
>> --- a/lisp/epa-file.el
>> +++ b/lisp/epa-file.el
>> @@ -126,7 +126,10 @@ May either be a string or a list of strings.")
>> (defun epa-file-handler (operation &rest args)
>> (save-match-data
>> (let ((op (get operation 'epa-file)))
>> - (if op
>> + (if (and op
>> + (if (and (eq operation 'insert-file-contents)
>> +
>> + (y-or-n-p ""
>> (apply op args)
>> (epa-file-run-real-handler operation args)))))
>
> This is broken.
Oops, I'm sorry. That is a wreck of a hack which reverted before
sending the patch.
Could you please apply the following fix (diff from the current trunk)?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: epa-file.el.diff --]
[-- Type: text/x-diff, Size: 641 bytes --]
Index: lisp/epa-file.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/epa-file.el,v
retrieving revision 1.7
diff -r1.7 epa-file.el
127,135c127,132
< ;; (save-match-data
< ;; (let ((op (get operation 'epa-file)))
< ;; (if (and op
< ;; (if (and (eq operation 'insert-file-contents)
<
< ;; (y-or-n-p ""
< ;; (apply op args)
< ;; (epa-file-run-real-handler operation args)))))
< nil)
---
> (save-match-data
> (let ((op (get operation 'epa-file)))
> (if op
> (apply op args)
> (epa-file-run-real-handler operation args)))))
>
[-- Attachment #3: Type: text/plain, Size: 25 bytes --]
Regards,
--
Daiki Ueno
next prev parent reply other threads:[~2008-04-27 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 3:05 minor fixes for EasyPG Daiki Ueno
2008-04-01 5:30 ` Michael Olson
2008-04-18 7:49 ` update of the EasyPG integration patch (Re: " Daiki Ueno
2008-04-27 19:56 ` Dan Nicolaescu
2008-04-27 20:35 ` Glenn Morris
2008-04-27 23:21 ` Daiki Ueno [this message]
2008-04-27 21:07 ` Dan Nicolaescu
2008-04-28 1:29 ` Daiki Ueno
2008-04-29 8:01 ` Stefan Monnier
2008-04-30 5:43 ` Daiki Ueno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lk2ydgum.fsf@broken.deisui.org \
--to=ueno@unixuser.org \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.