From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#694: marked as done (23.0.60; wrong behaviour of Date: Thu, 28 Aug 2008 13:50:35 -0400 Message-ID: <87ljyhkp04.fsf@cyd.mit.edu> References: <87ljyiyyud.fsf@cyd.mit.edu> <87vdxlw7wb.fsf@cyd.mit.edu> Reply-To: Chong Yidong , 694@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1219946904 14346 80.91.229.12 (28 Aug 2008 18:08:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Aug 2008 18:08:24 +0000 (UTC) Cc: 694@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 28 20:09:18 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYlvh-0005aF-Sk for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Aug 2008 20:09:10 +0200 Original-Received: from localhost ([127.0.0.1]:45455 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYluj-00058M-69 for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Aug 2008 14:08:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYluC-0004vi-Sw for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 14:07:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYluA-0004uY-Tg for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 14:07:36 -0400 Original-Received: from [199.232.76.173] (port=36449 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYluA-0004uK-Mf for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 14:07:34 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53528) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYlu9-0004JE-Ts for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 14:07:34 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7SI7Tik022562; Thu, 28 Aug 2008 11:07:29 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7SHt4Ru017393; Thu, 28 Aug 2008 10:55:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 28 Aug 2008 17:55:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 694 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 694-submit@emacsbugs.donarmstrong.com id=B694.121994572415479 (code B ref 694); Thu, 28 Aug 2008 17:55:04 +0000 Original-Received: (at 694) by emacsbugs.donarmstrong.com; 28 Aug 2008 17:48:44 +0000 Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7SHmftY015452 for <694@emacsbugs.donarmstrong.com>; Thu, 28 Aug 2008 10:48:42 -0700 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id F2A4957E186; Thu, 28 Aug 2008 13:50:35 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Thu\, 28 Aug 2008 12\:02\:21 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2.91 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Thu, 28 Aug 2008 14:07:36 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19813 Archived-At: Stefan Monnier writes: >>>> I believe vc-workfile-unchanged-p and if the two timestamsps are the >>>> same, it can conclude that the file is unchanged, but if the >>>> timestamps are different, it should call the backend specific >>>> workfile-unchanged-p function. >>> >>> For CVS if the user requested to `stay-local', this is not quite right >>> either since it will connect to the server. Admittedly, there's no way >>> to get the right answer without connecting to the server, but this >>> behavior has been with us for years and I usually consider it a feature >>> (most/all the CVS servers I use are usually remote/slow/unreachable, so >>> it's important to have control over when VC contacts the server and when >>> it doesn't). > >> Should I revert the patch then? > > I'm not sure, but I'd tend to think so, yes. Okay, reverted. I inserted a comment in the code linking to this discussion.