From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alexandre Julliard Newsgroups: gmane.emacs.devel Subject: Re: vc-git-show-log-entry Date: Tue, 21 Oct 2008 19:52:05 +0200 Message-ID: <87ljwhlttm.fsf@wine.dyndns.org> References: <200810201819.m9KIJ6Wh024634@mothra.ics.uci.edu> <200810202210.m9KMAALe025685@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224611572 24710 80.91.229.12 (21 Oct 2008 17:52:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Oct 2008 17:52:52 +0000 (UTC) Cc: Karl Chen , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 21 19:53:48 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KsLQB-00031n-JB for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 19:53:31 +0200 Original-Received: from localhost ([127.0.0.1]:58065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsLP6-00076w-6z for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 13:52:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KsLP1-00075L-2u for emacs-devel@gnu.org; Tue, 21 Oct 2008 13:52:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KsLOz-00074j-T6 for emacs-devel@gnu.org; Tue, 21 Oct 2008 13:52:18 -0400 Original-Received: from [199.232.76.173] (port=46415 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsLOz-00074g-KO for emacs-devel@gnu.org; Tue, 21 Oct 2008 13:52:17 -0400 Original-Received: from mail.codeweavers.com ([216.251.189.131]:45271) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KsLOz-0003LH-Ax for emacs-devel@gnu.org; Tue, 21 Oct 2008 13:52:17 -0400 Original-Received: from adsl-89-217-242-125.adslplus.ch ([89.217.242.125] helo=wine.dyndns.org) by mail.codeweavers.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1KsLOp-0008Q8-TZ; Tue, 21 Oct 2008 12:52:14 -0500 Original-Received: by wine.dyndns.org (Postfix, from userid 1000) id 8769B1E716E; Tue, 21 Oct 2008 19:52:05 +0200 (CEST) In-Reply-To: <200810202210.m9KMAALe025685@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 20 Oct 2008 15:10:10 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Spam-Score: -3.9 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104765 Archived-At: Dan Nicolaescu writes: > Karl Chen writes: > > As I said, if you undo the latest commit to vc-git.el, that fixes > > it, but I suggest this replacement altogether. > > > > (defun vc-git-show-log-entry (rev) > > (log-view-goto-rev (vc-git-rev-parse rev))) > > Not sure if adding yet another git invocation here is a good idea. > Please run your change by Alexandre Julliard. It's definitely a good idea. There's just no way to reliably convert a symbolic revision name to a number of commits to skip, the current vc-git-show-log-entry implementation is clearly broken. The only sane way is to use git rev-parse and then look for the sha1. -- Alexandre Julliard julliard@winehq.org