From: Alexandre Julliard <julliard@winehq.org>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Karl Chen <quarl@cs.berkeley.edu>, emacs-devel@gnu.org
Subject: Re: vc-git-show-log-entry
Date: Tue, 21 Oct 2008 19:52:05 +0200 [thread overview]
Message-ID: <87ljwhlttm.fsf@wine.dyndns.org> (raw)
In-Reply-To: <200810202210.m9KMAALe025685@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 20 Oct 2008 15:10:10 -0700 (PDT)")
Dan Nicolaescu <dann@ics.uci.edu> writes:
> Karl Chen <quarl@cs.berkeley.edu> writes:
> > As I said, if you undo the latest commit to vc-git.el, that fixes
> > it, but I suggest this replacement altogether.
> >
> > (defun vc-git-show-log-entry (rev)
> > (log-view-goto-rev (vc-git-rev-parse rev)))
>
> Not sure if adding yet another git invocation here is a good idea.
> Please run your change by Alexandre Julliard.
It's definitely a good idea. There's just no way to reliably convert a
symbolic revision name to a number of commits to skip, the current
vc-git-show-log-entry implementation is clearly broken. The only sane
way is to use git rev-parse and then look for the sha1.
--
Alexandre Julliard
julliard@winehq.org
prev parent reply other threads:[~2008-10-21 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 9:36 vc-git-show-log-entry Karl Chen
2008-10-20 15:01 ` vc-git-show-log-entry Eric Hanchrow
2008-10-20 15:09 ` vc-git-show-log-entry Eric Hanchrow
2008-10-20 18:19 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-20 20:20 ` vc-git-show-log-entry Karl Chen
2008-10-20 22:10 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21 7:23 ` vc-git-show-log-entry Karl Chen
2008-10-21 8:49 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21 17:52 ` Alexandre Julliard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljwhlttm.fsf@wine.dyndns.org \
--to=julliard@winehq.org \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=quarl@cs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.