From: Juri Linkov <juri@jurta.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] emacs/lisp image.el
Date: Sun, 30 Aug 2009 01:46:23 +0300 [thread overview]
Message-ID: <87ljl2z3ex.fsf@mail.jurta.org> (raw)
In-Reply-To: <f7ccd24b0908281721x5e585e82y2cf68ab0584b8b2a@mail.gmail.com> (Juanma Barranquero's message of "Sat, 29 Aug 2009 02:21:24 +0200")
>> Log message:
>> (image-type-header-regexps): Use only JPEG magic number
>> to determine JPEG images, and don't use `image-jpeg-p' because
>> Emacs can display non-JFIF non-Exif JPEG images.
>
> Then we should perhaps obsolete `image-jpeg-p' (which is not used
> anymore in the sources).
>
> Currently it does what its docstring says, but there's some of a
> mismatch with the name (which seems to imply more generality); also it
> is not clear what purpose does serve a function to detect just
> JFIF/Exif JPEGs. And generalizing it would turn it into a trivial
> two-liner.
I left `image-jpeg-p' in image.el for the case it's used by some
external packages or .emacs files since it contains a non-trivial
algorithm for detecting JFIF/Exif JPEGs. Even though its name is
not too specific, its docstring explains what it does.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-08-29 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1MhBBw-0007QN-2z@cvs.savannah.gnu.org>
2009-08-29 0:21 ` [Emacs-diffs] emacs/lisp image.el Juanma Barranquero
2009-08-29 22:46 ` Juri Linkov [this message]
2009-08-29 23:14 ` Juanma Barranquero
2009-08-30 20:51 ` Juri Linkov
2009-08-31 15:15 ` Chong Yidong
2009-08-31 23:49 ` Stefan Monnier
2009-09-01 0:05 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljl2z3ex.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.