From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add defined-colors-with-face-attributes to faces.el Date: Fri, 01 Jan 2010 15:13:10 -0500 Message-ID: <87ljghy46h.fsf@stupidchicken.com> References: <28417_1262370107_ZZg0N5S7X6c9t.00_1262370106.3761.1186.camel@localhost.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1262381426 3269 80.91.229.12 (1 Jan 2010 21:30:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Jan 2010 21:30:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jan Moringen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 01 22:30:18 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NQp4Z-0002DQ-KZ for ged-emacs-devel@m.gmane.org; Fri, 01 Jan 2010 22:30:15 +0100 Original-Received: from localhost ([127.0.0.1]:58745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQp4a-0002nW-36 for ged-emacs-devel@m.gmane.org; Fri, 01 Jan 2010 16:30:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQp2u-0001MC-Tn for emacs-devel@gnu.org; Fri, 01 Jan 2010 16:28:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQp2q-0001HX-EU for emacs-devel@gnu.org; Fri, 01 Jan 2010 16:28:32 -0500 Original-Received: from [199.232.76.173] (port=56442 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQp2q-0001HU-8y for emacs-devel@gnu.org; Fri, 01 Jan 2010 16:28:28 -0500 Original-Received: from pantheon-po29.its.yale.edu ([130.132.50.124]:54622) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQp2q-0006qZ-0p for emacs-devel@gnu.org; Fri, 01 Jan 2010 16:28:28 -0500 Original-Received: from furry (162.254.218.209.transedge.com [209.218.254.162]) (authenticated bits=0) by pantheon-po29.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o01LSQt3024906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 1 Jan 2010 16:28:27 -0500 Original-Received: by furry (Postfix, from userid 1000) id D8B8DC07A; Fri, 1 Jan 2010 15:13:10 -0500 (EST) In-Reply-To: <28417_1262370107_ZZg0N5S7X6c9t.00_1262370106.3761.1186.camel@localhost.localdomain> (Jan Moringen's message of "Fri, 01 Jan 2010 19:21:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119233 Archived-At: Jan Moringen writes: > in an application I wrote, the user is prompted for a color using > `read-color'. The completion table used there presents color names. > However, based on color names alone, I often found it hard to choose a > color. Therefore I wrote `defined-colors-with-face-attributes' which is > like `defined-colors' but adds text properties to the color names that > make them render with the color they name as background. I also changed > `read-color' to call the new function when a color display is available. > > I have tested the new behavior on X displays and TTYs and it seems to > work. However, I could not test windows or other terminal types and/or > other color depths. > > If this change is considered useful, I would like to contribute it. I > have done the copyright assignment for Emacs. We're in feature freeze at the moment, so come back after Emacs 23.2 is released. In the meantime, you can send this to bug-gnu-emacs so that the message is not lost.