From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: pointless buttons at end of VC log buffers Date: Tue, 16 Feb 2010 14:15:45 +0100 Message-ID: <87ljetz5ha.fsf@telefonica.net> References: <87pr45zqn3.fsf@telefonica.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1266326186 30829 80.91.229.12 (16 Feb 2010 13:16:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Feb 2010 13:16:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 16 14:16:19 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NhNHm-0007Z0-PP for ged-emacs-devel@m.gmane.org; Tue, 16 Feb 2010 14:16:19 +0100 Original-Received: from localhost ([127.0.0.1]:42643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhNHm-0000gY-4Y for ged-emacs-devel@m.gmane.org; Tue, 16 Feb 2010 08:16:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhNHf-0000gG-JD for emacs-devel@gnu.org; Tue, 16 Feb 2010 08:16:11 -0500 Original-Received: from [140.186.70.92] (port=41102 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhNHd-0000fv-Li for emacs-devel@gnu.org; Tue, 16 Feb 2010 08:16:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhNHd-0000Vk-0u for emacs-devel@gnu.org; Tue, 16 Feb 2010 08:16:09 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:43812) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhNHc-0000Va-Pp for emacs-devel@gnu.org; Tue, 16 Feb 2010 08:16:08 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NhNHZ-0007SP-FF for emacs-devel@gnu.org; Tue, 16 Feb 2010 14:16:05 +0100 Original-Received: from 206.red-81-33-105.dynamicip.rima-tde.net ([81.33.105.206]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 16 Feb 2010 14:16:05 +0100 Original-Received: from ofv by 206.red-81-33-105.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 16 Feb 2010 14:16:05 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 206.red-81-33-105.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) Cancel-Lock: sha1:dwWUAmHMKwQBtWwctIU6GSqPTgY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121141 Archived-At: Miles Bader writes: > Óscar Fuentes writes: >>> * It seems like it should only show these buttons if the log listing >>> gets interrupted for some reason. >> >> For this, VC-log needs to count how many revisions it is showing and >> compare with the number of revisions on the branch. Looks like too much >> work. OTOH, on some backends (i.e. git) it is difficult to differentiate >> the first (oldest) revision from any other on the log listing, as it >> lacks revision numbers. > > I don't understand this.... > > The underlying log command outputs all revisions by default, so if it > didn't output all of them, that must have explicitly been requested by > emacs, so emacs should know about it. By default, Emacs asks to the underlying log command to output `vc-log-show-limit' items, which right now defaults to 2000. However, if there are less revisions, Emacs would need to detect this circumstance somehow for knowing that the buttons are of no use. > [Also, is it supposed to be operating incrementally? At least with git, > it just pauses for a while and then outputs the entire log at once.] AFAIK, it runs asynchronously.