From: Eric S Fraga <ucecesf@ucl.ac.uk>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [patch] icalendar extended to define alarm triggers for timed events
Date: Fri, 02 Jul 2010 13:56:18 +0100 [thread overview]
Message-ID: <87lj9um499.wl%ucecesf@ucl.ac.uk> (raw)
In-Reply-To: <31F9B22E-8EA7-48C4-86EB-F24645E4DB2A@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On Fri, 2 Jul 2010 08:53:06 +0200, Carsten Dominik <carsten.dominik@gmail.com> wrote:
>
> Hi Eric,
>
>
> On Jul 1, 2010, at 12:44 AM, Eric S Fraga wrote:
>
> > Hello,
> >
> > attached is a rudimentary patch for org-icalendar.el to add the
> > definition of alarm triggers for timed events that are exported to
> > icalendar format. The default is to behave as it does at the moment
> > however.
> >
> > I hope it proves passable (given my less than brilliant elisp
> > expertise...).
>
> This looks pretty good!
> But can you please
>
> - Make sure that the first line of the docstring of the new variable
> fits into 75 characters (better: 72)?
> You already have made it a stand-alone sentence, which is also
> needed.
>
> - It would also be helpful if if can make git commit and
> include the proper commit message including a ChangeLog-like entry
> as the second paragraph in that message.
>
> Great work!
>
> - Carsten
>
Thanks Carsten.
I have seen the few messages regarding how to submit patches so I see
now what you would like. I'll try to do that this weekend (I'm not au
fait with git but I think the instructions are fairly clear...).
[-- Attachment #2: Type: text/plain, Size: 75 bytes --]
--
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29 570D C891 93D8 FFFC F67D
[-- Attachment #3: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2010-07-02 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 22:44 [patch] icalendar extended to define alarm triggers for timed events Eric S Fraga
2010-07-02 6:53 ` Carsten Dominik
2010-07-02 12:56 ` Eric S Fraga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lj9um499.wl%ucecesf@ucl.ac.uk \
--to=ucecesf@ucl.ac.uk \
--cc=carsten.dominik@gmail.com \
--cc=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.