From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [patch] make shell-process-popd aware of comint-file-name-prefix Date: Sat, 06 Nov 2010 13:14:00 +0100 Message-ID: <87lj56abuf.fsf@gmx.de> References: <87wroq3mzi.fsf@abtela.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289045663 698 80.91.229.12 (6 Nov 2010 12:14:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 6 Nov 2010 12:14:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christian Millour Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 06 13:14:19 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PEhey-0005gy-J8 for ged-emacs-devel@m.gmane.org; Sat, 06 Nov 2010 13:14:16 +0100 Original-Received: from localhost ([127.0.0.1]:42885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEhey-0007ND-29 for ged-emacs-devel@m.gmane.org; Sat, 06 Nov 2010 08:14:16 -0400 Original-Received: from [140.186.70.92] (port=36826 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEhet-0007L6-Q9 for emacs-devel@gnu.org; Sat, 06 Nov 2010 08:14:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PEhes-0005Jp-Gy for emacs-devel@gnu.org; Sat, 06 Nov 2010 08:14:11 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:35367 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PEhes-0005JO-4H for emacs-devel@gnu.org; Sat, 06 Nov 2010 08:14:10 -0400 Original-Received: (qmail invoked by alias); 06 Nov 2010 12:14:08 -0000 Original-Received: from p4FC184F8.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [79.193.132.248] by mail.gmx.net (mp059) with SMTP; 06 Nov 2010 13:14:08 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/woftar8vwDSJX4wJP5DdXY+qGSuOX0dn346+UO7 S48255JRbhwT5U In-Reply-To: <87wroq3mzi.fsf@abtela.com> (Christian Millour's message of "Sat, 06 Nov 2010 08:55:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132414 Archived-At: Christian Millour writes: > Hi, Hi, > shell-process-popd (in lisp/shell.el) is currently unaware of > comint-file-name-prefix. This is inconsistent with the behavior of > shell-process-pushd and shell-process-cd, and hampers proper directory > tracking in tramp remote shells (see > http://lists.gnu.org/archive/html/tramp-devel/2010-11/msg00013.html > ). The attached patch should correct this oversight. Thanks, I've committed your patch. It is less than 15 lines, it can be regarded as tiny patch, therefore. > This is my first stab at contributing to emacs so please be patient and > forgiving if I did not do it right or missed something. If you intend to submit further patches to Emacs and/or Tramp, it would be necessary to register at FSF (and sign the legal papers). Just contact me in case of. > Best regards, Christian. Best regards, Michael.