From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.devel Subject: Re: md5 broken? Date: Sat, 28 May 2011 15:32:50 +0200 Message-ID: <87lixrt0fx.fsf@rho.meyering.net> References: <87ipsv188f.fsf@gmail.com> <87zkm7t3n4.fsf@rho.meyering.net> <83hb8fasyb.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306589585 29018 80.91.229.12 (28 May 2011 13:33:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 28 May 2011 13:33:05 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org, antoine.levitt@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 28 15:33:01 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QQJdV-0002XE-05 for ged-emacs-devel@m.gmane.org; Sat, 28 May 2011 15:33:01 +0200 Original-Received: from localhost ([::1]:40897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQJdU-0002X9-8Y for ged-emacs-devel@m.gmane.org; Sat, 28 May 2011 09:33:00 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQJdQ-0002Ww-O3 for emacs-devel@gnu.org; Sat, 28 May 2011 09:32:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQJdP-0000n7-RD for emacs-devel@gnu.org; Sat, 28 May 2011 09:32:56 -0400 Original-Received: from mx.meyering.net ([82.230.74.64]:38426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQJdL-0000ml-DZ; Sat, 28 May 2011 09:32:51 -0400 Original-Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 8AEC8602F2; Sat, 28 May 2011 15:32:50 +0200 (CEST) In-Reply-To: <83hb8fasyb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 May 2011 15:51:56 +0300") Original-Lines: 43 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 82.230.74.64 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139833 Archived-At: Eli Zaretskii wrote: >> From: Jim Meyering >> Date: Sat, 28 May 2011 14:23:43 +0200 >> Cc: Paul Eggert , emacs-devel@gnu.org >> >> +static inline unsigned char to_uchar (char ch) { return ch; } > > I think this should use "INLINE", upper-cased, rather than "inline", > for those compilers that don't support the `inline' keyword. See > src/config.in. Using "inline" is fine because of the configure-time test that defines "inline" to nothing when it is not supported: $ grep -A4 to..__inline src/config.h : /* Define to `__inline__' or `__inline' if that's what the C compiler calls it, or to nothing if 'inline' is not supported under any name. */ #ifndef __cplusplus /* #undef inline */ #endif There is one other use already: lread.c:2256:static inline int There are far more uses of INLINE: $ git grep -w INLINE|grep -cw INLINE 144 Is there any reason not to replace all uses of INLINE with "inline" and to remove the following from configure.in? I see no use of "extern INLINE" anywhere in emacs: /* If using GNU, then support inline function declarations. */ /* Don't try to switch on inline handling as detected by AC_C_INLINE generally, because even if non-gcc compilers accept `inline', they may reject `extern inline'. */ #if defined (__GNUC__) #define INLINE __inline__ #else #define INLINE #endif