all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org, antoine.levitt@gmail.com
Subject: Re: md5 broken?
Date: Sat, 28 May 2011 15:32:50 +0200	[thread overview]
Message-ID: <87lixrt0fx.fsf@rho.meyering.net> (raw)
In-Reply-To: <83hb8fasyb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 May 2011 15:51:56 +0300")

Eli Zaretskii wrote:
>> From: Jim Meyering <jim@meyering.net>
>> Date: Sat, 28 May 2011 14:23:43 +0200
>> Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
>>
>> +static inline unsigned char to_uchar (char ch) { return ch; }
>
> I think this should use "INLINE", upper-cased, rather than "inline",
> for those compilers that don't support the `inline' keyword.  See
> src/config.in.

Using "inline" is fine because of the configure-time test that
defines "inline" to nothing when it is not supported:

    $ grep -A4 to..__inline src/config.h                                         :
    /* Define to `__inline__' or `__inline' if that's what the C compiler
       calls it, or to nothing if 'inline' is not supported under any name.  */
    #ifndef __cplusplus
    /* #undef inline */
    #endif

There is one other use already:

    lread.c:2256:static inline int

There are far more uses of INLINE:

    $ git grep -w INLINE|grep -cw INLINE
    144

Is there any reason not to replace all uses of INLINE with "inline"
and to remove the following from configure.in?  I see no use of
"extern INLINE" anywhere in emacs:

    /* If using GNU, then support inline function declarations.  */
    /* Don't try to switch on inline handling as detected by AC_C_INLINE
       generally, because even if non-gcc compilers accept `inline', they
       may reject `extern inline'.  */
    #if defined (__GNUC__)
    #define INLINE __inline__
    #else
    #define INLINE
    #endif



  reply	other threads:[~2011-05-28 13:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28  9:32 md5 broken? Antoine Levitt
2011-05-28 12:23 ` Jim Meyering
2011-05-28 12:28   ` Antoine Levitt
2011-05-28 12:51   ` Eli Zaretskii
2011-05-28 13:32     ` Jim Meyering [this message]
2011-05-28 14:10       ` Eli Zaretskii
2011-05-28 16:09         ` Paul Eggert
2011-05-28 16:55           ` Eli Zaretskii
2011-05-28 19:12             ` Paul Eggert
2011-05-28 19:35               ` Eli Zaretskii
2011-05-28 22:47                 ` INLINE -> inline (was: md5 broken?) Paul Eggert
2011-05-29  4:51                   ` Eli Zaretskii
2011-05-29  8:05                   ` INLINE -> inline Jim Meyering
2011-05-30  2:47           ` md5 broken? Ken Raeburn
2011-05-30  5:31             ` Paul Eggert
2011-05-31  4:22               ` Ken Raeburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lixrt0fx.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=antoine.levitt@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.