From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.devel Subject: Re: INLINE -> inline Date: Sun, 29 May 2011 10:05:07 +0200 Message-ID: <87lixqq6do.fsf@rho.meyering.net> References: <87ipsv188f.fsf@gmail.com> <87zkm7t3n4.fsf@rho.meyering.net> <83hb8fasyb.fsf@gnu.org> <87lixrt0fx.fsf@rho.meyering.net> <83fwnyc3v1.fsf@gnu.org> <4DE11E56.9040506@cs.ucla.edu> <83d3j2bw9g.fsf@gnu.org> <4DE14913.9080507@cs.ucla.edu> <838vtqbotu.fsf@gnu.org> <4DE17B71.80102@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306656327 7435 80.91.229.12 (29 May 2011 08:05:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 29 May 2011 08:05:27 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org, antoine.levitt@gmail.com To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 29 10:05:22 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QQazs-0003tl-6k for ged-emacs-devel@m.gmane.org; Sun, 29 May 2011 10:05:16 +0200 Original-Received: from localhost ([::1]:35495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQazr-0000o4-FE for ged-emacs-devel@m.gmane.org; Sun, 29 May 2011 04:05:15 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:32987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQazn-0000nw-CF for emacs-devel@gnu.org; Sun, 29 May 2011 04:05:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQazm-0001Kk-E8 for emacs-devel@gnu.org; Sun, 29 May 2011 04:05:11 -0400 Original-Received: from mx.meyering.net ([82.230.74.64]:50778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQazj-0001Jj-Rp; Sun, 29 May 2011 04:05:08 -0400 Original-Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 34B91600B8; Sun, 29 May 2011 10:05:07 +0200 (CEST) In-Reply-To: <4DE17B71.80102@cs.ucla.edu> (Paul Eggert's message of "Sat, 28 May 2011 15:47:13 -0700") Original-Lines: 34 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 82.230.74.64 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139874 Archived-At: Paul Eggert wrote: > On 05/28/11 12:35, Eli Zaretskii wrote: >> I'm saying that we should have only >> one of "INLINE" and "inline", not both. > > Yes, that makes sense. Since 'inline' is standard and is widely > used in other GNU packages, it makes sense to use it in Emacs too. > That will shorten the Emacs source code and make it easier for > others to understand. Here's a proposed patch to do that. > I've tested it on Fedora 14 x86_64. Nice. I wrote nearly the same patch, but prefer yours for the additional changes like this and the ones in gmalloc.c and lisp.h that further normalize __inline and __inline__ to inline and remove those ifdefs. > === modified file 'lib-src/etags.c' > --- lib-src/etags.c 2011-05-21 02:27:00 +0000 > +++ lib-src/etags.c 2011-05-28 22:01:45 +0000 > @@ -2360,14 +2360,7 @@ > struct C_stab_entry { const char *name; int c_ext; enum sym_type type; }; > /* maximum key range = 33, duplicates = 0 */ > > -#ifdef __GNUC__ > -__inline > -#else > -#ifdef __cplusplus > -inline > -#endif > -#endif > -static unsigned int > +static inline unsigned int > hash (register const char *str, register unsigned int len) > { > static unsigned char asso_values[] =