From: Jim Meyering <jim@meyering.net>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org, antoine.levitt@gmail.com
Subject: Re: INLINE -> inline
Date: Sun, 29 May 2011 10:05:07 +0200 [thread overview]
Message-ID: <87lixqq6do.fsf@rho.meyering.net> (raw)
In-Reply-To: <4DE17B71.80102@cs.ucla.edu> (Paul Eggert's message of "Sat, 28 May 2011 15:47:13 -0700")
Paul Eggert wrote:
> On 05/28/11 12:35, Eli Zaretskii wrote:
>> I'm saying that we should have only
>> one of "INLINE" and "inline", not both.
>
> Yes, that makes sense. Since 'inline' is standard and is widely
> used in other GNU packages, it makes sense to use it in Emacs too.
> That will shorten the Emacs source code and make it easier for
> others to understand. Here's a proposed patch to do that.
> I've tested it on Fedora 14 x86_64.
Nice. I wrote nearly the same patch, but prefer yours for the additional
changes like this and the ones in gmalloc.c and lisp.h that further
normalize __inline and __inline__ to inline and remove those ifdefs.
> === modified file 'lib-src/etags.c'
> --- lib-src/etags.c 2011-05-21 02:27:00 +0000
> +++ lib-src/etags.c 2011-05-28 22:01:45 +0000
> @@ -2360,14 +2360,7 @@
> struct C_stab_entry { const char *name; int c_ext; enum sym_type type; };
> /* maximum key range = 33, duplicates = 0 */
>
> -#ifdef __GNUC__
> -__inline
> -#else
> -#ifdef __cplusplus
> -inline
> -#endif
> -#endif
> -static unsigned int
> +static inline unsigned int
> hash (register const char *str, register unsigned int len)
> {
> static unsigned char asso_values[] =
next prev parent reply other threads:[~2011-05-29 8:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 9:32 md5 broken? Antoine Levitt
2011-05-28 12:23 ` Jim Meyering
2011-05-28 12:28 ` Antoine Levitt
2011-05-28 12:51 ` Eli Zaretskii
2011-05-28 13:32 ` Jim Meyering
2011-05-28 14:10 ` Eli Zaretskii
2011-05-28 16:09 ` Paul Eggert
2011-05-28 16:55 ` Eli Zaretskii
2011-05-28 19:12 ` Paul Eggert
2011-05-28 19:35 ` Eli Zaretskii
2011-05-28 22:47 ` INLINE -> inline (was: md5 broken?) Paul Eggert
2011-05-29 4:51 ` Eli Zaretskii
2011-05-29 8:05 ` Jim Meyering [this message]
2011-05-30 2:47 ` md5 broken? Ken Raeburn
2011-05-30 5:31 ` Paul Eggert
2011-05-31 4:22 ` Ken Raeburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lixqq6do.fsf@rho.meyering.net \
--to=jim@meyering.net \
--cc=antoine.levitt@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.