From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: RFC: [PATCH] isearch enhancements: symbol mode; syntactic filtering Date: Fri, 08 Jul 2011 03:20:20 +0300 Organization: JURTA Message-ID: <87liw9mxrh.fsf@mail.jurta.org> References: <4E15C0BA.10400@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1310084472 826 80.91.229.12 (8 Jul 2011 00:21:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 8 Jul 2011 00:21:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 08 02:21:07 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qeyod-0007NA-6h for ged-emacs-devel@m.gmane.org; Fri, 08 Jul 2011 02:21:07 +0200 Original-Received: from localhost ([::1]:37246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qeyob-0005mt-NG for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2011 20:21:05 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:46457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeyoJ-0005lp-Rj for emacs-devel@gnu.org; Thu, 07 Jul 2011 20:20:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QeyoF-0006JA-43 for emacs-devel@gnu.org; Thu, 07 Jul 2011 20:20:46 -0400 Original-Received: from smarty.dreamhost.com ([208.113.175.8]:41022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeyoD-0006HZ-JV for emacs-devel@gnu.org; Thu, 07 Jul 2011 20:20:41 -0400 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 7FC986E8064; Thu, 7 Jul 2011 17:20:38 -0700 (PDT) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 4BA3E451C1A5; Thu, 7 Jul 2011 17:20:36 -0700 (PDT) In-Reply-To: <4E15C0BA.10400@gmail.com> (Daniel Colascione's message of "Thu, 07 Jul 2011 07:20:42 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.113.175.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141768 Archived-At: > - Syntactic filtering: control whether to match in comments, strings, and > normal text. This is easier to implement using `isearch-filter-predicate' as shown in http://thread.gmane.org/gmane.emacs.devel/34742 Unfortunately, I failed to find a good keybinding for this feature, so it sunk into obscurity. > - Symbol search: like word search, but looks only at symbol boundaries This is much needed. But I think it should have a keybinding separate from word search. Currently, `M-s w' toggles word search, so a new keybinding `M-s _' could toggle symbol search. > - One ring: optionally share a search ring between normal and regular > expression searches. The additional history storage described below allows > this mode to work reliably. Maybe sharing a search ring between normal and regexp searches would be better to implement in the same way as sharing `from' and `to' histories is implemented in `query-replace'? Like two variables `query-replace-from-history-variable' and `query-replace-to-history-variable', isearch could provide two variables `isearch-ring-variable' and `isearch-regexp-ring-variable'. > The patch also changes some behavior: > > - With the patch, we store isearch state in the history ring alongside the > actual search strings. This information allows us to exactly recreate > searches when we pull them from history. Yes, storing more information about searches is a good change. > Other behavior changes > ---------------------- > > - Case sensitivity is now displayed alongside other isearch settings in the > isearch prompt. Previously, the only indication we gave of case > sensitivity was a fleeing message displayed briefly each time the user > toggled the setting. This is a good change as well, but one possible problem is that its message string "case-insensitive " (17 characters) is too long for the isearch prompt. > - isearch no longer prints "pending". I don't see why this message would > be useful. "pending" reminds the user that the actual search position doesn't correspond to the search parameters displayed in the search prompt. This happens after e.g. changing the search type to regexp or word. Updating the search position might be more surprising for users.