From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: OAuth2 implementation in Elisp Date: Sun, 25 Sep 2011 08:31:27 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87litc695c.fsf@lifelogs.com> References: <87sjnojl7j.fsf@keller.adm.naquadah.org> <4E7BAFA4.8090800@dogan.se> <4E7BAFE2.2090102@dogan.se> <87k490jkaw.fsf@keller.adm.naquadah.org> <87d3eo984j.fsf@lifelogs.com> <87mxdsbx1n.fsf@keller.adm.naquadah.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1316957512 18474 80.91.229.12 (25 Sep 2011 13:31:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Sep 2011 13:31:52 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 25 15:31:49 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R7oo7-00061N-UV for ged-emacs-devel@m.gmane.org; Sun, 25 Sep 2011 15:31:48 +0200 Original-Received: from localhost ([::1]:51266 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7oo7-0002iQ-AK for ged-emacs-devel@m.gmane.org; Sun, 25 Sep 2011 09:31:47 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7oo4-0002i7-Oo for emacs-devel@gnu.org; Sun, 25 Sep 2011 09:31:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R7oo3-00052F-D2 for emacs-devel@gnu.org; Sun, 25 Sep 2011 09:31:44 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:59232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7oo3-00051v-00 for emacs-devel@gnu.org; Sun, 25 Sep 2011 09:31:43 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1R7oo2-0005zM-7Y for emacs-devel@gnu.org; Sun, 25 Sep 2011 15:31:42 +0200 Original-Received: from 38.98.147.133 ([38.98.147.133]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 25 Sep 2011 15:31:42 +0200 Original-Received: from tzz by 38.98.147.133 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 25 Sep 2011 15:31:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 52 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.133 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:+8mUh04jNnViDSkP2LDC9XP82Rw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:144279 Archived-At: On Sun, 25 Sep 2011 14:56:20 +0200 Julien Danjou wrote: JD> On Sun, Sep 25 2011, Ted Zlatanov wrote: >> Could you format it to wrap the long lines? JD> Long? What's the limit? The longest is 122, which does not seem long to JD> me in 2011. If you could stay under 78 it would be polite. I can't find the reference but I'm pretty sure for Emacs submissions at least it's required. >> Some usage examples would be nice. JD> Sure, I'll may be add, but the commentary should be enough for anybody JD> to start using it. :) It wasn't for me, sorry. I don't know OAuth2 well. >> I don't think you are encoding URL parameters so your URLs are not >> safely constructed. I think the url libraries have functions for that; >> you could also submit a POST (if OAuth2 supports it, I don't know the >> spec) so you don't have to encode things at all. JD> It is a POST request for the authorization request. And about encoding, JD> I'm not sure there's actually a problem, but if you could point me on a JD> specific point I'd be glad to take a look. #+begin_src lisp (browse-url (concat auth-url (if (string-match-p "\?" auth-url) "&" "?") "client_id=" client-id "&response_type=code&redirect_uri=urn:ietf:wg:oauth:2.0:oob" (if scope (concat "&scope=" (url-hexify-string scope)) "") (if state (concat "&state=" state) ""))) #+end_src This is not a POST and `client_id' for instance could have invalid characters for a URL. >> Can `oauth2-request-authorization' be automated so the user doesn't have >> to enter a string they see on the screen? That seems painful. JD> If Emacs was a Web app, yes. That makes no sense. You are asking the user to enter information Emacs is displaying. Can you grab that information for them, so they don't have to enter it? Thanks Ted